# [PATCH 1/3] Fix potential command line overflow in hooks--update

2 messages from 2007-02-13 to 2007-02-13. Participants: Andy Parkins, Junio C Hamano.
Thread: https://gitlist.dev/t/6798

## Andy Parkins, 2007-02-13 14:23

Subject: [PATCH 1/3] Fix potential command line overflow in hooks--update
Message-ID: <200702131423.58561.andyparkins@gmail.com>
URL: https://gitlist.dev/e/200702131423.58561.andyparkins%40gmail.com

```
In a repository with a large number of refs, the following command line
could easily overflow the command line size limitations

 git-rev-list $newref $(git-rev-parse --not --all)

Fortunately, git-rev-list already has the means to cope with this
situation with the --stdin switch

 git-rev-parse --not --all | git-rev-list --stdin $newref

Which is exactly what this patch does.

Signed-off-by: Andy Parkins <andyparkins@gmail.com>
---
 templates/hooks--update |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/templates/hooks--update b/templates/hooks--update
index d4253cb..e8c536f 100644
--- a/templates/hooks--update
+++ b/templates/hooks--update
@@ -148,7 +148,7 @@ case "$refname_type" in
 			# This shows all log entries that are not already covered by
 			# another ref - i.e. commits that are now accessible from this
 			# ref that were previously not accessible
-			git-rev-list --pretty $newref $(git-rev-parse --not --all)
+			git-rev-parse --not --all | git-rev-list --stdin --pretty $newref
 			echo $LOGEND
 		else
 			# oldrev is valid
-- 
1.5.0.rc4.364.g85b1

```

## Junio C Hamano, 2007-02-13 18:03

Subject: Re: [PATCH 1/3] Fix potential command line overflow in hooks--update
Message-ID: <7v3b5ax7cx.fsf@assigned-by-dhcp.cox.net>
URL: https://gitlist.dev/e/7v3b5ax7cx.fsf%40assigned-by-dhcp.cox.net
In-Reply-To: <200702131423.58561.andyparkins@gmail.com>

```
Andy Parkins <andyparkins@gmail.com> writes:

> In a repository with a large number of refs, the following command line
> could easily overflow the command line size limitations
> ...

Thanks, applied.

```