threads / discuss / 6760

git-send-email: default values do not work

Subject: git-send-email: default values do not work

## tl;dr

One message between Feb 10, 2007 and Feb 10, 2007.

replies: 0people: 1as markdown or json

Blaisorblade· Feb 10, 2007, 17:15 UTC · lore

I'm using git v1.4.4.4, and trying to use directly git-send-email on plain files.

bug #1 (default values when prompting do not work)

According to git-send-email documentation, it should suggest default values when prompting the user.

However it does not, since ->readline does not accept a default value.

I've verified this in man Term\:\:ReadLine and by looking at /usr/share/perl/5.8.7/Term/ReadLine.pm, and with the perl debugger - the default is correctly calculated but not printed. At least with my perl (5.8.7, from up-to-date Ubuntu 6.06 LTS).

git-send-email should instead say "press Enter for default [$default]" and behave correspondingly.

bug #2 (subject line is cut away but ignored)
Additionally, I was sending a patch starting with (on 1st line):
Kconfig: FAULT_INJECTION can be selected only if LOCKDEP is enabled.

'Kconfig:' is interpreted as a mbox parameter, and ignored, and that line is removed from the email.

This should be documented and pitfall, and probably the user should be allowed to override that.

Thanks.
-- 
Inform me of my mistakes, so I can add them to my list!
Paolo Giarrusso, aka Blaisorblade
http://www.user-mode-linux.org/~blaisorblade
Chiacchiera con i tuoi amici in tempo reale! 
 http://it.yahoo.com/mail_it/foot/*http://it.messenger.yahoo.com 

← back to recent threads