Junio C HamanoWhen we remove the last reflog in a directory, opendir() would succeed and we would iterate over its dirents, expecting retval to be initialized to zero and setting it to non-zero only upon seeing an error. If the directory is empty, oops!, we do not have anybody that touches retval.
The problem is because we initialize retval to errno even on success from opendir(), which would leave the errno unmolested.
Signed-off-by: Junio C Hamano <junkio@cox.net> ---
* This bug made "git fsck --full" in fully gc'ed repository to report dangling commits because it did not fully walk the reflogs.
refs.c | 4 +++- 1 files changed, 3 insertions(+), 1 deletions(-)
Show changes to refs.c +3 −1
diff --git a/refs.c b/refs.c index 03e8dfe..7e07fc4 100644 --- a/refs.c +++ b/refs.c @@ -1206,7 +1206,7 @@ int for_each_reflog_ent(const char *ref, each_reflog_ent_fn fn, void *cb_data) static int do_for_each_reflog(const char *base, each_ref_fn fn, void *cb_data) { DIR *dir = opendir(git_path("logs/%s", base)); - int retval = errno; + int retval = 0; if (dir) { struct dirent *de; @@ -1246,6 +1246,8 @@ static int do_for_each_reflog(const char *base, each_ref_fn fn, void *cb_data) free(log); closedir(dir); } + else + return errno; return retval; }
-- 1.5.0.rc3.185.g302d