# [PATCH] doc: fix AsciiDoc syntax

8 messages from 2026-11-20 to 2026-11-21. Participants: Ophir Bleicher via GitGitGadget, Ben Knoble, Junio C Hamano, Ophir Bleicher.
Thread: https://gitlist.dev/t/66900

## Ophir Bleicher via GitGitGadget, 2026-11-20 17:12

Subject: [PATCH] doc: fix AsciiDoc syntax
Message-ID: <pull.2496.git.git.1795194752259.gitgitgadget@gmail.com>
URL: https://gitlist.dev/e/pull.2496.git.git.1795194752259.gitgitgadget%40gmail.com

```
From: Ophir Bleicher <ophirble@gmail.com>

The Documentation/MyFirstContribution.adoc file accidentally used
Markdown syntax for a link:

[here](https://gitgitgadget.github.io/#...)

Fixed it to use AsciiDoc:

https://gitgitgadget.github.io/#...[here]

Signed-off-by: Ophir Bleicher <ophirble@gmail.com>
---
    doc: fix AsciiDoc syntax

Published-As: https://github.com/gitgitgadget/git/releases/tag/pr-git-2496%2FOphirBleicher%2Fpatch-3-v1
Fetch-It-Via: git fetch https://github.com/gitgitgadget/git pr-git-2496/OphirBleicher/patch-3-v1
Pull-Request: https://github.com/git/git/pull/2496

 Documentation/MyFirstContribution.adoc | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/Documentation/MyFirstContribution.adoc b/Documentation/MyFirstContribution.adoc
index c58253fd54..3b531b24fa 100644
--- a/Documentation/MyFirstContribution.adoc
+++ b/Documentation/MyFirstContribution.adoc
@@ -931,7 +931,7 @@ either with the "New pull request" button or the convenient "Compare & pull
 request" button that may appear with the name of your newly pushed branch.
 
 The differences between using `gitgitgadget/git` and `git/git` as your base can
-be found [here](https://gitgitgadget.github.io/#should-i-use-gitgitgadget-on-gitgitgadgets-git-fork-or-on-gits-github-mirror)
+be found https://gitgitgadget.github.io/#should-i-use-gitgitgadget-on-gitgitgadgets-git-fork-or-on-gits-github-mirror[here]
 
 Review the PR's title and description, as they're used by GitGitGadget
 respectively as the subject and body of the cover letter for your change. Refer

base-commit: f7de81456940dd6f3274e461149bba12965de609
-- 
gitgitgadget


```

## Ben Knoble, 2026-11-20 17:54

Subject: Re: [PATCH] doc: fix AsciiDoc syntax
Message-ID: <93127462-BCFD-4086-B19D-4B640F515140@gmail.com>
URL: https://gitlist.dev/e/93127462-BCFD-4086-B19D-4B640F515140%40gmail.com
In-Reply-To: <pull.2496.git.git.1795194752259.gitgitgadget@gmail.com>

```

> Le 20 nov. 2026 à 12:31, Ophir Bleicher via GitGitGadget <gitgitgadget@gmail.com> a écrit :
> 
> ﻿From: Ophir Bleicher <ophirble@gmail.com>
> 
> The Documentation/MyFirstContribution.adoc file accidentally used
> Markdown syntax for a link:
> 
> [here](https://gitgitgadget.github.io/#...)
> 
> Fixed it to use AsciiDoc:
> 
> https://gitgitgadget.github.io/#...[here]

Good catch.

While we’re at it, « here » is generally discouraged as link text.
It’s not particularly accessible for screen-readers, for example.

> Signed-off-by: Ophir Bleicher <ophirble@gmail.com>
> ---
>    doc: fix AsciiDoc syntax
> 
> Published-As: https://github.com/gitgitgadget/git/releases/tag/pr-git-2496%2FOphirBleicher%2Fpatch-3-v1
> Fetch-It-Via: git fetch https://github.com/gitgitgadget/git pr-git-2496/OphirBleicher/patch-3-v1
> Pull-Request: https://github.com/git/git/pull/2496
> 
> Documentation/MyFirstContribution.adoc | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/Documentation/MyFirstContribution.adoc b/Documentation/MyFirstContribution.adoc
> index c58253fd54..3b531b24fa 100644
> --- a/Documentation/MyFirstContribution.adoc
> +++ b/Documentation/MyFirstContribution.adoc
> @@ -931,7 +931,7 @@ either with the "New pull request" button or the convenient "Compare & pull
> request" button that may appear with the name of your newly pushed branch.
> 
> The differences between using `gitgitgadget/git` and `git/git` as your base can
> -be found [here](https://gitgitgadget.github.io/#should-i-use-gitgitgadget-on-gitgitgadgets-git-fork-or-on-gits-github-mirror)
> +be found https://gitgitgadget.github.io/#should-i-use-gitgitgadget-on-gitgitgadgets-git-fork-or-on-gits-github-mirror[here]

So perhaps we could reword this to something like

    Further [differences between …] are described online.

with the brackets marking the link text?

> Review the PR's title and description, as they're used by GitGitGadget
> respectively as the subject and body of the cover letter for your change. Refer
> 
> base-commit: f7de81456940dd6f3274e461149bba12965de609
> --
> gitgitgadget
> 


```

## Junio C Hamano, 2026-11-20 18:08

Subject: Re: [PATCH] doc: fix AsciiDoc syntax
Message-ID: <xmqqh5hbqst1.fsf@gitster.g>
URL: https://gitlist.dev/e/xmqqh5hbqst1.fsf%40gitster.g
In-Reply-To: <93127462-BCFD-4086-B19D-4B640F515140@gmail.com>

```
Ben Knoble <ben.knoble@gmail.com> writes:

>> Fixed it to use AsciiDoc:
>> 
>> https://gitgitgadget.github.io/#...[here]
>
> Good catch.
>
> While we’re at it, « here » is generally discouraged as link text.
> It’s not particularly accessible for screen-readers, for example.

I also thought that it was a funny but understandable mistake we
made, given how prevalent Markdown is these days, but didn't think
of the need to improve the link text.

Great suggestion.

>> The differences between using `gitgitgadget/git` and `git/git` as your base can
>> -be found [here](https://gitgitgadget.github.io/#should-i-use-gitgitgadget-on-gitgitgadgets-git-fork-or-on-gits-github-mirror)
>> +be found https://gitgitgadget.github.io/#should-i-use-gitgitgadget-on-gitgitgadgets-git-fork-or-on-gits-github-mirror[here]
>
> So perhaps we could reword this to something like
>
>     Further [differences between …] are described online.
>
> with the brackets marking the link text?

Sounds good.

Thanks.


```

## Ophir Bleicher via GitGitGadget, 2026-11-20 18:35

Subject: [PATCH v2] doc: fix AsciiDoc syntax
Message-ID: <pull.2496.v2.git.git.1795199746309.gitgitgadget@gmail.com>
URL: https://gitlist.dev/e/pull.2496.v2.git.git.1795199746309.gitgitgadget%40gmail.com
In-Reply-To: <pull.2496.git.git.1795194752259.gitgitgadget@gmail.com>

```
From: Ophir Bleicher <ophirble@gmail.com>

The Documentation/MyFirstContribution.adoc file accidentally used
Markdown syntax for a link:

[here](https://gitgitgadget.github.io/#...)

Fixed it to use AsciiDoc:

https://gitgitgadget.github.io/#...[here]

Signed-off-by: Ophir Bleicher <ophirble@gmail.com>
---
    doc: fix AsciiDoc syntax
    
    Difference from v1:
    
     * Change link text

Published-As: https://github.com/gitgitgadget/git/releases/tag/pr-git-2496%2FOphirBleicher%2Fpatch-3-v2
Fetch-It-Via: git fetch https://github.com/gitgitgadget/git pr-git-2496/OphirBleicher/patch-3-v2
Pull-Request: https://github.com/git/git/pull/2496

Range-diff vs v1:

 1:  748ac69283 ! 1:  cf26060e59 doc: fix AsciiDoc syntax
     @@ Documentation/MyFirstContribution.adoc: either with the "New pull request" butto
       
       The differences between using `gitgitgadget/git` and `git/git` as your base can
      -be found [here](https://gitgitgadget.github.io/#should-i-use-gitgitgadget-on-gitgitgadgets-git-fork-or-on-gits-github-mirror)
     -+be found https://gitgitgadget.github.io/#should-i-use-gitgitgadget-on-gitgitgadgets-git-fork-or-on-gits-github-mirror[here]
     ++be found https://gitgitgadget.github.io/#should-i-use-gitgitgadget-on-gitgitgadgets-git-fork-or-on-gits-github-mirror[on GitGitGadget's official documentation.]
       
       Review the PR's title and description, as they're used by GitGitGadget
       respectively as the subject and body of the cover letter for your change. Refer


 Documentation/MyFirstContribution.adoc | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/Documentation/MyFirstContribution.adoc b/Documentation/MyFirstContribution.adoc
index c58253fd54..73dab5f7c9 100644
--- a/Documentation/MyFirstContribution.adoc
+++ b/Documentation/MyFirstContribution.adoc
@@ -931,7 +931,7 @@ either with the "New pull request" button or the convenient "Compare & pull
 request" button that may appear with the name of your newly pushed branch.
 
 The differences between using `gitgitgadget/git` and `git/git` as your base can
-be found [here](https://gitgitgadget.github.io/#should-i-use-gitgitgadget-on-gitgitgadgets-git-fork-or-on-gits-github-mirror)
+be found https://gitgitgadget.github.io/#should-i-use-gitgitgadget-on-gitgitgadgets-git-fork-or-on-gits-github-mirror[on GitGitGadget's official documentation.]
 
 Review the PR's title and description, as they're used by GitGitGadget
 respectively as the subject and body of the cover letter for your change. Refer

base-commit: f7de81456940dd6f3274e461149bba12965de609
-- 
gitgitgadget


```

## Junio C Hamano, 2026-11-20 19:03

Subject: Re: [PATCH v2] doc: fix AsciiDoc syntax
Message-ID: <xmqqtslbpbpa.fsf@gitster.g>
URL: https://gitlist.dev/e/xmqqtslbpbpa.fsf%40gitster.g
In-Reply-To: <pull.2496.v2.git.git.1795199746309.gitgitgadget@gmail.com>

```
"Ophir Bleicher via GitGitGadget" <gitgitgadget@gmail.com> writes:

> From: Ophir Bleicher <ophirble@gmail.com>
>
> The Documentation/MyFirstContribution.adoc file accidentally used
> Markdown syntax for a link:
>
> [here](https://gitgitgadget.github.io/#...)
>
> Fixed it to use AsciiDoc:
>
> https://gitgitgadget.github.io/#...[here]
>
> Signed-off-by: Ophir Bleicher <ophirble@gmail.com>
> ---

The exact same tense and mood suggestion applies to this commit
message, too.  "uses" and "Fix".  I can locally tweak them while
queuing, so no need to resend if you are OK with it.

>     doc: fix AsciiDoc syntax
>     
>     Difference from v1:
>     
>      * Change link text
>
> Published-As: https://github.com/gitgitgadget/git/releases/tag/pr-git-2496%2FOphirBleicher%2Fpatch-3-v2
> Fetch-It-Via: git fetch https://github.com/gitgitgadget/git pr-git-2496/OphirBleicher/patch-3-v2
> Pull-Request: https://github.com/git/git/pull/2496
>
> Range-diff vs v1:
>
>  1:  748ac69283 ! 1:  cf26060e59 doc: fix AsciiDoc syntax
>      @@ Documentation/MyFirstContribution.adoc: either with the "New pull request" butto
>        
>        The differences between using `gitgitgadget/git` and `git/git` as your base can
>       -be found [here](https://gitgitgadget.github.io/#should-i-use-gitgitgadget-on-gitgitgadgets-git-fork-or-on-gits-github-mirror)
>      -+be found https://gitgitgadget.github.io/#should-i-use-gitgitgadget-on-gitgitgadgets-git-fork-or-on-gits-github-mirror[here]
>      ++be found https://gitgitgadget.github.io/#should-i-use-gitgitgadget-on-gitgitgadgets-git-fork-or-on-gits-github-mirror[on GitGitGadget's official documentation.]
>        
>        Review the PR's title and description, as they're used by GitGitGadget
>        respectively as the subject and body of the cover letter for your change. Refer
>
>
>  Documentation/MyFirstContribution.adoc | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/Documentation/MyFirstContribution.adoc b/Documentation/MyFirstContribution.adoc
> index c58253fd54..73dab5f7c9 100644
> --- a/Documentation/MyFirstContribution.adoc
> +++ b/Documentation/MyFirstContribution.adoc
> @@ -931,7 +931,7 @@ either with the "New pull request" button or the convenient "Compare & pull
>  request" button that may appear with the name of your newly pushed branch.
>  
>  The differences between using `gitgitgadget/git` and `git/git` as your base can
> -be found [here](https://gitgitgadget.github.io/#should-i-use-gitgitgadget-on-gitgitgadgets-git-fork-or-on-gits-github-mirror)
> +be found https://gitgitgadget.github.io/#should-i-use-gitgitgadget-on-gitgitgadgets-git-fork-or-on-gits-github-mirror[on GitGitGadget's official documentation.]
>  
>  Review the PR's title and description, as they're used by GitGitGadget
>  respectively as the subject and body of the cover letter for your change. Refer
>
> base-commit: f7de81456940dd6f3274e461149bba12965de609


```

## Ophir Bleicher, 2026-11-20 19:25

Subject: Re: [PATCH v2] doc: fix AsciiDoc syntax
Message-ID: <072A2362-2FCF-4DC0-8460-86B63498226E@gmail.com>
URL: https://gitlist.dev/e/072A2362-2FCF-4DC0-8460-86B63498226E%40gmail.com
In-Reply-To: <xmqqtslbpbpa.fsf@gitster.g>

```
OK, thank you!

> On 20 Nov 2026, at 21:03, Junio C Hamano <gitster@pobox.com> wrote:
> 
> "Ophir Bleicher via GitGitGadget" <gitgitgadget@gmail.com> writes:
> 
>> From: Ophir Bleicher <ophirble@gmail.com>
>> 
>> The Documentation/MyFirstContribution.adoc file accidentally used
>> Markdown syntax for a link:
>> 
>> [here](https://gitgitgadget.github.io/#...)
>> 
>> Fixed it to use AsciiDoc:
>> 
>> https://gitgitgadget.github.io/#...[here]
>> 
>> Signed-off-by: Ophir Bleicher <ophirble@gmail.com>
>> ---
> 
> The exact same tense and mood suggestion applies to this commit
> message, too.  "uses" and "Fix".  I can locally tweak them while
> queuing, so no need to resend if you are OK with it.
> 
>>    doc: fix AsciiDoc syntax
>> 
>>    Difference from v1:
>> 
>>     * Change link text
>> 
>> Published-As: https://github.com/gitgitgadget/git/releases/tag/pr-git-2496%2FOphirBleicher%2Fpatch-3-v2
>> Fetch-It-Via: git fetch https://github.com/gitgitgadget/git pr-git-2496/OphirBleicher/patch-3-v2
>> Pull-Request: https://github.com/git/git/pull/2496
>> 
>> Range-diff vs v1:
>> 
>> 1:  748ac69283 ! 1:  cf26060e59 doc: fix AsciiDoc syntax
>>     @@ Documentation/MyFirstContribution.adoc: either with the "New pull request" butto
>> 
>>       The differences between using `gitgitgadget/git` and `git/git` as your base can
>>      -be found [here](https://gitgitgadget.github.io/#should-i-use-gitgitgadget-on-gitgitgadgets-git-fork-or-on-gits-github-mirror)
>>     -+be found https://gitgitgadget.github.io/#should-i-use-gitgitgadget-on-gitgitgadgets-git-fork-or-on-gits-github-mirror[here]
>>     ++be found https://gitgitgadget.github.io/#should-i-use-gitgitgadget-on-gitgitgadgets-git-fork-or-on-gits-github-mirror[on GitGitGadget's official documentation.]
>> 
>>       Review the PR's title and description, as they're used by GitGitGadget
>>       respectively as the subject and body of the cover letter for your change. Refer
>> 
>> 
>> Documentation/MyFirstContribution.adoc | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
>> 
>> diff --git a/Documentation/MyFirstContribution.adoc b/Documentation/MyFirstContribution.adoc
>> index c58253fd54..73dab5f7c9 100644
>> --- a/Documentation/MyFirstContribution.adoc
>> +++ b/Documentation/MyFirstContribution.adoc
>> @@ -931,7 +931,7 @@ either with the "New pull request" button or the convenient "Compare & pull
>> request" button that may appear with the name of your newly pushed branch.
>> 
>> The differences between using `gitgitgadget/git` and `git/git` as your base can
>> -be found [here](https://gitgitgadget.github.io/#should-i-use-gitgitgadget-on-gitgitgadgets-git-fork-or-on-gits-github-mirror)
>> +be found https://gitgitgadget.github.io/#should-i-use-gitgitgadget-on-gitgitgadgets-git-fork-or-on-gits-github-mirror[on GitGitGadget's official documentation.]
>> 
>> Review the PR's title and description, as they're used by GitGitGadget
>> respectively as the subject and body of the cover letter for your change. Refer
>> 
>> base-commit: f7de81456940dd6f3274e461149bba12965de609




```

## Ben Knoble, 2026-11-21 00:18

Subject: Re: [PATCH v2] doc: fix AsciiDoc syntax
Message-ID: <85D05F5D-111B-4A60-A923-B45FD514CADC@gmail.com>
URL: https://gitlist.dev/e/85D05F5D-111B-4A60-A923-B45FD514CADC%40gmail.com
In-Reply-To: <pull.2496.v2.git.git.1795199746309.gitgitgadget@gmail.com>

```

> Le 20 nov. 2026 à 13:37, Ophir Bleicher via GitGitGadget <gitgitgadget@gmail.com> a écrit :
> 
> ﻿From: Ophir Bleicher <ophirble@gmail.com>
> 
> The Documentation/MyFirstContribution.adoc file accidentally used
> Markdown syntax for a link:
> 
> [here](https://gitgitgadget.github.io/#...)
> 
> Fixed it to use AsciiDoc:
> 
> https://gitgitgadget.github.io/#...[here]
> 
> Signed-off-by: Ophir Bleicher <ophirble@gmail.com>
> ---
>    doc: fix AsciiDoc syntax
> 
>    Difference from v1:
> 
>     * Change link text
> 
> Published-As: https://github.com/gitgitgadget/git/releases/tag/pr-git-2496%2FOphirBleicher%2Fpatch-3-v2
> Fetch-It-Via: git fetch https://github.com/gitgitgadget/git pr-git-2496/OphirBleicher/patch-3-v2
> Pull-Request: https://github.com/git/git/pull/2496
> 
> Range-diff vs v1:
> 
> 1:  748ac69283 ! 1:  cf26060e59 doc: fix AsciiDoc syntax
>     @@ Documentation/MyFirstContribution.adoc: either with the "New pull request" butto
> 
>       The differences between using `gitgitgadget/git` and `git/git` as your base can
>      -be found [here](https://gitgitgadget.github.io/#should-i-use-gitgitgadget-on-gitgitgadgets-git-fork-or-on-gits-github-mirror)
>     -+be found https://gitgitgadget.github.io/#should-i-use-gitgitgadget-on-gitgitgadgets-git-fork-or-on-gits-github-mirror[here]
>     ++be found https://gitgitgadget.github.io/#should-i-use-gitgitgadget-on-gitgitgadgets-git-fork-or-on-gits-github-mirror[on GitGitGadget's official documentation.]

I’m happy with this link text, thanks.

>       Review the PR's title and description, as they're used by GitGitGadget
>       respectively as the subject and body of the cover letter for your change. Refer
> 
> 
> Documentation/MyFirstContribution.adoc | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/Documentation/MyFirstContribution.adoc b/Documentation/MyFirstContribution.adoc
> index c58253fd54..73dab5f7c9 100644
> --- a/Documentation/MyFirstContribution.adoc
> +++ b/Documentation/MyFirstContribution.adoc
> @@ -931,7 +931,7 @@ either with the "New pull request" button or the convenient "Compare & pull
> request" button that may appear with the name of your newly pushed branch.
> 
> The differences between using `gitgitgadget/git` and `git/git` as your base can
> -be found [here](https://gitgitgadget.github.io/#should-i-use-gitgitgadget-on-gitgitgadgets-git-fork-or-on-gits-github-mirror)
> +be found https://gitgitgadget.github.io/#should-i-use-gitgitgadget-on-gitgitgadgets-git-fork-or-on-gits-github-mirror[on GitGitGadget's official documentation.]
> 
> Review the PR's title and description, as they're used by GitGitGadget
> respectively as the subject and body of the cover letter for your change. Refer
> 
> base-commit: f7de81456940dd6f3274e461149bba12965de609
> --
> gitgitgadget
> 


```

## Junio C Hamano, 2026-11-21 00:41

Subject: Re: [PATCH v2] doc: fix AsciiDoc syntax
Message-ID: <xmqqh5hbm2x4.fsf@gitster.g>
URL: https://gitlist.dev/e/xmqqh5hbm2x4.fsf%40gitster.g
In-Reply-To: <85D05F5D-111B-4A60-A923-B45FD514CADC@gmail.com>

```
Ben Knoble <ben.knoble@gmail.com> writes:

>>       The differences between using `gitgitgadget/git` and `git/git` as your base can
>>      -be found [here](https://gitgitgadget.github.io/#should-i-use-gitgitgadget-on-gitgitgadgets-git-fork-or-on-gits-github-mirror)
>>     -+be found https://gitgitgadget.github.io/#should-i-use-gitgitgadget-on-gitgitgadgets-git-fork-or-on-gits-github-mirror[here]
>>     ++be found https://gitgitgadget.github.io/#should-i-use-gitgitgadget-on-gitgitgadgets-git-fork-or-on-gits-github-mirror[on GitGitGadget's official documentation.]
>
> I’m happy with this link text, thanks.

Thanks for writing and reviewing.  Let me mark it as ready for
'next', then.


```
