threads / patch / 66871

patchMyFirstContribution: leave a blank line between mailing-list paragraphs

Subject: [PATCH] MyFirstContribution: leave a blank line between mailing-list paragraphs

## tl;dr

3 messages between Nov 18, 2026 and Nov 18, 2026. Diffs are folded; open one to read it.

replies: 2people: 2as markdown or json

Okhuomon Ajayi· Nov 18, 2026, 10:52 UTC · lore

A short reply is hard to spot when it is packed against a long run of quoted lines. Leave a blank line between paragraphs. A block of quoted text counts as a paragraph.

Signed-off-by: Okhuomon Ajayi <okhuomonajayi54@gmail.com>
---
 Documentation/MyFirstContribution.adoc | 3 +++
 1 file changed, 3 insertions(+)
Show changes to Documentation/MyFirstContribution.adoc +3 −0
diff --git a/Documentation/MyFirstContribution.adoc b/Documentation/MyFirstContribution.adoc
index c58253fd54..9c189b6c9e 100644
--- a/Documentation/MyFirstContribution.adoc
+++ b/Documentation/MyFirstContribution.adoc
@@ -1357,6 +1357,9 @@ relevant to your response. It is usually helpful to trim away unrelated context,
 such as large portions of the patch that are not being discussed, while keeping
 enough quoted text for readers to understand what you are responding to.
 
+Leave a blank line between paragraphs. A block of quoted text counts
+as a paragraph, so leave a blank line before and after it.
+
 Make sure your email client has a plaintext email mode and it is turned on; the
 Git list rejects HTML email. Please also follow the mailing list etiquette
 outlined in the

base-commit: 7fb6055e678f800320d8ab8cd8f201d9493d1ba0
-- 
2.56.0
Junio C Hamano· Nov 18, 2026, 18:35 UTC · re: Okhuomon Ajayi · lore

Re: [PATCH] MyFirstContribution: leave a blank line between mailing-list paragraphs

Okhuomon Ajayi <okhuomonajayi54@gmail.com> writes:
Show 14 quoted lines
> diff --git a/Documentation/MyFirstContribution.adoc b/Documentation/MyFirstContribution.adoc
> index c58253fd54..9c189b6c9e 100644
> --- a/Documentation/MyFirstContribution.adoc
> +++ b/Documentation/MyFirstContribution.adoc
> @@ -1357,6 +1357,9 @@ relevant to your response. It is usually helpful to trim away unrelated context,
>  such as large portions of the patch that are not being discussed, while keeping
>  enough quoted text for readers to understand what you are responding to.
>  
> +Leave a blank line between paragraphs. A block of quoted text counts
> +as a paragraph, so leave a blank line before and after it.
> +
>  Make sure your email client has a plaintext email mode and it is turned on; the
>  Git list rejects HTML email. Please also follow the mailing list etiquette
>  outlined in the

Sounds like a good way to help readability. I didn't expect this patch to extend MyFirstContribution, as the first chance for anybody has to deal with "quoted text" is when writing a response to other's patch during a review, not when responding to a review, but it seems that CodingGuidelines, Submittingpatches, and ReviewingGuidelines do not even talk about line length limit for e-mailed communications (which is a bit surprising).

Will queue.  Thanks.
Okhuomon Ajayi· Nov 18, 2026, 23:54 UTC · re: Junio C Hamano · lore

Re: [PATCH] MyFirstContribution: leave a blank line between mailing-list paragraphs

On Wed, Nov 18, 2026 at 7:35 PM Junio C Hamano <gitster@pobox.com> wrote:
Show 9 quoted lines
> Sounds like a good way to help readability.  I didn't expect this
> patch to extend MyFirstContribution, as the first chance for anybody
> has to deal with "quoted text" is when writing a response to other's
> patch during a review, not when responding to a review, but it seems
> that CodingGuidelines, Submittingpatches, and ReviewingGuidelines do
> not even talk about line length limit for e-mailed communications
> (which is a bit surprising).
>
> Will queue.  Thanks.
Thanks Junio.

I am working on a separate patch for the line-length limit. It states the limit in CodingGuidelines, SubmittingPatches, and ReviewingGuidelines.

Okhuomon

← back to recent threads