# [Outreachy PATCH] api-parse-options.adoc: restore a dropped word 2 messages from 2026-11-04 to 2026-11-04. Participants: Cynthia Uche, Junio C Hamano. Thread: https://gitlist.dev/t/66776 ## Cynthia Uche, 2026-11-04 22:45 Subject: [Outreachy PATCH] api-parse-options.adoc: restore a dropped word Message-ID: <20261104224559.4197-1-herroyalpriestess@gmail.com> URL: https://gitlist.dev/e/20261104224559.4197-1-herroyalpriestess%40gmail.com ``` The description of PARSE_OPT_KEEP_UNKNOWN_OPT ends with "..., the parser early.", which is not a sentence. The word "stopping" was lost in 0d260f9a09 (parseopt: prevent KEEP_UNKNOWN and STOP_AT_NON_OPTION from being used together, 2009-03-09), which rewrote the end of that sentence. Restore it, and rewrap the following line. Signed-off-by: Cynthia Uche --- Documentation/technical/api-parse-options.adoc | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/Documentation/technical/api-parse-options.adoc b/Documentation/technical/api-parse-options.adoc index 6dfea34220..14f0d2b572 100644 --- a/Documentation/technical/api-parse-options.adoc +++ b/Documentation/technical/api-parse-options.adoc @@ -127,8 +127,8 @@ Flags are the bitwise-or of: `PARSE_OPT_STOP_AT_NON_OPTION` is set, the second argument in `--unknown value` will be mistakenly interpreted as a non-option, not as a value belonging to the unknown option, - the parser early. That's why parse_options() errors out if - both options are set. + stopping the parser early. That's why parse_options() errors + out if both options are set. Note that non-option arguments are always kept, even without this flag. -- 2.56.GIT ``` ## Junio C Hamano, 2026-11-04 23:13 Subject: Re: [Outreachy PATCH] api-parse-options.adoc: restore a dropped word Message-ID: URL: https://gitlist.dev/e/xmqq1p90yyul.fsf%40gitster.g In-Reply-To: <20261104224559.4197-1-herroyalpriestess@gmail.com> ``` Cynthia Uche writes: > The description of PARSE_OPT_KEEP_UNKNOWN_OPT ends with "..., the > parser early.", which is not a sentence. The word "stopping" was lost > in 0d260f9a09 (parseopt: prevent KEEP_UNKNOWN and STOP_AT_NON_OPTION > from being used together, 2009-03-09), which rewrote the end of that > sentence. Makes sense. Thanks for finding and fixing. > > Restore it, and rewrap the following line. > > Signed-off-by: Cynthia Uche > --- > Documentation/technical/api-parse-options.adoc | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/Documentation/technical/api-parse-options.adoc b/Documentation/technical/api-parse-options.adoc > index 6dfea34220..14f0d2b572 100644 > --- a/Documentation/technical/api-parse-options.adoc > +++ b/Documentation/technical/api-parse-options.adoc > @@ -127,8 +127,8 @@ Flags are the bitwise-or of: > `PARSE_OPT_STOP_AT_NON_OPTION` is set, the second argument in > `--unknown value` will be mistakenly interpreted as a > non-option, not as a value belonging to the unknown option, > - the parser early. That's why parse_options() errors out if > - both options are set. > + stopping the parser early. That's why parse_options() errors > + out if both options are set. > Note that non-option arguments are always kept, even without > this flag. ```