# [Outreachy] Microproject idea: modernize a file-existence check in t/t0081-find-pack.sh 5 messages from 2026-10-29 to 2026-11-02. Participants: Immaculate Mecha, Okhuomon Ajayi, Junio C Hamano. Thread: https://gitlist.dev/t/66701 ## Immaculate Mecha, 2026-10-29 08:10 Subject: [Outreachy] Microproject idea: modernize a file-existence check in t/t0081-find-pack.sh Message-ID: URL: https://gitlist.dev/e/CAKUOgLz3sefhypa9yzLszW43uQ%3DJor_nRBAJaBXXv0d8M2ePBw%40mail.gmail.com ``` Hi, I'm preparing a microproject contribution for Outreachy and have been exploring a small test cleanup in Git. In t/t0081-find-pack.sh, line 35 currently uses: test -f "$head_commit_pack" && I'm considering replacing it with Git's test helper: test_path_is_file "$head_commit_pack" && I checked the file's history using git blame and confirmed that this is the only test -f, test -e, or test -d check in that script. Would this be an appropriate and useful microproject, or is there a reason to leave this check as it is? I have cloned Git, built it with NO_RUST=1, and run the test suite. I have not made any changes to the source yet. Thank you for your time. ``` ## Okhuomon Ajayi, 2026-10-29 09:03 Subject: Re: [Outreachy] Microproject idea: modernize a file-existence check in t/t0081-find-pack.sh Message-ID: URL: https://gitlist.dev/e/CAFpMFfA17dnuLSRt97BrM0u3cHAifJybr_Zc2ahr_zq2nspgsw%40mail.gmail.com In-Reply-To: ``` On Thu, Oct 29, 2026 at 9:10 AM Immaculate Mecha wrote: > > Hi, > > I'm preparing a microproject contribution for Outreachy and have been > exploring a small test cleanup in Git. > > In t/t0081-find-pack.sh, line 35 currently uses: > > test -f "$head_commit_pack" && > > I'm considering replacing it with Git's test helper: > > test_path_is_file "$head_commit_pack" && > > I checked the file's history using git blame and confirmed that this > is the only test -f, test -e, or test -d check in that script. > > Would this be an appropriate and useful microproject, or is there a > reason to leave this check as it is? Hi Immaculate, Welcome! I think Shashank S already changed this exact line in t0081 https://lore.kernel.org/git/pull.2254.v2.git.1792061236183.gitgitgadget@gmail.com/ Before choosing a microproject, it helps to search the list archive at https://lore.kernel.org/git/ for the file name, and to check the "What's cooking" reports, to make sure nobody is already working on it. Good luck! Okhuomon ``` ## Immaculate Mecha, 2026-10-29 09:54 Subject: Re: [Outreachy] Microproject idea: modernize a file-existence check in t/t0081-find-pack.sh Message-ID: URL: https://gitlist.dev/e/CAKUOgLy_jS-x5jZcQZmjHzLV%3DTnPi56iQ9v00hUXmX9Kudorjg%40mail.gmail.com In-Reply-To: ``` Hi, Thank you for the welcome and for pointing me to the existing work. I'll review the mailing-list archive and the What's cooking reports more carefully before choosing another microproject. Best, Immaculate On Thu, Oct 29, 2026 at 12:03 PM Okhuomon Ajayi wrote: > > On Thu, Oct 29, 2026 at 9:10 AM Immaculate Mecha > wrote: > > > > Hi, > > > > I'm preparing a microproject contribution for Outreachy and have been > > exploring a small test cleanup in Git. > > > > In t/t0081-find-pack.sh, line 35 currently uses: > > > > test -f "$head_commit_pack" && > > > > I'm considering replacing it with Git's test helper: > > > > test_path_is_file "$head_commit_pack" && > > > > I checked the file's history using git blame and confirmed that this > > is the only test -f, test -e, or test -d check in that script. > > > > Would this be an appropriate and useful microproject, or is there a > > reason to leave this check as it is? > > > Hi Immaculate, > > Welcome! I think Shashank S already changed this exact line in t0081 > > https://lore.kernel.org/git/pull.2254.v2.git.1792061236183.gitgitgadget@gmail.com/ > > Before choosing a microproject, it helps to search the list archive > at https://lore.kernel.org/git/ for the file name, and to check the > "What's cooking" reports, to make sure nobody is already working on > it. > > Good luck! > Okhuomon ``` ## Junio C Hamano, 2026-10-29 18:31 Subject: Re: [Outreachy] Microproject idea: modernize a file-existence check in t/t0081-find-pack.sh Message-ID: URL: https://gitlist.dev/e/xmqq7bj02wak.fsf%40gitster.g In-Reply-To: ``` Okhuomon Ajayi writes: > Before choosing a microproject, it helps to search the list archive > at https://lore.kernel.org/git/ for the file name, and to check the > "What's cooking" reports, to make sure nobody is already working on > it. Great advice. Reading others' patches and reviews they have received will prepare a newcomer to avoid making the same mistakes as they already have made. Reading Documentation/SubmittingPatches would also help, but that goes without saying ;-) ``` ## Immaculate Mecha, 2026-11-02 05:51 Subject: Re: [Outreachy] Microproject idea: modernize a file-existence check in t/t0081-find-pack.sh Message-ID: URL: https://gitlist.dev/e/CAKUOgLy8iSh8RtSNoTp6KtLhe0SkU04DcTstERdbnN7xSDb9bQ%40mail.gmail.com In-Reply-To: ``` Hello, i sent this project request "[Outreachy] GIT_DIR inherited by shell aliases in linked worktrees" , and i haven't gotten feedback yet on whether i should proceed or not. I will appreciate your feedback. On Thu, Oct 29, 2026 at 9:31 PM Junio C Hamano wrote: > > Okhuomon Ajayi writes: > > > Before choosing a microproject, it helps to search the list archive > > at https://lore.kernel.org/git/ for the file name, and to check the > > "What's cooking" reports, to make sure nobody is already working on > > it. > > Great advice. Reading others' patches and reviews they have > received will prepare a newcomer to avoid making the same mistakes > as they already have made. Reading Documentation/SubmittingPatches > would also help, but that goes without saying ;-) ```