# [Outreachy PATCH] notes-cache: read the cache ref from the given repository

2 messages from 2026-10-26 to 2026-10-26. Participants: Okhuomon Ajayi, Junio C Hamano.
Thread: https://gitlist.dev/t/66662

## Okhuomon Ajayi, 2026-10-26 10:26

Subject: [Outreachy PATCH] notes-cache: read the cache ref from the given repository
Message-ID: <20261026102603.32377-1-okhuomonajayi54@gmail.com>
URL: https://gitlist.dev/e/20261026102603.32377-1-okhuomonajayi54%40gmail.com

```
notes_cache_match_validity() already receives the repository as
r and uses it for the commit lookup. The ref read still used
the_repository.

Pass r to get_main_ref_store() so the validity check reads the
ref from the same repository.

Signed-off-by: Okhuomon Ajayi <okhuomonajayi54@gmail.com>
---
 notes-cache.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/notes-cache.c b/notes-cache.c
index 74cef802bd..ccc071ebd0 100644
--- a/notes-cache.c
+++ b/notes-cache.c
@@ -20,7 +20,7 @@ static int notes_cache_match_validity(struct repository *r,
 	struct strbuf msg = STRBUF_INIT;
 	int ret;
 
-	if (refs_read_ref(get_main_ref_store(the_repository), ref, &oid) < 0)
+	if (refs_read_ref(get_main_ref_store(r), ref, &oid) < 0)
 		return 0;
 
 	commit = lookup_commit_reference_gently(r, &oid, 1);

base-commit: 7e34d8174dcda3435d1404c9a30bef46afe6c13e
-- 
2.56.0



```

## Junio C Hamano, 2026-10-26 16:57

Subject: Re: [Outreachy PATCH] notes-cache: read the cache ref from the given repository
Message-ID: <xmqqo6cgs8lk.fsf@gitster.g>
URL: https://gitlist.dev/e/xmqqo6cgs8lk.fsf%40gitster.g
In-Reply-To: <20261026102603.32377-1-okhuomonajayi54@gmail.com>

```
Okhuomon Ajayi <okhuomonajayi54@gmail.com> writes:

> notes_cache_match_validity() already receives the repository as
> r and uses it for the commit lookup. The ref read still used
> the_repository.
>
> Pass r to get_main_ref_store() so the validity check reads the
> ref from the same repository.
>
> Signed-off-by: Okhuomon Ajayi <okhuomonajayi54@gmail.com>
> ---
>  notes-cache.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/notes-cache.c b/notes-cache.c
> index 74cef802bd..ccc071ebd0 100644
> --- a/notes-cache.c
> +++ b/notes-cache.c
> @@ -20,7 +20,7 @@ static int notes_cache_match_validity(struct repository *r,
>  	struct strbuf msg = STRBUF_INIT;
>  	int ret;
>  
> -	if (refs_read_ref(get_main_ref_store(the_repository), ref, &oid) < 0)
> +	if (refs_read_ref(get_main_ref_store(r), ref, &oid) < 0)
>  		return 0;
>  
>  	commit = lookup_commit_reference_gently(r, &oid, 1);

This is straightforward.  The function does not seem to call
any function that implicitly relies on 'the_repository' either,
making this a trivial improvement.

Thanks.


```
