# [Outreachy PATCH] t2104: avoid suppressing git's exit code 4 messages from 2026-10-21 to 2026-10-23. Participants: Cynthia Uche, Patrick Steinhardt, Priestess, Junio C Hamano. Thread: https://gitlist.dev/t/66613 ## Cynthia Uche, 2026-10-21 03:37 Subject: [Outreachy PATCH] t2104: avoid suppressing git's exit code Message-ID: <20261021033723.5265-1-herroyalpriestess@gmail.com> URL: https://gitlist.dev/e/20261021033723.5265-1-herroyalpriestess%40gmail.com ``` The exit code of the upstream command in a pipeline is lost, so a crash in 'git ls-files' would go unnoticed. Write the output to a file and compare that instead. Signed-off-by: Cynthia Uche --- t/t2104-update-index-skip-worktree.sh | 12 ++++++++---- 1 file changed, 8 insertions(+), 4 deletions(-) diff --git a/t/t2104-update-index-skip-worktree.sh b/t/t2104-update-index-skip-worktree.sh index 7a0778ed98..68a4339e24 100755 --- a/t/t2104-update-index-skip-worktree.sh +++ b/t/t2104-update-index-skip-worktree.sh @@ -34,7 +34,8 @@ test_expect_success 'setup' ' mkdir sub && touch ./1 ./2 sub/1 sub/2 && git add 1 2 sub/1 sub/2 && - git ls-files -t | test_cmp expect.full - + git ls-files -t >actual && + test_cmp expect.full actual ' test_expect_success 'index is at version 2' ' @@ -43,7 +44,8 @@ test_expect_success 'index is at version 2' ' test_expect_success 'update-index --skip-worktree' ' git update-index --skip-worktree 1 sub/1 && - git ls-files -t | test_cmp expect.skip - + git ls-files -t >actual && + test_cmp expect.skip actual ' test_expect_success 'index is at version 3 after having some skip-worktree entries' ' @@ -51,12 +53,14 @@ test_expect_success 'index is at version 3 after having some skip-worktree entri ' test_expect_success 'ls-files -t' ' - git ls-files -t | test_cmp expect.skip - + git ls-files -t >actual && + test_cmp expect.skip actual ' test_expect_success 'update-index --no-skip-worktree' ' git update-index --no-skip-worktree 1 sub/1 && - git ls-files -t | test_cmp expect.full - + git ls-files -t >actual && + test_cmp expect.full actual ' test_expect_success 'index version is back to 2 when there is no skip-worktree entry' ' -- 2.56.GIT ``` ## Patrick Steinhardt, 2026-10-21 08:00 Subject: Re: [Outreachy PATCH] t2104: avoid suppressing git's exit code Message-ID: URL: https://gitlist.dev/e/athxA6S50czDEUYj%40pks.im In-Reply-To: <20261021033723.5265-1-herroyalpriestess@gmail.com> ``` On Wed, Oct 21, 2026 at 04:37:23AM +0100, Cynthia Uche wrote: > The exit code of the upstream command in a pipeline is lost, so a > crash in 'git ls-files' would go unnoticed. Write the output to a > file and compare that instead. Makes sense, and the patch looks obviously good to me, too. Thanks! Patrick ``` ## Priestess, 2026-10-22 01:22 Subject: Re: [Outreachy PATCH] t2104: avoid suppressing git's exit code Message-ID: URL: https://gitlist.dev/e/CAOcE0wLUZP%2BHG_X%2BC72U4vT4eYp%3DF9XK79aBdAiArYODxcYeAA%40mail.gmail.com In-Reply-To: ``` > Makes sense, and the patch looks obviously good to me, too. Thanks! Thanks for the review, Patrick. ``` ## Junio C Hamano, 2026-10-23 17:56 Subject: Re: [Outreachy PATCH] t2104: avoid suppressing git's exit code Message-ID: URL: https://gitlist.dev/e/xmqq8q3o7134.fsf%40gitster.g In-Reply-To: ``` Priestess writes: >> Makes sense, and the patch looks obviously good to me, too. Thanks! > > Thanks for the review, Patrick. Thanks, both. Queued. ```