# [PATCH v2] archive-zip: refactor 'path too long' error message to use Q_() 2 messages from 2026-10-19 to 2026-10-20. Participants: kerylefondji7@gmail.com, Phillip Wood. Thread: https://gitlist.dev/t/66588 ## kerylefondji7@gmail.com, 2026-10-19 15:27 Subject: [PATCH v2] archive-zip: refactor 'path too long' error message to use Q_() Message-ID: <20261019152725.714-1-kerylefondji7@gmail.com> URL: https://gitlist.dev/e/20261019152725.714-1-kerylefondji7%40gmail.com In-Reply-To: <1a15474a4114ba8b> ``` From: Keryle Fondji Replace _() with Q_() in the 'path too long' error message. Although pathlen is always greater than 0xffff when this error is hit, Q_() is required to support correct translation for languages that require different plural forms depending on the count. Signed-off-by: Keryle Fondji --- archive-zip.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/archive-zip.c b/archive-zip.c index 6f73ca6d58..e4f8ef5a36 100644 --- a/archive-zip.c +++ b/archive-zip.c @@ -328,7 +328,7 @@ static int write_zip_entry(struct archiver_args *args, } if (pathlen > 0xffff) { - return error(_("path too long (%d chars, SHA1: %s): %s"), + return error(Q_("path too long (%d char, SHA1: %s): %s", "path too long (%d chars, SHA1: %s): %s", pathlen), (int)pathlen, oid_to_hex(oid), path); } -- 2.53.0 ``` ## Phillip Wood, 2026-10-20 09:42 Subject: Re: [PATCH v2] archive-zip: refactor 'path too long' error message to use Q_() Message-ID: URL: https://gitlist.dev/e/e06ea3e7-7555-42b9-8ea5-65e9d3b25281%40gmail.com In-Reply-To: <20261019152725.714-1-kerylefondji7@gmail.com> ``` Hi Keryle On 19/10/2026 16:27, kerylefondji7@gmail.com wrote: > From: Keryle Fondji > > Replace _() with Q_() in the 'path too long' error message. Although > pathlen is always greater than 0xffff when this error is hit, Q_() is > required to support correct translation for languages that require > different plural forms depending on the count. This is good. As Junio has pointed out the code needs wrapping now that it is using Q_(). Thanks Phillip > Signed-off-by: Keryle Fondji > --- > archive-zip.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/archive-zip.c b/archive-zip.c > index 6f73ca6d58..e4f8ef5a36 100644 > --- a/archive-zip.c > +++ b/archive-zip.c > @@ -328,7 +328,7 @@ static int write_zip_entry(struct archiver_args *args, > } > > if (pathlen > 0xffff) { > - return error(_("path too long (%d chars, SHA1: %s): %s"), > + return error(Q_("path too long (%d char, SHA1: %s): %s", "path too long (%d chars, SHA1: %s): %s", pathlen), > (int)pathlen, oid_to_hex(oid), path); > } > ```