# [Outreachy][PATCH v2] builtin/var: refactor to use parse-options API 4 messages from 2026-10-17 to 2026-10-17. Participants: Keryle, kerylefondji7@gmail.com, Kristoffer Haugsbakk. Thread: https://gitlist.dev/t/66563 ## Keryle, 2026-10-17 00:54 Subject: [Outreachy][PATCH v2] builtin/var: refactor to use parse-options API Message-ID: <20261017005403.5397-1-kerylefondji7@gmail.com> URL: https://gitlist.dev/e/20261017005403.5397-1-kerylefondji7%40gmail.com In-Reply-To: <1a146af667a8bcd4> ``` From: keryle Migrate option handling in 'git var' to the parse-options API. This update also aligns variable resolution with current Git configuration and attribute handling. Signed-off-by: Keryle --- Range-diff against v1: - Fixed whitespace damage and replaced space-indentation with proper tabs. - Removed redundant inline comments as suggested. - Enforced mutual exclusivity between '-l' and positional arguments. - Aligned variable resolution with Git configuration and attribute handling. builtin/var.c | 32 +++++++++++++++++++++++--------- 1 file changed, 23 insertions(+), 9 deletions(-) diff --git a/builtin/var.c b/builtin/var.c index cc3a43cde2..b9234a55eb 100644 --- a/builtin/var.c +++ b/builtin/var.c @@ -3,11 +3,9 @@ * * Copyright (C) Eric Biederman, 2005 */ - #define USE_THE_REPOSITORY_VARIABLE #include "builtin.h" - #include "attr.h" #include "config.h" #include "editor.h" @@ -18,8 +16,12 @@ #include "path.h" #include "strbuf.h" #include "run-command.h" +#include "parse-options.h" -static const char var_usage[] = "git var (-l | )"; +static const char * const var_usage[] = { + N_("git var (-l | )"), + NULL +}; static char *committer(int ident_flag) { @@ -120,6 +122,7 @@ struct git_var { char *(*read)(int); int multivalued; }; + static struct git_var git_vars[] = { { .name = "GIT_COMMITTER_IDENT", @@ -221,21 +224,32 @@ int cmd_var(int argc, { const struct git_var *git_var; char *val; + int list = 0; - show_usage_if_asked(argc, argv, var_usage); - if (argc != 2) - usage(var_usage); + struct option builtin_var_options[] = { + OPT_BOOL('l', "list", &list, N_("list builtin variables")), + OPT_END() + }; - if (strcmp(argv[1], "-l") == 0) { + argc = parse_options(argc, argv, prefix, builtin_var_options, + var_usage, 0); + + if (list) { + if (argc > 0) + usage(var_usage[0]); repo_config(the_repository, show_config, NULL); list_vars(); return 0; } + + if (argc != 1) + usage(var_usage[0]); + repo_config(the_repository, git_default_config, NULL); - git_var = get_git_var(argv[1]); + git_var = get_git_var(argv[0]); if (!git_var) - usage(var_usage); + usage(var_usage[0]); val = git_var->read(IDENT_STRICT); if (!val) -- 2.53.0 ``` ## kerylefondji7@gmail.com, 2026-10-17 11:25 Subject: [Outreachy][PATCH v2] builtin/var: refactor to use parse-options API Message-ID: <20261017112518.4548-1-kerylefondji7@gmail.com> URL: https://gitlist.dev/e/20261017112518.4548-1-kerylefondji7%40gmail.com In-Reply-To: <1a146af667a8bcd4> ``` From: kerylefondji Migrate option handling in 'git var' to the parse-options API. This update also aligns variable resolution with current Git configuration and attribute handling. Signed-off-by: Keryle Blondeau Fondji Tamekong --- builtin/var.c | 32 +++++++++++++++++++++++--------- 1 file changed, 23 insertions(+), 9 deletions(-) diff --git a/builtin/var.c b/builtin/var.c index cc3a43cde2..b9234a55eb 100644 --- a/builtin/var.c +++ b/builtin/var.c @@ -3,11 +3,9 @@ * * Copyright (C) Eric Biederman, 2005 */ - #define USE_THE_REPOSITORY_VARIABLE #include "builtin.h" - #include "attr.h" #include "config.h" #include "editor.h" @@ -18,8 +16,12 @@ #include "path.h" #include "strbuf.h" #include "run-command.h" +#include "parse-options.h" -static const char var_usage[] = "git var (-l | )"; +static const char * const var_usage[] = { + N_("git var (-l | )"), + NULL +}; static char *committer(int ident_flag) { @@ -120,6 +122,7 @@ struct git_var { char *(*read)(int); int multivalued; }; + static struct git_var git_vars[] = { { .name = "GIT_COMMITTER_IDENT", @@ -221,21 +224,32 @@ int cmd_var(int argc, { const struct git_var *git_var; char *val; + int list = 0; - show_usage_if_asked(argc, argv, var_usage); - if (argc != 2) - usage(var_usage); + struct option builtin_var_options[] = { + OPT_BOOL('l', "list", &list, N_("list builtin variables")), + OPT_END() + }; - if (strcmp(argv[1], "-l") == 0) { + argc = parse_options(argc, argv, prefix, builtin_var_options, + var_usage, 0); + + if (list) { + if (argc > 0) + usage(var_usage[0]); repo_config(the_repository, show_config, NULL); list_vars(); return 0; } + + if (argc != 1) + usage(var_usage[0]); + repo_config(the_repository, git_default_config, NULL); - git_var = get_git_var(argv[1]); + git_var = get_git_var(argv[0]); if (!git_var) - usage(var_usage); + usage(var_usage[0]); val = git_var->read(IDENT_STRICT); if (!val) -- 2.53.0 ``` ## Kristoffer Haugsbakk, 2026-10-17 11:45 Subject: Re: [Outreachy][PATCH v2] builtin/var: refactor to use parse-options API Message-ID: URL: https://gitlist.dev/e/d109cff5-2257-42e4-a399-a99a2ab7ff43%40app.fastmail.com In-Reply-To: <20261017112518.4548-1-kerylefondji7@gmail.com> ``` On Sat, Oct 17, 2026, at 13:25, kerylefondji7@gmail.com wrote: > From: kerylefondji The author part should generally be your real name FYI. See SubmittingsPatches about name or “real name”. > > Migrate option handling in 'git var' to the parse-options API. > This update also aligns variable resolution with current Git configuration > and attribute handling. > > Signed-off-by: Keryle Blondeau Fondji Tamekong This looks like a real name. But the email is not real. It should be the gmail one from the author part. > --- > [snip] ``` ## kerylefondji7@gmail.com, 2026-10-17 12:20 Subject: Re: [Outreachy][PATCH v2] builtin/var: refactor to use parse-options API Message-ID: <20261017122044.568-1-kerylefondji7@gmail.com> URL: https://gitlist.dev/e/20261017122044.568-1-kerylefondji7%40gmail.com In-Reply-To: <1a146af667a8bcd4> ``` Hi Kristoffer, Thank you very much for your feedback and pointing this out. I will fix this immediately with my correct email address for the next version. Best regards, Keryle ```