threads / patch / 6654

patchgit-config --rename-section could rename wrong section

Subject: [PATCH] git-config --rename-section could rename wrong section

## tl;dr

One message between Feb 4, 2007 and Feb 4, 2007. Diffs are folded; open one to read it.

replies: 0people: 1as markdown or json

Pavel Roskin· Feb 4, 2007, 03:01 UTC · lore

The "git-config --rename-section" implementation would match sections that are substrings of the section name to be renamed.

Signed-off-by: Pavel Roskin <proski@gnu.org>
---
 config.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)
Show changes to config.c +1 −1
diff --git a/config.c b/config.c
index c08c668..d821071 100644
--- a/config.c
+++ b/config.c
@@ -896,7 +896,7 @@ int git_config_rename_section(const char *old_name, const char *new_name)
 				if (buf[i] != old_name[j++])
 					break;
 			}
-			if (buf[i] == ']') {
+			if (buf[i] == ']' && old_name[j] == 0) {
 				/* old_name matches */
 				ret++;
 				store.baselen = strlen(new_name);

← back to recent threads