# [PATCH] t0450: use test_path_is_file and test_path_is_missing 2 messages from 2026-10-06 to 2026-10-06. Participants: Muhammed Dilshad A, Patrick Steinhardt. Thread: https://gitlist.dev/t/66471 ## Muhammed Dilshad A, 2026-10-06 10:14 Subject: [PATCH] t0450: use test_path_is_file and test_path_is_missing Message-ID: <20261006101458.604775-1-dilsheddilu123@gmail.com> URL: https://gitlist.dev/e/20261006101458.604775-1-dilsheddilu123%40gmail.com ``` Replace raw 'test -f' and '! test -f' assertions with the test helper functions 'test_path_is_file' and 'test_path_is_missing' to provide diagnostic output when an assertion fails. Signed-off-by: Muhammed Dilshad A --- t/t0450-txt-doc-vs-help.sh | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/t/t0450-txt-doc-vs-help.sh b/t/t0450-txt-doc-vs-help.sh index 55c0fb3cb7..a2da2b0192 100755 --- a/t/t0450-txt-doc-vs-help.sh +++ b/t/t0450-txt-doc-vs-help.sh @@ -116,13 +116,13 @@ do if grep -q "^$builtin$" "$TEST_DIRECTORY"/t0450/adoc-missing then test_expect_success "$builtin appropriately marked as not having .adoc" ' - ! test -f "$adoc" + test_path_is_missing "$adoc" ' else test_set_prereq "$preq" test_expect_success "$builtin appropriately marked as having .adoc" ' - test -f "$adoc" + test_path_is_file "$adoc" ' fi -- 2.55.0 ``` ## Patrick Steinhardt, 2026-10-06 12:23 Subject: Re: [PATCH] t0450: use test_path_is_file and test_path_is_missing Message-ID: URL: https://gitlist.dev/e/asToW_aXYGCg0xuv%40pks.im In-Reply-To: <20261006101458.604775-1-dilsheddilu123@gmail.com> ``` On Tue, Oct 06, 2026 at 03:44:58PM +0530, Muhammed Dilshad A wrote: > Replace raw 'test -f' and '! test -f' assertions with the test helper > functions 'test_path_is_file' and 'test_path_is_missing' to provide > diagnostic output when an assertion fails. > > Signed-off-by: Muhammed Dilshad A Good commit message, pinpointing exactly why we even bother to do this change. > diff --git a/t/t0450-txt-doc-vs-help.sh b/t/t0450-txt-doc-vs-help.sh > index 55c0fb3cb7..a2da2b0192 100755 > --- a/t/t0450-txt-doc-vs-help.sh > +++ b/t/t0450-txt-doc-vs-help.sh > @@ -116,13 +116,13 @@ do > if grep -q "^$builtin$" "$TEST_DIRECTORY"/t0450/adoc-missing > then > test_expect_success "$builtin appropriately marked as not having .adoc" ' > - ! test -f "$adoc" > + test_path_is_missing "$adoc" > ' > else > test_set_prereq "$preq" > > test_expect_success "$builtin appropriately marked as having .adoc" ' > - test -f "$adoc" > + test_path_is_file "$adoc" > ' > fi And the change looks obviously good to me, as well. Thanks! Patrick ```