# [PATCH] Be tolerant to repos without .git/remotes/ or .git/branches/. 2 messages from 2007-02-02 to 2007-02-02. Participants: Yann Dirson, Catalin Marinas. Thread: https://gitlist.dev/t/6631 ## Yann Dirson, 2007-02-02 23:00 Subject: [PATCH] Be tolerant to repos without .git/remotes/ or .git/branches/. Message-ID: <20070202225900.30628.17382.stgit@gandelf.nowhere.earth> URL: https://gitlist.dev/e/20070202225900.30628.17382.stgit%40gandelf.nowhere.earth ``` __remotes_from_dir() was not robust against non-existent dirs. This a Git 1.5 compat issue, since repos do not have .git/remotes any more. Signed-off-by: Yann Dirson --- This problem prevented me from seeing the t1200 regression you reported, but once this one is fixed I do hit a problem there. stgit/git.py | 6 +++++- 1 files changed, 5 insertions(+), 1 deletions(-) diff --git a/stgit/git.py b/stgit/git.py index 022d607..069833d 100644 --- a/stgit/git.py +++ b/stgit/git.py @@ -904,7 +904,11 @@ def __remotes_from_config(): return config.sections_matching(r'remote\.(.*)\.url') def __remotes_from_dir(dir): - return os.listdir(os.path.join(basedir.get(), dir)) + absdir=os.path.join(basedir.get(), dir) + if os.path.isdir(absdir): + return os.listdir(absdir) + else: + return [] def remotes_list(): """Return the list of remotes in the repository ``` ## Catalin Marinas, 2007-02-02 23:03 Subject: Re: [PATCH] Be tolerant to repos without .git/remotes/ or .git/branches/. Message-ID: URL: https://gitlist.dev/e/b0943d9e0702021503v6ae3851agdf6158eb4a386af8%40mail.gmail.com In-Reply-To: <20070202225900.30628.17382.stgit@gandelf.nowhere.earth> ``` On 02/02/07, Yann Dirson wrote: > __remotes_from_dir() was not robust against non-existent dirs. > This a Git 1.5 compat issue, since repos do not have .git/remotes any > more. I already included the same patch from Pavel Roskin. -- Catalin ```