threads / discuss / 6550

reflog for HEAD (detached or between branches)

Subject: reflog for HEAD (detached or between branches)

## tl;dr

4 messages between Jan 26, 2007 and Jan 27, 2007.

replies: 3people: 2as markdown or json

Nicolas Pitre· Jan 26, 2007, 22:25 UTC · lore

This is the implementation for the idea I proposed for the support of reflog with detached head. In fact with this serie HEAD has a reflog of its own which may or may not contain the same log entries found in reflogs of individual branches.

Nicolas

Junio C Hamano· Jan 26, 2007, 23:45 UTC · re: Nicolas Pitre · lore

Re: reflog for HEAD (detached or between branches)

I suspect that "git-reflog --expire", "git-fsck-objects" and "git-prune" need to be updated to take the reflog associated with the HEAD into account, as for_each_ref() does not call you with HEAD.

Other than that, I think the series is beautifully done.

Thanks.

Junio C Hamano· Jan 27, 2007, 01:46 UTC · re: Junio C Hamano · lore

[PATCH 1/3] create_symref: check error return from open().

Signed-off-by: Junio C Hamano <junkio@cox.net>
---

 * There seem to be similarly "casual" users of open in the rest
   of the code, but I noticed this while looking at your series.
   I've already done the necessary shuffling in my tree, so
   there is no need to resend your "move create_symref()".

 refs.c |    6 +++++-
 1 files changed, 5 insertions(+), 1 deletions(-)

diff --git a/refs.c b/refs.c
index 0840b3b..12e46b8 100644
--- a/refs.c
+++ b/refs.c
@@ -331,7 +331,11 @@ int create_symref(const char *ref_target, const char *refs_heads_master)
 		return -1;
 	}
 	lockpath = mkpath("%s.lock", git_HEAD);
-	fd = open(lockpath, O_CREAT | O_EXCL | O_WRONLY, 0666);	
+	fd = open(lockpath, O_CREAT | O_EXCL | O_WRONLY, 0666);
+	if (fd < 0) {
+		error("Unable to open %s for writing", lockpath);
+		return -5;
+	}
 	written = write_in_full(fd, ref, len);
 	close(fd);
 	if (written != len) {

-- 
1.5.0.rc2.g8ac6-dirty

Junio C Hamano· Jan 27, 2007, 01:49 UTC · re: Junio C Hamano · lore

[PATCH 3/3] write_in_full: size_t is unsigned.

It received the return value from xwrite() in a size_t variable 'written' and expected comparison with 0 would catch an error from xwrite().

Signed-off-by: Junio C Hamano <junkio@cox.net>
---
 * and this is the third bug t7207-co.sh caught.  I haven't
   bothered to look at the assembly, but I suspect the error
   return path could have been totally optimized out X-<.

 write_or_die.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/write_or_die.c b/write_or_die.c
index 046e79d..5c4bc85 100644
--- a/write_or_die.c
+++ b/write_or_die.c
@@ -23,7 +23,7 @@ int write_in_full(int fd, const void *buf, size_t count)
 	ssize_t total = 0;
 
 	while (count > 0) {
-		size_t written = xwrite(fd, p, count);
+		ssize_t written = xwrite(fd, p, count);
 		if (written < 0)
 			return -1;
 		if (!written) {

-- 
1.5.0.rc2.g8ac6-dirty