threads / patch / 65375

patcht6101: avoid suppressing git's exit code

Subject: [GSoC PATCH] t6101: avoid suppressing git's exit code

## tl;dr

One message between Mar 28, 2026 and Mar 28, 2026. Diffs are folded; open one to read it.

replies: 0people: 1as markdown or json

Trieu Huynh· Mar 28, 2026, 13:59 UTC · lore

Update t6101-rev-parse-parents.sh to redirect git-rev-parse output to a temporary file instead of piping it directly to not hide the exit code of git commands behind pipes, as a crash in git might go unnoticed.

Signed-off-by: Trieu Huynh <vikingtc4@gmail.com>
---
 t/t6101-rev-parse-parents.sh | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)
Show changes to t/t6101-rev-parse-parents.sh +2 −1
diff --git a/t/t6101-rev-parse-parents.sh b/t/t6101-rev-parse-parents.sh
index 5f55ab98d3..7281889717 100755
--- a/t/t6101-rev-parse-parents.sh
+++ b/t/t6101-rev-parse-parents.sh
@@ -39,7 +39,8 @@ test_expect_success 'setup' '
 '
 
 test_expect_success 'start is valid' '
-	git rev-parse start | grep "^$OID_REGEX$"
+	git rev-parse start >actual &&
+	test_grep "^$OID_REGEX$" actual
 '
 
 test_expect_success 'start^0' '
-- 
2.43.0

← back to recent threads