# [PATCH 2/2] Remove unnecessary found variable from describe. 1 messages from 2007-01-25 to 2007-01-25. Participants: Shawn O. Pearce. Thread: https://gitlist.dev/t/6528 ## Shawn O. Pearce, 2007-01-25 17:40 Subject: [PATCH 2/2] Remove unnecessary found variable from describe. Message-ID: <20070125174003.GB13276@spearce.org> URL: https://gitlist.dev/e/20070125174003.GB13276%40spearce.org In-Reply-To: <2d9c5cd428a8962a64628a4e429263576bc46762.1169746766.git.spearce@spearce.org> ``` Junio added the found variable to enforce commit date order when two tags have the same distance from the requested commit. Except it is unnecessary as match_cnt is already used to record how many possible tags have been identified thus far. Signed-off-by: Shawn O. Pearce --- builtin-describe.c | 3 +-- 1 files changed, 1 insertions(+), 2 deletions(-) diff --git a/builtin-describe.c b/builtin-describe.c index d8ff621..14c712a 100644 --- a/builtin-describe.c +++ b/builtin-describe.c @@ -101,7 +101,6 @@ static void describe(const char *arg, int last_one) struct possible_tag all_matches[MAX_TAGS]; unsigned int match_cnt = 0, annotated_cnt = 0, cur_match; unsigned long seen_commits = 0; - int found = 0; if (get_sha1(arg, sha1)) die("Not a valid object name %s", arg); @@ -137,7 +136,7 @@ static void describe(const char *arg, int last_one) t->name = n; t->depth = seen_commits - 1; t->flag_within = 1u << match_cnt; - t->found_order = found++; + t->found_order = match_cnt; c->object.flags |= t->flag_within; if (n->prio == 2) annotated_cnt++; -- 1.5.0.rc2.g18af ```