# [PATCH] Fix GNU/Hurd build 6 messages from 2026-03-12 to 2026-03-16. Participants: Samuel Thibault, Junio C Hamano, Patrick Steinhardt. Thread: https://gitlist.dev/t/65223 ## Samuel Thibault, 2026-03-12 19:19 Subject: [PATCH] Fix GNU/Hurd build Message-ID: <20260312191901.174808-1-samuel.thibault@ens-lyon.org> URL: https://gitlist.dev/e/20260312191901.174808-1-samuel.thibault%40ens-lyon.org ``` GNU/Hurd does not have a PATH_MAX limitation Signed-off-by: Samuel Thibault --- t/unit-tests/clar/clar.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/t/unit-tests/clar/clar.h b/t/unit-tests/clar/clar.h index f7e4363022..55b0361d91 100644 --- a/t/unit-tests/clar/clar.h +++ b/t/unit-tests/clar/clar.h @@ -11,7 +11,7 @@ #include #include -#if defined(_WIN32) && defined(CLAR_WIN32_LONGPATHS) +#if defined(__GNU__) || defined(_WIN32) && defined(CLAR_WIN32_LONGPATHS) # define CLAR_MAX_PATH 4096 #elif defined(_WIN32) # define CLAR_MAX_PATH MAX_PATH -- 2.51.0 ``` ## Junio C Hamano, 2026-03-12 20:38 Subject: Re: [PATCH] Fix GNU/Hurd build Message-ID: URL: https://gitlist.dev/e/xmqqbjgsdbr6.fsf%40gitster.g In-Reply-To: <20260312191901.174808-1-samuel.thibault@ens-lyon.org> ``` Samuel Thibault writes: > GNU/Hurd does not have a PATH_MAX limitation Thanks. clar folks might prefer to take it upstream and have us as a downstream to import from them, so I'll forward it first before taking it for ourselves. It makes me wonder if an organization like this is easier to follow, i.e., platform specific settings first and then catch-all default at the end: #if defined(CLAR_LONGPATHS) #define CLAR_MAX_PATH 4096 #elif defined(PATH_MAX) #define CLAR_MAX_PATH PATH_MAX #elif deifned(MAX_PATH) #define CLAR_MAX_PATH MAX_PATH #fi #if !defined(CLAR_MAX_PATH) #define CLAR_MAX_PATH 4096 #fi but that is a separate issue best handled by the clar folks. --- >8 --- From: Samuel Thibault Date: Thu, 12 Mar 2026 20:19:01 +0100 Subject: [PATCH] clar: compilation fix for GNU/Hurd fails to define CLAR_MAX_PATH on GNU/Hurd where PATH_MAX is not defined. Signed-off-by: Samuel Thibault Signed-off-by: Junio C Hamano --- t/unit-tests/clar/clar.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/t/unit-tests/clar/clar.h b/t/unit-tests/clar/clar.h index ca72292ae9..4394aabbb9 100644 --- a/t/unit-tests/clar/clar.h +++ b/t/unit-tests/clar/clar.h @@ -10,7 +10,7 @@ #include #include -#if defined(_WIN32) && defined(CLAR_WIN32_LONGPATHS) +#if defined(__GNU__) || defined(_WIN32) && defined(CLAR_WIN32_LONGPATHS) # define CLAR_MAX_PATH 4096 #elif defined(_WIN32) # define CLAR_MAX_PATH MAX_PATH -- 2.53.0-707-gf7b889d8f7 ``` ## Patrick Steinhardt, 2026-03-13 06:39 Subject: Re: [PATCH] Fix GNU/Hurd build Message-ID: URL: https://gitlist.dev/e/abOxLFNGgZjo1dyi%40pks.im In-Reply-To: ``` On Thu, Mar 12, 2026 at 01:38:21PM -0700, Junio C Hamano wrote: > Samuel Thibault writes: > > > GNU/Hurd does not have a PATH_MAX limitation > > Thanks. clar folks might prefer to take it upstream and have us as > a downstream to import from them, so I'll forward it first before > taking it for ourselves. > > It makes me wonder if an organization like this is easier to follow, > i.e., platform specific settings first and then catch-all default at > the end: > > #if defined(CLAR_LONGPATHS) > #define CLAR_MAX_PATH 4096 > #elif defined(PATH_MAX) > #define CLAR_MAX_PATH PATH_MAX > #elif deifned(MAX_PATH) > #define CLAR_MAX_PATH MAX_PATH > #fi > > #if !defined(CLAR_MAX_PATH) > #define CLAR_MAX_PATH 4096 > #fi > > but that is a separate issue best handled by the clar folks. Agreed, something like this would read better indeed. Samuel, do you want to maybe create a pull request in [1] to fix this in clar itself? You can then give me (@pks-gitlab) a ping and I'll be happy to review it. I can then handle the subsequent pull request for Git. Thanks! Patrick [1]: https://github.com/clar-test/clar ``` ## Samuel Thibault, 2026-03-13 17:24 Subject: Re: [PATCH] Fix GNU/Hurd build Message-ID: URL: https://gitlist.dev/e/abRIXE2es5A-4VLv%40end In-Reply-To: ``` Patrick Steinhardt, le ven. 13 mars 2026 07:39:40 +0100, a ecrit: > On Thu, Mar 12, 2026 at 01:38:21PM -0700, Junio C Hamano wrote: > > Samuel Thibault writes: > > > > > GNU/Hurd does not have a PATH_MAX limitation > > > > Thanks. clar folks might prefer to take it upstream and have us as > > a downstream to import from them, so I'll forward it first before > > taking it for ourselves. > > > > It makes me wonder if an organization like this is easier to follow, > > i.e., platform specific settings first and then catch-all default at > > the end: > > > > #if defined(CLAR_LONGPATHS) > > #define CLAR_MAX_PATH 4096 > > #elif defined(PATH_MAX) > > #define CLAR_MAX_PATH PATH_MAX > > #elif deifned(MAX_PATH) > > #define CLAR_MAX_PATH MAX_PATH > > #fi > > > > #if !defined(CLAR_MAX_PATH) > > #define CLAR_MAX_PATH 4096 > > #fi > > > > but that is a separate issue best handled by the clar folks. > > Agreed, something like this would read better indeed. Ah, actually Pino already contributed a fix in december:) > Samuel, do you > want to maybe create a pull request in [1] to fix this in clar itself? > [1]: https://github.com/clar-test/clar It would be useful to put this github url in the README, I have submitted https://github.com/clar-test/clar/pull/135 so it'll eventually end up in the git source for people to find out where to send clar patches. Samuel ``` ## Junio C Hamano, 2026-03-13 19:08 Subject: Re: [PATCH] Fix GNU/Hurd build Message-ID: URL: https://gitlist.dev/e/xmqqsea34kdy.fsf%40gitster.g In-Reply-To: ``` Samuel Thibault writes: >> Agreed, something like this would read better indeed. > > Ah, actually Pino already contributed a fix in december:) Good to know. > It would be useful to put this github url in the README, I have > submitted > https://github.com/clar-test/clar/pull/135 > so it'll eventually end up in the git source for people to find out > where to send clar patches. Wonderful. Thanks. ``` ## Patrick Steinhardt, 2026-03-16 06:41 Subject: Re: [PATCH] Fix GNU/Hurd build Message-ID: URL: https://gitlist.dev/e/abemE08uzRwB-xwp%40pks.im In-Reply-To: ``` On Fri, Mar 13, 2026 at 06:24:44PM +0100, Samuel Thibault wrote: > Patrick Steinhardt, le ven. 13 mars 2026 07:39:40 +0100, a ecrit: > > On Thu, Mar 12, 2026 at 01:38:21PM -0700, Junio C Hamano wrote: > > > Samuel Thibault writes: > > > > > > > GNU/Hurd does not have a PATH_MAX limitation > > > > > > Thanks. clar folks might prefer to take it upstream and have us as > > > a downstream to import from them, so I'll forward it first before > > > taking it for ourselves. > > > > > > It makes me wonder if an organization like this is easier to follow, > > > i.e., platform specific settings first and then catch-all default at > > > the end: > > > > > > #if defined(CLAR_LONGPATHS) > > > #define CLAR_MAX_PATH 4096 > > > #elif defined(PATH_MAX) > > > #define CLAR_MAX_PATH PATH_MAX > > > #elif deifned(MAX_PATH) > > > #define CLAR_MAX_PATH MAX_PATH > > > #fi > > > > > > #if !defined(CLAR_MAX_PATH) > > > #define CLAR_MAX_PATH 4096 > > > #fi > > > > > > but that is a separate issue best handled by the clar folks. > > > > Agreed, something like this would read better indeed. > > Ah, actually Pino already contributed a fix in december:) Oh, you're right! I'll send an update to the latest clar version later today. > > Samuel, do you > > want to maybe create a pull request in [1] to fix this in clar itself? > > > [1]: https://github.com/clar-test/clar > > It would be useful to put this github url in the README, I have > submitted > https://github.com/clar-test/clar/pull/135 > so it'll eventually end up in the git source for people to find out > where to send clar patches. Makes sense, thanks. Patrick ```