Piping `git count-objects` into `grep` masks the exit code of the git command. If `count-objects` fails but `grep` succeeds, the pipeline reports success, potentially hiding bugs.
Write the output to a temporary file instead to ensure the exit code of the git command is properly evaluated.
Signed-off-by: Santhosh <santhoshprogrammer07@gmail.com> --- t/perf/p5304-prune.sh | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
Show changes to t/perf/p5304-prune.sh +1 −1
diff --git a/t/perf/p5304-prune.sh b/t/perf/p5304-prune.sh index 83baedb8a4..af59424de8 100755 --- a/t/perf/p5304-prune.sh +++ b/t/perf/p5304-prune.sh @@ -14,7 +14,7 @@ test_expect_success 'remove unreachable loose objects' ' ' test_expect_success 'confirm there are no loose objects' ' - git count-objects | grep ^0 + git count-objects >out && grep ^0 out ' test_perf 'prune with no objects' '
-- 2.43.0