# [PATCH] gitk: support config the color of linkfgcolor via Gitk Preferences 10 messages from 2026-02-26 to 2026-03-01. Participants: Gary Wang via GitGitGadget, Junio C Hamano, Johannes Sixt, Wang Zichong. Thread: https://gitlist.dev/t/65079 ## Gary Wang via GitGitGadget, 2026-02-26 12:33 Subject: [PATCH] gitk: support config the color of linkfgcolor via Gitk Preferences Message-ID: URL: https://gitlist.dev/e/pull.2217.git.git.1772109195114.gitgitgadget%40gmail.com ``` From: Wang Zichong As a dark-theme user, I use the Preferences dialog to set colors for gitk, the only color I cannot change via that dialog is the link foreground color, which will lead me to use the default link color on a dark background that make it not really readable. This patch makes the link foreground color also configurable in the Gitk Preferences dialog's Color tab, so user won't need to dig into the code/manual to know if the link color is configurable and can simply set the color there. CC: Mark Levedahl , Paul Mackerras Signed-off-by: Wang Zichong --- gitk: support config the color of linkfgcolor via Gitk Preferences Published-As: https://github.com/gitgitgadget/git/releases/tag/pr-git-2217%2FBLumia%2Fgitk-linkfgcolor-v1 Fetch-It-Via: git fetch https://github.com/gitgitgadget/git pr-git-2217/BLumia/gitk-linkfgcolor-v1 Pull-Request: https://github.com/git/git/pull/2217 gitk-git/gitk | 10 ++++++++-- 1 file changed, 8 insertions(+), 2 deletions(-) diff --git a/gitk-git/gitk b/gitk-git/gitk index cbaaee994e..b60f140636 100755 --- a/gitk-git/gitk +++ b/gitk-git/gitk @@ -11796,7 +11796,7 @@ proc prefspage_general {notebook} { proc prefspage_colors {notebook} { global bgcolor fgcolor ctext diffcolors selectbgcolor markbgcolor - global diffbgcolors + global diffbgcolors linkfgcolor global themeloader set page [create_prefs_page $notebook.colors] @@ -11873,6 +11873,11 @@ proc prefspage_colors {notebook} { -command [list choosecolor selectbgcolor {} $page [mc "background"]] grid x $page.selbgbut $page.selbgsep -sticky w + label $page.linkfg -padx 40 -relief sunk -background $linkfgcolor + ttk::button $page.linkfgbut -text [mc "Link color"] \ + -command [list choosecolor linkfgcolor {} $page [mc "link color"]] + grid x $page.linkfgbut $page.linkfg -sticky w + grid columnconfigure $page 2 -weight 1 return $page @@ -11880,7 +11885,7 @@ proc prefspage_colors {notebook} { proc prefspage_set_colorswatches {page} { global bgcolor fgcolor ctext diffcolors selectbgcolor markbgcolor - global diffbgcolors + global diffbgcolors linkfgcolor $page.bg configure -background $bgcolor $page.fg configure -background $fgcolor @@ -11891,6 +11896,7 @@ proc prefspage_set_colorswatches {page} { $page.hunksep configure -background [lindex $diffcolors 2] $page.markbgsep configure -background $markbgcolor $page.selbgsep configure -background $selectbgcolor + $page.linkfg configure -background $linkfgcolor } proc prefspage_fonts {notebook} { base-commit: 7b2bccb0d58d4f24705bf985de1f4612e4cf06e5 -- gitgitgadget ``` ## Junio C Hamano, 2026-02-26 15:25 Subject: Re: [PATCH] gitk: support config the color of linkfgcolor via Gitk Preferences Message-ID: URL: https://gitlist.dev/e/xmqqecm75xym.fsf%40gitster.g In-Reply-To: ``` "Gary Wang via GitGitGadget" writes: > From: Wang Zichong > > As a dark-theme user, I use the Preferences dialog to set colors > for gitk, the only color I cannot change via that dialog is the > link foreground color, which will lead me to use the default link > color on a dark background that make it not really readable. > > This patch makes the link foreground color also configurable in the > Gitk Preferences dialog's Color tab, so user won't need to dig into > the code/manual to know if the link color is configurable and can > simply set the color there. > > CC: Mark Levedahl , Paul Mackerras > Signed-off-by: Wang Zichong > --- > gitk: support config the color of linkfgcolor via Gitk Preferences > > Published-As: https://github.com/gitgitgadget/git/releases/tag/pr-git-2217%2FBLumia%2Fgitk-linkfgcolor-v1 > Fetch-It-Via: git fetch https://github.com/gitgitgadget/git pr-git-2217/BLumia/gitk-linkfgcolor-v1 > Pull-Request: https://github.com/git/git/pull/2217 > > gitk-git/gitk | 10 ++++++++-- > 1 file changed, 8 insertions(+), 2 deletions(-) > > diff --git a/gitk-git/gitk b/gitk-git/gitk > index cbaaee994e..b60f140636 100755 > --- a/gitk-git/gitk > +++ b/gitk-git/gitk > @@ -11796,7 +11796,7 @@ proc prefspage_general {notebook} { > > proc prefspage_colors {notebook} { > global bgcolor fgcolor ctext diffcolors selectbgcolor markbgcolor > - global diffbgcolors > + global diffbgcolors linkfgcolor > global themeloader > > set page [create_prefs_page $notebook.colors] > @@ -11873,6 +11873,11 @@ proc prefspage_colors {notebook} { > -command [list choosecolor selectbgcolor {} $page [mc "background"]] > grid x $page.selbgbut $page.selbgsep -sticky w > > + label $page.linkfg -padx 40 -relief sunk -background $linkfgcolor > + ttk::button $page.linkfgbut -text [mc "Link color"] \ > + -command [list choosecolor linkfgcolor {} $page [mc "link color"]] > + grid x $page.linkfgbut $page.linkfg -sticky w > + > grid columnconfigure $page 2 -weight 1 > > return $page > @@ -11880,7 +11885,7 @@ proc prefspage_colors {notebook} { > > proc prefspage_set_colorswatches {page} { > global bgcolor fgcolor ctext diffcolors selectbgcolor markbgcolor > - global diffbgcolors > + global diffbgcolors linkfgcolor > > $page.bg configure -background $bgcolor > $page.fg configure -background $fgcolor > @@ -11891,6 +11896,7 @@ proc prefspage_set_colorswatches {page} { > $page.hunksep configure -background [lindex $diffcolors 2] > $page.markbgsep configure -background $markbgcolor > $page.selbgsep configure -background $selectbgcolor > + $page.linkfg configure -background $linkfgcolor > } > > proc prefspage_fonts {notebook} { > > base-commit: 7b2bccb0d58d4f24705bf985de1f4612e4cf06e5 ``` ## Johannes Sixt, 2026-02-27 07:37 Subject: Re: [PATCH] gitk: support config the color of linkfgcolor via Gitk Preferences Message-ID: URL: https://gitlist.dev/e/ffd58cd5-811b-4ebf-8572-cca681ec9bf7%40kdbg.org In-Reply-To: ``` Am 26.02.26 um 13:33 schrieb Gary Wang via GitGitGadget: > From: Wang Zichong > > As a dark-theme user, I use the Preferences dialog to set colors > for gitk, the only color I cannot change via that dialog is the > link foreground color, which will lead me to use the default link > color on a dark background that make it not really readable. > > This patch makes the link foreground color also configurable in the > Gitk Preferences dialog's Color tab, so user won't need to dig into > the code/manual to know if the link color is configurable and can > simply set the color there. Makes sense. Our usual style is to not say "This patch does X to...", but to write in imperative mood "Do X to...". > > CC: Mark Levedahl , Paul Mackerras > Signed-off-by: Wang Zichong > --- > gitk: support config the color of linkfgcolor via Gitk Preferences In the subject line, perhaps: gitk: support link color in the Preferences dialog > + label $page.linkfg -padx 40 -relief sunk -background $linkfgcolor > + ttk::button $page.linkfgbut -text [mc "Link color"] \ > + -command [list choosecolor linkfgcolor {} $page [mc "link color"]] This text "link color" is used in the title of the color selection dialog. It then reads awkwardly "Gitk: choose color for link color". Let's just use the text "links" for this purpose, and then also just "Links" as the label on the button. > @@ -11891,6 +11896,7 @@ proc prefspage_set_colorswatches {page} { > $page.hunksep configure -background [lindex $diffcolors 2] > $page.markbgsep configure -background $markbgcolor > $page.selbgsep configure -background $selectbgcolor > + $page.linkfg configure -background $linkfgcolor The variable's value is already serialized in the configuration and needs no additional treatment. Good. -- Hannes ``` ## Junio C Hamano, 2026-02-27 16:49 Subject: Re: [PATCH] gitk: support config the color of linkfgcolor via Gitk Preferences Message-ID: URL: https://gitlist.dev/e/xmqq8qcet9ln.fsf%40gitster.g In-Reply-To: ``` Johannes Sixt writes: > Am 26.02.26 um 13:33 schrieb Gary Wang via GitGitGadget: >> From: Wang Zichong >> >> As a dark-theme user, I use the Preferences dialog to set colors >> for gitk, the only color I cannot change via that dialog is the >> link foreground color, which will lead me to use the default link >> color on a dark background that make it not really readable. >> >> This patch makes the link foreground color also configurable in the >> Gitk Preferences dialog's Color tab, so user won't need to dig into >> the code/manual to know if the link color is configurable and can >> simply set the color there. > > Makes sense. > > Our usual style is to not say "This patch does X to...", but to write in > imperative mood "Do X to...". A bit of tangent, but I wonder if it would help new comers if we add what I sometimes send (e.g., a recent one found in https://lore.kernel.org/git/xmqq343ehu4o.fsf@gitster.g/ ) somewhere more prominent, like MyFirstContribution? >> CC: Mark Levedahl , Paul Mackerras It is unusual to see multiple people listed on a single Cc: trailer. >> Signed-off-by: Wang Zichong >> --- >> gitk: support config the color of linkfgcolor via Gitk Preferences > > In the subject line, perhaps: > > gitk: support link color in the Preferences dialog > >> + label $page.linkfg -padx 40 -relief sunk -background $linkfgcolor >> + ttk::button $page.linkfgbut -text [mc "Link color"] \ >> + -command [list choosecolor linkfgcolor {} $page [mc "link color"]] > > This text "link color" is used in the title of the color selection > dialog. It then reads awkwardly "Gitk: choose color for link color". > Let's just use the text "links" for this purpose, and then also just > "Links" as the label on the button. > >> @@ -11891,6 +11896,7 @@ proc prefspage_set_colorswatches {page} { >> $page.hunksep configure -background [lindex $diffcolors 2] >> $page.markbgsep configure -background $markbgcolor >> $page.selbgsep configure -background $selectbgcolor >> + $page.linkfg configure -background $linkfgcolor > > The variable's value is already serialized in the configuration and > needs no additional treatment. Good. > > -- Hannes ``` ## Wang Zichong, 2026-02-28 03:37 Subject: Re: [PATCH] gitk: support config the color of linkfgcolor via Gitk Preferences Message-ID: <3FA6BA9ACF1B34AF+20260228033725.2546976-1-wangzichong@deepin.org> URL: https://gitlist.dev/e/3FA6BA9ACF1B34AF%2B20260228033725.2546976-1-wangzichong%40deepin.org In-Reply-To: ``` >> Our usual style is to not say "This patch does X to...", but to write in >> imperative mood "Do X to...". > >A bit of tangent, but I wonder if it would help new comers if we add >what I sometimes send (e.g., a recent one found in > > https://lore.kernel.org/git/xmqq343ehu4o.fsf@gitster.g/ > >) somewhere more prominent, like MyFirstContribution? Agree! >>> CC: Mark Levedahl , Paul Mackerras > >It is unusual to see multiple people listed on a single Cc: trailer. This usage is actually from the example provided at GitGitGadget's landing page: https://gitgitgadget.github.io/ If writing multiple CC trailers is preferred, maybe we also need to update GitGitGadget's documentation as well. -- Gary ``` ## Gary Wang via GitGitGadget, 2026-02-28 04:05 Subject: [PATCH v2] gitk: support link color in the Preferences dialog Message-ID: URL: https://gitlist.dev/e/pull.2217.v2.git.git.1772251558434.gitgitgadget%40gmail.com In-Reply-To: ``` From: Wang Zichong As a dark-theme user, I use the Preferences dialog to set colors for gitk. The only color I cannot change via that dialog is the link foreground color, which leads to using the default link color on a dark background that makes it hard to read. Make the link foreground color also configurable in the Gitk Preferences dialog's Color tab, so users won't need to dig into the code/manual to check if it is configurable and can simply set the color there. CC: Mark Levedahl CC: Paul Mackerras CC: Johannes Sixt Signed-off-by: Wang Zichong --- gitk: support config the color of linkfgcolor via Gitk Preferences Published-As: https://github.com/gitgitgadget/git/releases/tag/pr-git-2217%2FBLumia%2Fgitk-linkfgcolor-v2 Fetch-It-Via: git fetch https://github.com/gitgitgadget/git pr-git-2217/BLumia/gitk-linkfgcolor-v2 Pull-Request: https://github.com/git/git/pull/2217 Range-diff vs v1: 1: d5d8897fbb ! 1: f533af7ac5 gitk: support config the color of linkfgcolor via Gitk Preferences @@ Metadata Author: Wang Zichong ## Commit message ## - gitk: support config the color of linkfgcolor via Gitk Preferences + gitk: support link color in the Preferences dialog As a dark-theme user, I use the Preferences dialog to set colors - for gitk, the only color I cannot change via that dialog is the - link foreground color, which will lead me to use the default link - color on a dark background that make it not really readable. + for gitk. The only color I cannot change via that dialog is the + link foreground color, which leads to using the default link color + on a dark background that makes it hard to read. - This patch makes the link foreground color also configurable in the - Gitk Preferences dialog's Color tab, so user won't need to dig into - the code/manual to know if the link color is configurable and can - simply set the color there. + Make the link foreground color also configurable in the Gitk + Preferences dialog's Color tab, so users won't need to dig into + the code/manual to check if it is configurable and can simply set + the color there. - CC: Mark Levedahl , Paul Mackerras + CC: Mark Levedahl + CC: Paul Mackerras + CC: Johannes Sixt Signed-off-by: Wang Zichong + --- + Changelog (v2): + + * reword commit message as suggesed by Johannes + * Rename button text from "link color" to "link" as suggested + by Johannes ## gitk-git/gitk ## @@ gitk-git/gitk: proc prefspage_general {notebook} { @@ gitk-git/gitk: proc prefspage_colors {notebook} { grid x $page.selbgbut $page.selbgsep -sticky w + label $page.linkfg -padx 40 -relief sunk -background $linkfgcolor -+ ttk::button $page.linkfgbut -text [mc "Link color"] \ -+ -command [list choosecolor linkfgcolor {} $page [mc "link color"]] ++ ttk::button $page.linkfgbut -text [mc "Link"] \ ++ -command [list choosecolor linkfgcolor {} $page [mc "link"]] + grid x $page.linkfgbut $page.linkfg -sticky w + grid columnconfigure $page 2 -weight 1 Changelog (v2): * reword commit message as suggesed by Johannes * Rename button text from "link color" to "link" as suggested by Johannes --- gitk-git/gitk | 10 ++++++++-- 1 file changed, 8 insertions(+), 2 deletions(-) diff --git a/gitk-git/gitk b/gitk-git/gitk index cbaaee994e..1c289174d5 100755 --- a/gitk-git/gitk +++ b/gitk-git/gitk @@ -11796,7 +11796,7 @@ proc prefspage_general {notebook} { proc prefspage_colors {notebook} { global bgcolor fgcolor ctext diffcolors selectbgcolor markbgcolor - global diffbgcolors + global diffbgcolors linkfgcolor global themeloader set page [create_prefs_page $notebook.colors] @@ -11873,6 +11873,11 @@ proc prefspage_colors {notebook} { -command [list choosecolor selectbgcolor {} $page [mc "background"]] grid x $page.selbgbut $page.selbgsep -sticky w + label $page.linkfg -padx 40 -relief sunk -background $linkfgcolor + ttk::button $page.linkfgbut -text [mc "Link"] \ + -command [list choosecolor linkfgcolor {} $page [mc "link"]] + grid x $page.linkfgbut $page.linkfg -sticky w + grid columnconfigure $page 2 -weight 1 return $page @@ -11880,7 +11885,7 @@ proc prefspage_colors {notebook} { proc prefspage_set_colorswatches {page} { global bgcolor fgcolor ctext diffcolors selectbgcolor markbgcolor - global diffbgcolors + global diffbgcolors linkfgcolor $page.bg configure -background $bgcolor $page.fg configure -background $fgcolor @@ -11891,6 +11896,7 @@ proc prefspage_set_colorswatches {page} { $page.hunksep configure -background [lindex $diffcolors 2] $page.markbgsep configure -background $markbgcolor $page.selbgsep configure -background $selectbgcolor + $page.linkfg configure -background $linkfgcolor } proc prefspage_fonts {notebook} { base-commit: 7b2bccb0d58d4f24705bf985de1f4612e4cf06e5 -- gitgitgadget ``` ## Johannes Sixt, 2026-02-28 07:51 Subject: Re: [PATCH] gitk: support config the color of linkfgcolor via Gitk Preferences Message-ID: <8526ae9b-804b-4f39-b5bd-1a8971cc7d6c@kdbg.org> URL: https://gitlist.dev/e/8526ae9b-804b-4f39-b5bd-1a8971cc7d6c%40kdbg.org In-Reply-To: <3FA6BA9ACF1B34AF+20260228033725.2546976-1-wangzichong@deepin.org> ``` Am 28.02.26 um 04:37 schrieb Wang Zichong: > This usage is actually from the example provided at GitGitGadget's > landing page: > > https://gitgitgadget.github.io/ > > If writing multiple CC trailers is preferred, maybe we also need to update > GitGitGadget's documentation as well. This page says: "You can CC potential reviewers by adding a footer to the PR description..." The commit message is not the PR description. Please don't add Cc lines to the commit message. Edit the PR description on Github before you /submit the patches with GitGitGadget. -- Hannes ``` ## Gary Wang via GitGitGadget, 2026-02-28 07:59 Subject: [PATCH v3] gitk: support link color in the Preferences dialog Message-ID: URL: https://gitlist.dev/e/pull.2217.v3.git.git.1772265584806.gitgitgadget%40gmail.com In-Reply-To: ``` From: Wang Zichong As a dark-theme user, I use the Preferences dialog to set colors for gitk. The only color I cannot change via that dialog is the link foreground color, which leads to using the default link color on a dark background that makes it hard to read. Make the link foreground color also configurable in the Gitk Preferences dialog's Color tab, so users won't need to dig into the code/manual to check if it is configurable and can simply set the color there. Signed-off-by: Wang Zichong --- gitk: support config the color of linkfgcolor via Gitk Preferences Published-As: https://github.com/gitgitgadget/git/releases/tag/pr-git-2217%2FBLumia%2Fgitk-linkfgcolor-v3 Fetch-It-Via: git fetch https://github.com/gitgitgadget/git pr-git-2217/BLumia/gitk-linkfgcolor-v3 Pull-Request: https://github.com/git/git/pull/2217 Range-diff vs v2: 1: f533af7ac5 ! 1: a2be1c0441 gitk: support link color in the Preferences dialog @@ Commit message the code/manual to check if it is configurable and can simply set the color there. - CC: Mark Levedahl - CC: Paul Mackerras - CC: Johannes Sixt Signed-off-by: Wang Zichong --- - Changelog (v2): + Changelog (v3): - * reword commit message as suggesed by Johannes - * Rename button text from "link color" to "link" as suggested - by Johannes + * Remove CC list from commit message as suggested by Hannes ## gitk-git/gitk ## @@ gitk-git/gitk: proc prefspage_general {notebook} { Changelog (v3): * Remove CC list from commit message as suggested by Hannes --- gitk-git/gitk | 10 ++++++++-- 1 file changed, 8 insertions(+), 2 deletions(-) diff --git a/gitk-git/gitk b/gitk-git/gitk index cbaaee994e..1c289174d5 100755 --- a/gitk-git/gitk +++ b/gitk-git/gitk @@ -11796,7 +11796,7 @@ proc prefspage_general {notebook} { proc prefspage_colors {notebook} { global bgcolor fgcolor ctext diffcolors selectbgcolor markbgcolor - global diffbgcolors + global diffbgcolors linkfgcolor global themeloader set page [create_prefs_page $notebook.colors] @@ -11873,6 +11873,11 @@ proc prefspage_colors {notebook} { -command [list choosecolor selectbgcolor {} $page [mc "background"]] grid x $page.selbgbut $page.selbgsep -sticky w + label $page.linkfg -padx 40 -relief sunk -background $linkfgcolor + ttk::button $page.linkfgbut -text [mc "Link"] \ + -command [list choosecolor linkfgcolor {} $page [mc "link"]] + grid x $page.linkfgbut $page.linkfg -sticky w + grid columnconfigure $page 2 -weight 1 return $page @@ -11880,7 +11885,7 @@ proc prefspage_colors {notebook} { proc prefspage_set_colorswatches {page} { global bgcolor fgcolor ctext diffcolors selectbgcolor markbgcolor - global diffbgcolors + global diffbgcolors linkfgcolor $page.bg configure -background $bgcolor $page.fg configure -background $fgcolor @@ -11891,6 +11896,7 @@ proc prefspage_set_colorswatches {page} { $page.hunksep configure -background [lindex $diffcolors 2] $page.markbgsep configure -background $markbgcolor $page.selbgsep configure -background $selectbgcolor + $page.linkfg configure -background $linkfgcolor } proc prefspage_fonts {notebook} { base-commit: 7b2bccb0d58d4f24705bf985de1f4612e4cf06e5 -- gitgitgadget ``` ## Wang Zichong, 2026-02-28 08:02 Subject: Re: [PATCH] gitk: support config the color of linkfgcolor via Gitk Preferences Message-ID: <03C4B4FC7F6D3C97+20260228080212.3338436-1-wangzichong@deepin.org> URL: https://gitlist.dev/e/03C4B4FC7F6D3C97%2B20260228080212.3338436-1-wangzichong%40deepin.org In-Reply-To: <8526ae9b-804b-4f39-b5bd-1a8971cc7d6c@kdbg.org> ``` > This page says: > > "You can CC potential reviewers by adding a footer to the PR description..." > > The commit message is not the PR description. Please don't add Cc lines > to the commit message. Edit the PR description on Github before you > /submit the patches with GitGitGadget. > > -- Hannes Sorry! Patch now updated with CC removed from commit message and moved to PR description. -- Gary ``` ## Johannes Sixt, 2026-03-01 10:30 Subject: Re: [PATCH v3] gitk: support link color in the Preferences dialog Message-ID: URL: https://gitlist.dev/e/a8dff43f-0454-40a5-93b1-aeb7cab8e9c4%40kdbg.org In-Reply-To: ``` Thanks, queued. -- Hannes ```