threads / discuss / 65039

[GSoC] repo: remove unused header

Subject: [GSoC] repo: remove unused header

## tl;dr

3 messages between Feb 22, 2026 and Feb 22, 2026.

replies: 2people: 2as markdown or json

K Jayatheerth· Feb 22, 2026, 00:40 UTC · lore

The "hex.h" header is included in "builtin/repo.c", but none of the functions or macros it provides are used in this file.

Signed-off-by: K Jayatheerth <jayatheerthkulkarni2005@gmail.com>
---

As instructed in the Getting Started section of SoC 2026 Ideas page in repo project This comes as a micro patch.

 builtin/repo.c | 1 -
 1 file changed, 1 deletion(-)

diff --git a/builtin/repo.c b/builtin/repo.c
index 0ea045abc1..63d21df4c2 100644
--- a/builtin/repo.c
+++ b/builtin/repo.c
@@ -2,7 +2,6 @@
 
 #include "builtin.h"
 #include "environment.h"
-#include "hex.h"
 #include "odb.h"
 #include "parse-options.h"
 #include "path-walk.h"

-- 
2.52.0

Justin Tobler· Feb 22, 2026, 05:13 UTC · re: K Jayatheerth · lore

Re: [GSoC] repo: remove unused header

On 26/02/22 06:10AM, K Jayatheerth wrote:

Show 21 quoted lines

> The "hex.h" header is included in "builtin/repo.c", but none of the
> functions or macros it provides are used in this file.
> 
> Signed-off-by: K Jayatheerth <jayatheerthkulkarni2005@gmail.com>
> ---
> 
> As instructed in the Getting Started section of SoC 2026 Ideas page in repo project
> This comes as a micro patch.
> 
>  builtin/repo.c | 1 -
>  1 file changed, 1 deletion(-)
> 
> diff --git a/builtin/repo.c b/builtin/repo.c
> index 0ea045abc1..63d21df4c2 100644
> --- a/builtin/repo.c
> +++ b/builtin/repo.c
> @@ -2,7 +2,6 @@
>  
>  #include "builtin.h"
>  #include "environment.h"
> -#include "hex.h"

This include is indeed unused. I am currently working on a series [1] that will use this header again. I can of course just re-add it in that series as well though.

Thanks, -Justin

[1]: <20260203221758.1164434-1-jltobler@gmail.com>

JAYATHEERTH K· Feb 22, 2026, 07:59 UTC · re: Justin Tobler · lore

Re: [GSoC] repo: remove unused header

On Sun, Feb 22, 2026 at 10:43 AM Justin Tobler <jltobler@gmail.com> wrote:

Show 28 quoted lines

>
> On 26/02/22 06:10AM, K Jayatheerth wrote:
> > The "hex.h" header is included in "builtin/repo.c", but none of the
> > functions or macros it provides are used in this file.
> >
> > Signed-off-by: K Jayatheerth <jayatheerthkulkarni2005@gmail.com>
> > ---
> >
> > As instructed in the Getting Started section of SoC 2026 Ideas page in repo project
> > This comes as a micro patch.
> >
> >  builtin/repo.c | 1 -
> >  1 file changed, 1 deletion(-)
> >
> > diff --git a/builtin/repo.c b/builtin/repo.c
> > index 0ea045abc1..63d21df4c2 100644
> > --- a/builtin/repo.c
> > +++ b/builtin/repo.c
> > @@ -2,7 +2,6 @@
> >
> >  #include "builtin.h"
> >  #include "environment.h"
> > -#include "hex.h"
>
> This include is indeed unused. I am currently working on a series [1]
> that will use this header again. I can of course just re-add it in that
> series as well though.
>

Understood Justin Thanks for the info

Regards
- Jayatheerth