[PATCH] t1420: use test helpers for lost-found checks

Pushkar Singh· Jan 11, 2026, 14:38 UTC · lore

The lost-found test used raw `test -f` and `ls | wc -l` checks. Replace them with `test_path_is_file` and `test_line_count` to provide clearer failure diagnostics and keep the test consistent with the rest of the test suite.

Signed-off-by: Pushkar Singh <pushkarkumarsingh1970@gmail.com>
---
 t/t1420-lost-found.sh | 7 ++++---
 1 file changed, 4 insertions(+), 3 deletions(-)

Show changes to t/t1420-lost-found.sh +4 −3

diff --git a/t/t1420-lost-found.sh b/t/t1420-lost-found.sh
index 2fb2f44f02..da1e48d35e 100755
--- a/t/t1420-lost-found.sh
+++ b/t/t1420-lost-found.sh
@@ -28,9 +28,10 @@ test_expect_success 'lost and found something' '
 	test_tick &&
 	git reset --hard HEAD^ &&
 	git fsck --lost-found &&
-	test 2 = $(ls .git/lost-found/*/* | wc -l) &&
-	test -f .git/lost-found/commit/$(cat lost-commit) &&
-	test -f .git/lost-found/other/$(cat lost-other)
+	ls .git/lost-found/*/* >actual &&
+	test_line_count = 2 actual &&
+	test_path_is_file .git/lost-found/commit/$(cat lost-commit) &&
+	test_path_is_file .git/lost-found/other/$(cat lost-other)
 '
 
 test_done

-- 
2.43.0

Pushkar Singh· Jan 11, 2026, 14:50 UTC · re: Pushkar Singh · lore

Re: [PATCH] t1420: use test helpers for lost-found checks

I noticed that this test is already being worked on and reviewed in another thread. I’ll drop this patch to avoid duplication.

Thanks, Pushkar

On Sun, Jan 11, 2026 at 8:09 PM Pushkar Singh <pushkarkumarsingh1970@gmail.com> wrote:

Show 32 quoted lines

>
> The lost-found test used raw `test -f` and `ls | wc -l` checks.
> Replace them with `test_path_is_file` and `test_line_count` to provide
> clearer failure diagnostics and keep the test consistent with the
> rest of the test suite.
>
> Signed-off-by: Pushkar Singh <pushkarkumarsingh1970@gmail.com>
> ---
>  t/t1420-lost-found.sh | 7 ++++---
>  1 file changed, 4 insertions(+), 3 deletions(-)
>
> diff --git a/t/t1420-lost-found.sh b/t/t1420-lost-found.sh
> index 2fb2f44f02..da1e48d35e 100755
> --- a/t/t1420-lost-found.sh
> +++ b/t/t1420-lost-found.sh
> @@ -28,9 +28,10 @@ test_expect_success 'lost and found something' '
>         test_tick &&
>         git reset --hard HEAD^ &&
>         git fsck --lost-found &&
> -       test 2 = $(ls .git/lost-found/*/* | wc -l) &&
> -       test -f .git/lost-found/commit/$(cat lost-commit) &&
> -       test -f .git/lost-found/other/$(cat lost-other)
> +       ls .git/lost-found/*/* >actual &&
> +       test_line_count = 2 actual &&
> +       test_path_is_file .git/lost-found/commit/$(cat lost-commit) &&
> +       test_path_is_file .git/lost-found/other/$(cat lost-other)
>  '
>
>  test_done
> --
> 2.43.0
>

patcht1420: use test helpers for lost-found checks