# [PATCH][next] hook: check for NULL pointer before deref 3 messages from 2026-01-09 to 2026-01-09. Participants: Adrian Ratiu, Patrick Steinhardt. Thread: https://gitlist.dev/t/64763 ## Adrian Ratiu, 2026-01-09 15:35 Subject: [PATCH][next] hook: check for NULL pointer before deref Message-ID: <20260109153528.476163-1-adrian.ratiu@collabora.com> URL: https://gitlist.dev/e/20260109153528.476163-1-adrian.ratiu%40collabora.com ``` Fix a compiler warning (-Werror=analyzer-deref-before-check) due to dereferencing the options pointer before NULL checking it. In practice run_hooks_opt() is never called with a NULL opt struct, so this just fixes the code to not trigger the warning anymore. The NULL check is kept as-is because some future patches might end up calling run_hooks_opt with a NULL opt struct, which is clearly a bug. While at it, also fix the BUG message function name. Reported-by: correctmost Suggested-by: Patrick Steinhardt Signed-off-by: Adrian Ratiu --- This is based on next, because it fixes a warning introduced in next. Succesful CI run: https://github.com/10ne1/git/actions/runs/20855922803 --- hook.c | 7 ++++--- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/hook.c b/hook.c index 35211e5ed7..c257bd3940 100644 --- a/hook.c +++ b/hook.c @@ -148,12 +148,11 @@ int run_hooks_opt(struct repository *r, const char *hook_name, }; const char *const hook_path = find_hook(r, hook_name); int ret = 0; - const struct run_process_parallel_opts opts = { + struct run_process_parallel_opts opts = { .tr2_category = "hook", .tr2_label = hook_name, .processes = 1, - .ungroup = options->ungroup, .get_next_task = pick_next_hook, .start_failure = notify_start_failure, @@ -165,11 +164,13 @@ int run_hooks_opt(struct repository *r, const char *hook_name, }; if (!options) - BUG("a struct run_hooks_opt must be provided to run_hooks"); + BUG("a struct run_hooks_opt must be provided to run_hooks_opt"); if (options->path_to_stdin && options->feed_pipe) BUG("options path_to_stdin and feed_pipe are mutually exclusive"); + opts.ungroup = options->ungroup; + if (options->invoked_hook) *options->invoked_hook = 0; -- 2.51.2 ``` ## Patrick Steinhardt, 2026-01-09 15:51 Subject: Re: [PATCH][next] hook: check for NULL pointer before deref Message-ID: URL: https://gitlist.dev/e/aWEkCqABozBzT-QS%40pks.im In-Reply-To: <20260109153528.476163-1-adrian.ratiu@collabora.com> ``` On Fri, Jan 09, 2026 at 05:35:28PM +0200, Adrian Ratiu wrote: > diff --git a/hook.c b/hook.c > index 35211e5ed7..c257bd3940 100644 > --- a/hook.c > +++ b/hook.c > @@ -148,12 +148,11 @@ int run_hooks_opt(struct repository *r, const char *hook_name, > }; > const char *const hook_path = find_hook(r, hook_name); > int ret = 0; > - const struct run_process_parallel_opts opts = { > + struct run_process_parallel_opts opts = { > .tr2_category = "hook", > .tr2_label = hook_name, > > .processes = 1, > - .ungroup = options->ungroup, > > .get_next_task = pick_next_hook, > .start_failure = notify_start_failure, What's omitted here is that the next two lines also dereference `options`. That'll also have to be fixed for the warning to go away. Patrick ``` ## Adrian Ratiu, 2026-01-09 15:57 Subject: Re: [PATCH][next] hook: check for NULL pointer before deref Message-ID: <87ecnywzhd.fsf@collabora.com> URL: https://gitlist.dev/e/87ecnywzhd.fsf%40collabora.com In-Reply-To: ``` On Fri, 09 Jan 2026, Patrick Steinhardt wrote: > On Fri, Jan 09, 2026 at 05:35:28PM +0200, Adrian Ratiu wrote: >> diff --git a/hook.c b/hook.c >> index 35211e5ed7..c257bd3940 100644 >> --- a/hook.c >> +++ b/hook.c >> @@ -148,12 +148,11 @@ int run_hooks_opt(struct repository *r, const char *hook_name, >> }; >> const char *const hook_path = find_hook(r, hook_name); >> int ret = 0; >> - const struct run_process_parallel_opts opts = { >> + struct run_process_parallel_opts opts = { >> .tr2_category = "hook", >> .tr2_label = hook_name, >> >> .processes = 1, >> - .ungroup = options->ungroup, >> >> .get_next_task = pick_next_hook, >> .start_failure = notify_start_failure, > > What's omitted here is that the next two lines also dereference > `options`. That'll also have to be fixed for the warning to go away. Thanks for spotting this. Will fix in the same way. ```