# [PATCH] t2021: use test helpers instead of shell primitives 1 messages from 2026-01-02 to 2026-01-02. Participants: pushkarkumarsingh1970@gmail.com. Thread: https://gitlist.dev/t/64711 ## pushkarkumarsingh1970@gmail.com, 2026-01-02 11:03 Subject: [PATCH] t2021: use test helpers instead of shell primitives Message-ID: <20260102110452.19221-1-pushkarkumarsingh1970@gmail.com> URL: https://gitlist.dev/e/20260102110452.19221-1-pushkarkumarsingh1970%40gmail.com ``` From: Pushkar Singh The tests here used plain `test -f` and `test -h` checks. Replacing them with `test_path_is_file` and `test_path_is_symlink` makes failures easier to understand and keeps the test style consistent with the rest of the suite. Signed-off-by: Pushkar Singh --- t/t2021-checkout-overwrite.sh | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/t/t2021-checkout-overwrite.sh b/t/t2021-checkout-overwrite.sh index a5c03d5d4a..38c41ae373 100755 --- a/t/t2021-checkout-overwrite.sh +++ b/t/t2021-checkout-overwrite.sh @@ -27,7 +27,7 @@ test_expect_success 'checkout commit with dir must not remove untracked a/b' ' git rm --cached a/b && git commit -m "un-track the file" && test_must_fail git checkout start && - test -f a/b + test_path_is_file a/b ' test_expect_success 'create a commit where dir a/b changed to symlink' ' @@ -49,7 +49,7 @@ test_expect_success 'checkout commit with dir must not remove untracked a/b' ' test_expect_success SYMLINKS 'the symlink remained' ' - test -h a/b + test_path_is_symlink a/b ' test_expect_success 'cleanup after previous symlink tests' ' -- 2.43.0 ```