# [PATCH v2] t1300: use test helpers instead of shell primitives 1 messages from 2026-01-02 to 2026-01-02. Participants: pushkarkumarsingh1970@gmail.com. Thread: https://gitlist.dev/t/64710 ## pushkarkumarsingh1970@gmail.com, 2026-01-02 09:46 Subject: [PATCH v2] t1300: use test helpers instead of shell primitives Message-ID: <20260102095248.18780-1-pushkarkumarsingh1970@gmail.com> URL: https://gitlist.dev/e/20260102095248.18780-1-pushkarkumarsingh1970%40gmail.com ``` From: Pushkar Singh Replace plain "test -f" (regular file checks) with "test_path_is_file" and "test -h" (symbolic link checks) with "test_path_is_symlink". The test framework helpers provide clearer diagnostics and better consistency across the test suite. Signed-off-by: Pushkar Singh --- v2: expand commit message to clarify that - test -f checks regular files - test -h checks symbolic links t/t1300-config.sh | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/t/t1300-config.sh b/t/t1300-config.sh index 358d636379..9850fcd5b5 100755 --- a/t/t1300-config.sh +++ b/t/t1300-config.sh @@ -1232,12 +1232,12 @@ test_expect_success SYMLINKS 'symlinked configuration' ' test_when_finished "rm myconfig" && ln -s notyet myconfig && git config --file=myconfig test.frotz nitfol && - test -h myconfig && - test -f notyet && + test_path_is_symlink myconfig && + test_path_is_file notyet && test "z$(git config --file=notyet test.frotz)" = znitfol && git config --file=myconfig test.xyzzy rezrov && - test -h myconfig && - test -f notyet && + test_path_is_symlink myconfig && + test_path_is_file notyet && cat >expect <<-\EOF && nitfol rezrov -- 2.43.0 ```