threads / patch / 64650

patchrepository: cache->squash_msg is freed twice

Subject: [PATCH] repository: cache->squash_msg is freed twice

## tl;dr

4 messages between Dec 18, 2025 and Dec 19, 2025. Diffs are folded; open one to read it.

replies: 3people: 3as markdown or json

AZero13 via GitGitGadget· Dec 18, 2025, 15:26 UTC · lore
From: Greg Funni <gfunni234@gmail.com>

Thankfully, it is set to NULL, so no security consequences. However, this is still a mistake that must be rectified.

Signed-off-by: Greg Funni <gfunni234@gmail.com>
---
    repository: cache->squash_msg is freed twice
    
    Thankfully, it is set to NULL, so no security consequences.
    
    However, this is still a mistake that must be rectified.
    
    Signed-off-by: Greg Funni gfunni234@gmail.com
Published-As: https://github.com/gitgitgadget/git/releases/tag/pr-git-2132%2FAZero13%2Ftwice-v1
Fetch-It-Via: git fetch https://github.com/gitgitgadget/git pr-git-2132/AZero13/twice-v1
Pull-Request: https://github.com/git/git/pull/2132
 repository.c | 1 -
 1 file changed, 1 deletion(-)
Show changes to repository.c +0 −1
diff --git a/repository.c b/repository.c
index 863f24411b..c7e75215ac 100644
--- a/repository.c
+++ b/repository.c
@@ -349,7 +349,6 @@ out:
 
 static void repo_clear_path_cache(struct repo_path_cache *cache)
 {
-	FREE_AND_NULL(cache->squash_msg);
 	FREE_AND_NULL(cache->squash_msg);
 	FREE_AND_NULL(cache->merge_msg);
 	FREE_AND_NULL(cache->merge_rr);

base-commit: c4a0c8845e2426375ad257b6c221a3a7d92ecfda

-- 
gitgitgadget
AZero13 via GitGitGadget· Dec 18, 2025, 15:49 UTC · re: AZero13 via GitGitGadget · lore

[PATCH v2] repository: remove duplicate free of cache->squash_msg

From: Greg Funni <gfunni234@gmail.com>

Thankfully, it is set to NULL, so no security consequences. However, this is still a mistake that must be rectified.

Signed-off-by: Greg Funni <gfunni234@gmail.com>
---
    repository: remove duplicate free of cache->squash_msg
    
    Thankfully, it is set to NULL, so no security consequences.
    
    However, this is still a mistake that must be rectified.
    
    Signed-off-by: Greg Funni gfunni234@gmail.com
Published-As: https://github.com/gitgitgadget/git/releases/tag/pr-git-2132%2FAZero13%2Ftwice-v2
Fetch-It-Via: git fetch https://github.com/gitgitgadget/git pr-git-2132/AZero13/twice-v2
Pull-Request: https://github.com/git/git/pull/2132
Range-diff vs v1:
 1:  35d0606190 ! 1:  ac2abd592d repository: cache->squash_msg is freed twice
     @@ Metadata
      Author: Greg Funni <gfunni234@gmail.com>
      
       ## Commit message ##
     -    repository: cache->squash_msg is freed twice
     +    repository: remove duplicate free of cache->squash_msg
      
          Thankfully, it is set to NULL, so no security consequences.
          However, this is still a mistake that must be rectified.
 repository.c | 1 -
 1 file changed, 1 deletion(-)
Show changes to repository.c +0 −1
diff --git a/repository.c b/repository.c
index 863f24411b..c7e75215ac 100644
--- a/repository.c
+++ b/repository.c
@@ -349,7 +349,6 @@ out:
 
 static void repo_clear_path_cache(struct repo_path_cache *cache)
 {
-	FREE_AND_NULL(cache->squash_msg);
 	FREE_AND_NULL(cache->squash_msg);
 	FREE_AND_NULL(cache->merge_msg);
 	FREE_AND_NULL(cache->merge_rr);

base-commit: c4a0c8845e2426375ad257b6c221a3a7d92ecfda

-- 
gitgitgadget
Eric Sunshine· Dec 18, 2025, 18:18 UTC · re: AZero13 via GitGitGadget · lore

Re: [PATCH] repository: cache->squash_msg is freed twice

On Thu, Dec 18, 2025 at 10:26 AM AZero13 via GitGitGadget <gitgitgadget@gmail.com> wrote:

Show 13 quoted lines
> Thankfully, it is set to NULL, so no security consequences.
> However, this is still a mistake that must be rectified.
>
> Signed-off-by: Greg Funni <gfunni234@gmail.com>
> ---
> diff --git a/repository.c b/repository.c
> @@ -349,7 +349,6 @@ out:
>  static void repo_clear_path_cache(struct repo_path_cache *cache)
>  {
> -       FREE_AND_NULL(cache->squash_msg);
>         FREE_AND_NULL(cache->squash_msg);
>         FREE_AND_NULL(cache->merge_msg);
>         FREE_AND_NULL(cache->merge_rr);

This mistake has been present since Ævar added this function in 759f340738 (repository.c: free the "path cache" in repo_clear(), 2022-03-04), so it isn't the result of someone else coming along and adding a new field to the structure which needs freeing but then botching the call to FREE_AND_NULL(). Moreover, this function does free all the freeable members of repo_path_cache, hence, nothing is being leaked, so it must have just been a silly copy/paste mistake in the first place. Hence, this change makes sense.

Junio C Hamano· Dec 19, 2025, 03:52 UTC · re: Eric Sunshine · lore

Re: [PATCH] repository: cache->squash_msg is freed twice

Eric Sunshine <sunshine@sunshineco.com> writes:
Show 24 quoted lines
> On Thu, Dec 18, 2025 at 10:26 AM AZero13 via GitGitGadget
> <gitgitgadget@gmail.com> wrote:
>> Thankfully, it is set to NULL, so no security consequences.
>> However, this is still a mistake that must be rectified.
>>
>> Signed-off-by: Greg Funni <gfunni234@gmail.com>
>> ---
>> diff --git a/repository.c b/repository.c
>> @@ -349,7 +349,6 @@ out:
>>  static void repo_clear_path_cache(struct repo_path_cache *cache)
>>  {
>> -       FREE_AND_NULL(cache->squash_msg);
>>         FREE_AND_NULL(cache->squash_msg);
>>         FREE_AND_NULL(cache->merge_msg);
>>         FREE_AND_NULL(cache->merge_rr);
>
> This mistake has been present since Ævar added this function in
> 759f340738 (repository.c: free the "path cache" in repo_clear(),
> 2022-03-04), so it isn't the result of someone else coming along and
> adding a new field to the structure which needs freeing but then
> botching the call to FREE_AND_NULL(). Moreover, this function does
> free all the freeable members of repo_path_cache, hence, nothing is
> being leaked, so it must have just been a silly copy/paste mistake in
> the first place. Hence, this change makes sense.
Thanks, both.  Will queue.

← back to recent threads