# [PATCH] --walk-reflogs: do not crash with cyclic reflog ancestry

1 messages from 2007-01-20 to 2007-01-20. Participants: Johannes Schindelin.
Thread: https://gitlist.dev/t/6457

## Johannes Schindelin, 2007-01-20 21:28

Subject: [PATCH] --walk-reflogs: do not crash with cyclic reflog ancestry
Message-ID: <Pine.LNX.4.63.0701202227500.22628@wbgn013.biozentrum.uni-wuerzburg.de>
URL: https://gitlist.dev/e/Pine.LNX.4.63.0701202227500.22628%40wbgn013.biozentrum.uni-wuerzburg.de

```

Since you can reset --hard to any revision you already had, when
traversing the reflog ancestry, we may not free() the commit buffer.

Signed-off-by: Johannes Schindelin <Johannes.Schindelin@gmx.de>
---
 builtin-log.c |    7 +++++--
 1 files changed, 5 insertions(+), 2 deletions(-)

diff --git a/builtin-log.c b/builtin-log.c
index f3cff13..13a3f9b 100644
--- a/builtin-log.c
+++ b/builtin-log.c
@@ -50,8 +50,11 @@ static int cmd_log_walk(struct rev_info *rev)
 	prepare_revision_walk(rev);
 	while ((commit = get_revision(rev)) != NULL) {
 		log_tree_commit(rev, commit);
-		free(commit->buffer);
-		commit->buffer = NULL;
+		if (!rev->reflog_info) {
+			/* we allow cycles in reflog ancestry */
+			free(commit->buffer);
+			commit->buffer = NULL;
+		}
 		free_commit_list(commit->parents);
 		commit->parents = NULL;
 	}
-- 
1.5.0.rc1.g956c1-dirty

```