patch, 2 partszsh testsuite fixes

This series contains two small patches to make our testsuite pass under zsh's sh mode with 5.9. This is the mode that is in use when zsh is invoked as `sh` and differs from zsh's default behavior.

Note that no attempt has been made to make the testsuite work under zsh's default or ksh modes, since it is known that many tests will fail in this case (in part, because outside of sh mode, zsh runs the final process in a pipeline in the main shell instead of a subshell).

The first patch fixes a compatibility issue in which we've accidentally requested behavior from POSIX 1003.1-2024, which is too new to be portably supported. It just so happens that most shells happen to support it anyway, but zsh does not at the moment.

The second patch fixes a more mysterious issue with the testsuite hanging. It's unclear why it does so, but it almost certainly has to do with the internals of the testsuite since creating a simple testcase does not reproduce the problem. However, the patch is simple and easy (simply change to a subshell), so we do so.

With these two patches, the testsuite passes in zsh's sh mode. This should offer users whose `/bin/sh` is AT&T ksh93 (which does not support `local` and therefore does not work as our shell) an additional choice of shells to use for portability.

brian m. carlson (2):
  t0614: use numerical comparison with test_line_count
  t5564: fix test hang under zsh's sh mode

 t/t0614-reftable-fsck.sh | 2 +-
 t/t5564-http-proxy.sh    | 4 ++--
 2 files changed, 3 insertions(+), 3 deletions(-)

In this comparison, we want to know whether the number of lines is greater than 1. Our test_line_count function passes the first argument as the comparison operator to test, so what we want is a numerical comparison, not a string comparison. While this does not produce a functional problem now, it could very well if we expected two or more items, in which case the value "10" would not match when it should.

Furthermore, the "<" and ">" comparisons are new in POSIX 1003.1-2024 and we don't want to require such a new version of POSIX since many popular and supported operating systems were released before that version of POSIX was released.

Finally, zsh's builtin test operator does not like the greater-than sign in "test", since it is only supported in the double-bracket extension. This has been reported and will be addressed in a future version, but since our code is also technically incorrect, as well as not very compatible, let's fix it by using a numeric comparison.

Signed-off-by: brian m. carlson <sandals@crustytoothpaste.net>
---
 t/t0614-reftable-fsck.sh | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

This test starts a SOCKS server in Perl in the background and then kills it after the tests are done. However, when using zsh (in sh mode) in the tests, the start_socks function hangs until the background process is killed.

Note that this does not reproduce in a simple shell script, so there is likely some interaction between job handling, our heavy use of eval in the test framework, and possibly other complexities of our test framework. What is clear, however, is that switching from a compound statement to a subshell fixes the problem entirely and the test passes with no problem, so do that.

Signed-off-by: brian m. carlson <sandals@crustytoothpaste.net>
---
 t/t5564-http-proxy.sh | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)