# [PATCH] refs: Add missing space in message 3 messages from 2025-11-05 to 2025-11-06. Participants: Peter Krefting, Junio C Hamano. Thread: https://gitlist.dev/t/64447 ## Peter Krefting, 2025-11-05 21:47 Subject: [PATCH] refs: Add missing space in message Message-ID: URL: https://gitlist.dev/e/a8220721-3260-15cb-6960-ca8b6433d7b5%40softwolves.pp.se ``` Signed-off-by: Peter Krefting --- refs/files-backend.c | 2 +- refs/reftable-backend.c | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/refs/files-backend.c b/refs/files-backend.c index 054cf42f4e..1adc4b5182 100644 --- a/refs/files-backend.c +++ b/refs/files-backend.c @@ -3124,7 +3124,7 @@ static int parse_and_write_reflog(struct files_ref_store *refs, if (!(update->flags & REF_HAVE_OLD) || !(update->flags & REF_HAVE_NEW) || !(update->flags & REF_LOG_ONLY)) { - strbuf_addf(err, _("trying to write reflog for '%s'" + strbuf_addf(err, _("trying to write reflog for '%s' " "with incomplete values"), update->refname); return REF_TRANSACTION_ERROR_GENERIC; } diff --git a/refs/reftable-backend.c b/refs/reftable-backend.c index d4b7928620..eeec64798f 100644 --- a/refs/reftable-backend.c +++ b/refs/reftable-backend.c @@ -1103,7 +1103,7 @@ static enum ref_transaction_error prepare_single_update(struct reftable_ref_stor if (!(u->flags & REF_HAVE_OLD) || !(u->flags & REF_HAVE_NEW) || !(u->flags & REF_LOG_ONLY)) { - strbuf_addf(err, _("trying to write reflog for '%s'" + strbuf_addf(err, _("trying to write reflog for '%s' " "with incomplete values"), u->refname); return REF_TRANSACTION_ERROR_GENERIC; } -- 2.47.2 ``` ## Junio C Hamano, 2025-11-05 23:03 Subject: Re: [PATCH] refs: Add missing space in message Message-ID: URL: https://gitlist.dev/e/xmqqikfokrq0.fsf%40gitster.g In-Reply-To: ``` Peter Krefting writes: > Signed-off-by: Peter Krefting > --- > refs/files-backend.c | 2 +- > refs/reftable-backend.c | 2 +- > 2 files changed, 2 insertions(+), 2 deletions(-) Good eyes. Both of these came from 465eff81 (refs: fix invalid old object IDs when migrating reflogs, 2025-08-06), which appeared in Git 2.51.1 already. Let's merge it before the upcoming release. Thanks. > diff --git a/refs/files-backend.c b/refs/files-backend.c > index 054cf42f4e..1adc4b5182 100644 > --- a/refs/files-backend.c > +++ b/refs/files-backend.c > @@ -3124,7 +3124,7 @@ static int parse_and_write_reflog(struct files_ref_store *refs, > if (!(update->flags & REF_HAVE_OLD) || > !(update->flags & REF_HAVE_NEW) || > !(update->flags & REF_LOG_ONLY)) { > - strbuf_addf(err, _("trying to write reflog for '%s'" > + strbuf_addf(err, _("trying to write reflog for '%s' " > "with incomplete values"), update->refname); > return REF_TRANSACTION_ERROR_GENERIC; > } > diff --git a/refs/reftable-backend.c b/refs/reftable-backend.c > index d4b7928620..eeec64798f 100644 > --- a/refs/reftable-backend.c > +++ b/refs/reftable-backend.c > @@ -1103,7 +1103,7 @@ static enum ref_transaction_error prepare_single_update(struct reftable_ref_stor > if (!(u->flags & REF_HAVE_OLD) || > !(u->flags & REF_HAVE_NEW) || > !(u->flags & REF_LOG_ONLY)) { > - strbuf_addf(err, _("trying to write reflog for '%s'" > + strbuf_addf(err, _("trying to write reflog for '%s' " > "with incomplete values"), u->refname); > return REF_TRANSACTION_ERROR_GENERIC; > } ``` ## Peter Krefting, 2025-11-06 12:45 Subject: Re: [PATCH] refs: Add missing space in message Message-ID: <2013e26e02fe07c1908ed8ce09359d57@softwolves.pp.se> URL: https://gitlist.dev/e/2013e26e02fe07c1908ed8ce09359d57%40softwolves.pp.se In-Reply-To: ``` 2025-11-06 00:03 skrev Junio C Hamano: > Good eyes. They are easy to spot when doing the localization, as gettext only wraps the generated PO template at whitespace. In case someone wants to spellcheck the user interface, I would recommend starting from the PO template (make po/git.pot). -- \\// Peter - http://www.softwolves.pp.se/ ```