# [PATCH v4] doc: clarify server behavior for invalid 'want' lines in HTTP protocol 2 messages from 2025-11-05 to 2025-11-06. Participants: Queen Ediri Jessa, Junio C Hamano. Thread: https://gitlist.dev/t/64445 ## Queen Ediri Jessa, 2025-11-05 14:38 Subject: [PATCH v4] doc: clarify server behavior for invalid 'want' lines in HTTP protocol Message-ID: <20251105143849.1192-1-qjessa662@gmail.com> URL: https://gitlist.dev/e/20251105143849.1192-1-qjessa662%40gmail.com ``` Update the documentation to clearly describe how the server responds when a client sends an invalid or malformed `want` line during the HTTP protocol exchange. The server includes the offending object name in its error message. Signed-off-by: Queen Ediri Jessa --- Changes since v3: - Removed extra explanatory lines per reviewer feedback. Documentation/gitprotocol-http.adoc | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/Documentation/gitprotocol-http.adoc b/Documentation/gitprotocol-http.adoc index d024010414..e2ef7f0459 100644 --- a/Documentation/gitprotocol-http.adoc +++ b/Documentation/gitprotocol-http.adoc @@ -443,7 +443,8 @@ If no "want" objects are received, send an error: TODO: Define error if no "want" lines are requested. If any "want" object is not reachable, send an error: -TODO: Define error if an invalid "want" is requested. +When a Git server receives an invalid or malformed `want` line, it +responds with an error message that includes the offending object name. Create an empty list, `s_common`. -- 2.51.0.573.gb660e2dcb9 ``` ## Junio C Hamano, 2025-11-06 17:46 Subject: Re: [PATCH v4] doc: clarify server behavior for invalid 'want' lines in HTTP protocol Message-ID: URL: https://gitlist.dev/e/xmqqikfnhx5n.fsf%40gitster.g In-Reply-To: <20251105143849.1192-1-qjessa662@gmail.com> ``` Queen Ediri Jessa writes: > Update the documentation to clearly describe how the server responds when a > client sends an invalid or malformed `want` line during the HTTP protocol > exchange. The server includes the offending object name in its error message. > > Signed-off-by: Queen Ediri Jessa > --- > Changes since v3: > - Removed extra explanatory lines per reviewer feedback. > > Documentation/gitprotocol-http.adoc | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) Thanks, will queue. ```