[RFC Outreachy] gpg-interface: Replace strbuf_split()* with string_list_split()

>
> Hello,
>
> In continuation of my search for an appropriate microproject after
> temporarily moving on from my mail to the list which was about
> the check-whitespace script check for \No newline, I stumbled on the
> thread
> https://public-inbox.org/git/20250731225433.4028872-1-gitster@pobox.com/.
> After studying the thread and searching the codebase for other
> instances where strbuf_split()* can be replaced with string_list_split(),
> I saw some cases in gpg-interface.c where get_ssh_key_fingerprint and
> get_default_ssh_signing_key functions use the strbuf_split_max to split the
> input string and I think they can be good candidates for replacement with
> string_list_split().
>
> Please, will this be good for a microproject?
> I will also appreciate any guides.

>
> Hi,
>
> On Tue, Oct 14, 2025 at 2:44 AM Bello Olamide <belkid98@gmail.com> wrote:
> >
> > Hello,
> >
> > In continuation of my search for an appropriate microproject after
> > temporarily moving on from my mail to the list which was about
> > the check-whitespace script check for \No newline, I stumbled on the
> > thread
> > https://public-inbox.org/git/20250731225433.4028872-1-gitster@pobox.com/.
> > After studying the thread and searching the codebase for other
> > instances where strbuf_split()* can be replaced with string_list_split(),
> > I saw some cases in gpg-interface.c where get_ssh_key_fingerprint and
> > get_default_ssh_signing_key functions use the strbuf_split_max to split the
> > input string and I think they can be good candidates for replacement with
> > string_list_split().
> >
> > Please, will this be good for a microproject?
> > I will also appreciate any guides.
>
> Yeah, I think it could be a good microproject.
>
> The functions you mention don't modify the strings resulting from the
> split, so those strings don't need to be strbufs. This should be noted
> in the commit message (which should provide the reasons why the change
> makes sense).