# git-send-email --suppress-from option doesn't work. 3 messages from 2007-01-18 to 2007-01-25. Participants: Timur Tabi, Andreas Ericsson. Thread: https://gitlist.dev/t/6430 ## Timur Tabi, 2007-01-18 21:07 Subject: git-send-email --suppress-from option doesn't work. Message-ID: <45AFE18C.2020303@freescale.com> URL: https://gitlist.dev/e/45AFE18C.2020303%40freescale.com ``` The --suppress-from option doesn't work for me because the comparison is too strict. Here's an example usage of git-send-email: git-send-email --suppress-from --from timur@freescale.com --to timur@tabi.org --smtp-server remotesmtp.freescale.net 0001-Add-support-for-the-MPC8349E-mITX-GP.txt I need to specify the --from option, because otherwise git-send-email will prompt me for a From address, and I don't want it to prompt me for anything. The problem is that the patchfile contains this line: From: Timur Tabi That means that the patchfile contains the string "Timur Tabi ", but the --from specifies the string "timur@freescale.com". The code which checks the suppress-from option is here: } elsif (/^(Cc|From):\s+(.*)$/) { if ($2 eq $from) { next if ($suppress_from); } I don't know Perl, but I'm guess the The "$2 eq $from" is a strict comparison that fails in my case. Some of you might say at this point, "Why don't you just specify --from "Timur Tabi "? I tried that, and it still doesn't work. Basically, what I want is to prevent git-send-email from CC'ing me on my own patches. No matter what I do, I can't prevent it from adding "Cc: Timur Tabi " to the email header. -- Timur Tabi Linux Kernel Developer @ Freescale ``` ## Andreas Ericsson, 2007-01-19 01:24 Subject: Re: git-send-email --suppress-from option doesn't work. Message-ID: <45B01DD4.7000204@op5.se> URL: https://gitlist.dev/e/45B01DD4.7000204%40op5.se In-Reply-To: <45AFE18C.2020303@freescale.com> ``` Timur Tabi wrote: > The --suppress-from option doesn't work for me because the comparison is > too strict. > > Here's an example usage of git-send-email: > > git-send-email --suppress-from --from timur@freescale.com --to > timur@tabi.org --smtp-server remotesmtp.freescale.net > 0001-Add-support-for-the-MPC8349E-mITX-GP.txt > > I need to specify the --from option, because otherwise git-send-email > will prompt me for a From address, and I don't want it to prompt me for > anything. > > The problem is that the patchfile contains this line: > > From: Timur Tabi > > That means that the patchfile contains the string "Timur Tabi > ", but the --from specifies the string > "timur@freescale.com". The code which checks the suppress-from option > is here: > > } elsif (/^(Cc|From):\s+(.*)$/) { I believe (/^(Cc|From):[^<]+<([^>])+>.*$/) would do the trick for your case. It would however fail when specifying a proper --from address in the 'git commit --author="Foo Barson "' style. Are you sure you need to specify --from for those patches though? > if ($2 eq $from) { > next if ($suppress_from); > } > > I don't know Perl, but I'm guess the The "$2 eq $from" is a strict > comparison that fails in my case. > > Some of you might say at this point, "Why don't you just specify --from > "Timur Tabi "? I tried that, and it still doesn't > work. > That sounds extremely odd indeed. Could this have to do with character conversion? -- Andreas Ericsson andreas.ericsson@op5.se OP5 AB www.op5.se Tel: +46 8-230225 Fax: +46 8-230231 ``` ## Timur Tabi, 2007-01-25 16:47 Subject: Re: git-send-email --suppress-from option doesn't work. Message-ID: <45B8DF24.6080001@freescale.com> URL: https://gitlist.dev/e/45B8DF24.6080001%40freescale.com In-Reply-To: <45B01DD4.7000204@op5.se> ``` Andreas Ericsson wrote: > > I believe > > (/^(Cc|From):[^<]+<([^>])+>.*$/) > > would do the trick for your case. It would however fail when specifying a proper > --from address in the 'git commit --author="Foo Barson "' style. Even so, it would still be very picky about the layout. --suppress-from should just compare the actual email addresses, not the names or any other characters. > Are you sure you need to specify --from for those patches though? Yes. If I don't specify --from, then git-send-email will prompt me for the From: address. I want git-send-email to be completely non-interactive. >> Some of you might say at this point, "Why don't you just specify --from >> "Timur Tabi "? I tried that, and it still doesn't >> work. > > That sounds extremely odd indeed. Could this have to do with character > conversion? Actually, I figured out the problem is that I can't do this: FROM='--from "Foo Barson "' git-send-email $FROM ... I got all sorts of weird messages about unbalanced > or something. Instead, I need to do this: FROM="Foo Barson " git-send-email --from $FROM ... This is probably a shell issue instead of a git-send-email issue, but it is annoying. -- Timur Tabi Linux Kernel Developer @ Freescale ```