threads / patch / 6415

patchUse fixed-size integers for the on-disk pack structure.

Subject: [PATCH] Use fixed-size integers for the on-disk pack structure.

## tl;dr

One message between Jan 17, 2007 and Jan 17, 2007. Diffs are folded; open one to read it.

replies: 0people: 1as markdown or json

Simon 'corecode' Schubert· Jan 17, 2007, 08:07 UTC · lore
Plain integer types without a fixed size can vary between platforms.  Even
though all common platforms use 32-bit ints, there is no guarantee that
this won't change at some point.  Furthermore, specifying an integer type
with explicit size makes the definition of structures more obvious.
---
 pack.h |    6 +++---
 1 files changed, 3 insertions(+), 3 deletions(-)
Show changes to pack.h +3 −3
diff --git a/pack.h b/pack.h
index 4814800..8aab5bb 100644
--- a/pack.h
+++ b/pack.h
@@ -10,9 +10,9 @@
 #define PACK_VERSION 2
 #define pack_version_ok(v) ((v) == htonl(2) || (v) == htonl(3))
 struct pack_header {
-	unsigned int hdr_signature;
-	unsigned int hdr_version;
-	unsigned int hdr_entries;
+	uint32_t hdr_signature;
+	uint32_t hdr_version;
+	uint32_t hdr_entries;
 };
 
 extern int verify_pack(struct packed_git *, int);
-- 
1.5.0.rc1.g8bef

← back to recent threads