threads / patch / 63953

patchDocument count-objects pack

Subject: [PATCH] Document count-objects pack

## tl;dr

7 messages between Aug 13, 2025 and Aug 14, 2025. Diffs are folded; open one to read it.

replies: 6people: 3as markdown or json

Daniele Sassoli via GitGitGadget· Aug 13, 2025, 09:40 UTC · lore

From: Daniele Sassoli <danielesassoli@gmail.com>

Juno added the printing of "packs" with ae72f685418b. When 0bdaa1216 refactored the docs for the -v option, this was missed.

Signed-off-by: Daniele Sassoli <danielesassoli@gmail.com>
---
    Document count-objects -v - packs output
    
    Juno added the printing of "packs" with ae72f68541
    [https://github.com/DanieleSassoli/git/commit/ae72f685418b79bbd67e1017c5b1ac7d731c042e].
    When 0bdaa1216
    [https://github.com/DanieleSassoli/git/commit/0bdaa12169bca5d69f2c58f96cc92d51280e9e26]refactored
    the docs for the -v option, this was missed.

Published-As: https://github.com/gitgitgadget/git/releases/tag/pr-git-2031%2FDanieleSassoli%2Fmaster-v1
Fetch-It-Via: git fetch https://github.com/gitgitgadget/git pr-git-2031/DanieleSassoli/master-v1
Pull-Request: https://github.com/git/git/pull/2031

 Documentation/git-count-objects.adoc | 2 ++
 1 file changed, 2 insertions(+)

Show changes to Documentation/git-count-objects.adoc +2 −0

diff --git a/Documentation/git-count-objects.adoc b/Documentation/git-count-objects.adoc
index 97f9f126101..eeee6b9f7f4 100644
--- a/Documentation/git-count-objects.adoc
+++ b/Documentation/git-count-objects.adoc
@@ -28,6 +28,8 @@ size: disk space consumed by loose objects, in KiB (unless -H is specified)
 +
 in-pack: the number of in-pack objects
 +
+packs: the number of pack files
++
 size-pack: disk space consumed by the packs, in KiB (unless -H is specified)
 +
 prune-packable: the number of loose objects that are also present in

base-commit: 2c2ba49d55ff26c1082b8137b1ec5eeccb4337d1

-- 
gitgitgadget

Kristoffer Haugsbakk· Aug 14, 2025, 07:30 UTC · re: Daniele Sassoli via GitGitGadget · lore

Re: [PATCH] Document count-objects pack

On Wed, Aug 13, 2025, at 11:40, Daniele Sassoli via GitGitGadget wrote:

> From: Daniele Sassoli <danielesassoli@gmail.com>
>
> Juno added the printing of "packs" with ae72f685418b.
> When 0bdaa1216 refactored the docs for the -v option, this was missed.

s/Juno/Junio/

But commits are usually just listed as-is without mentioning authors or other metadata. Something like this:[1]

    ae72f685418 (count-objects -v: show number of packs as well.,
    2006-12-27) added `packs` to the output of `-v`.  0bdaa12169b
    (git-count-objects.txt: describe each line in -v output, 2013-02-08)
    forgot to include `packs`.

The text above is a bit more terse around the commit references since the subject line for the second commit says what the intent was.

Alternatively, just referencing the second commit:

    0bdaa12169b (git-count-objects.txt: describe each line in -v output,
    2013-02-08) forgot to include `packs`.

† 1: using “commit-reference” from Documentation/SubmittingPatches

>
> Signed-off-by: Daniele Sassoli <danielesassoli@gmail.com>

Junio C Hamano· Aug 14, 2025, 14:46 UTC · re: Kristoffer Haugsbakk · lore

Re: [PATCH] Document count-objects pack

"Kristoffer Haugsbakk" <kristofferhaugsbakk@fastmail.com> writes:

Show 23 quoted lines

> On Wed, Aug 13, 2025, at 11:40, Daniele Sassoli via GitGitGadget wrote:
>> From: Daniele Sassoli <danielesassoli@gmail.com>
>>
>> Juno added the printing of "packs" with ae72f685418b.
>> When 0bdaa1216 refactored the docs for the -v option, this was missed.
>
> s/Juno/Junio/
>
> But commits are usually just listed as-is without mentioning authors or
> other metadata.  Something like this:[1]
>
>     ae72f685418 (count-objects -v: show number of packs as well.,
>     2006-12-27) added `packs` to the output of `-v`.  0bdaa12169b
>     (git-count-objects.txt: describe each line in -v output, 2013-02-08)
>     forgot to include `packs`.
>
> The text above is a bit more terse around the commit references since
> the subject line for the second commit says what the intent was.
>
> Alternatively, just referencing the second commit:
>
>     0bdaa12169b (git-count-objects.txt: describe each line in -v output,
>     2013-02-08) forgot to include `packs`.

Thanks.

Daniele Sassoli via GitGitGadget· Aug 14, 2025, 13:16 UTC · re: Daniele Sassoli via GitGitGadget · lore

[PATCH v2] Document count-objects pack

From: Daniele Sassoli <danielesassoli@gmail.com>

0bdaa12169b (git-count-objects.txt: describe each line in -v output, 2013-02-08) forgot to include `packs`.

Signed-off-by: Daniele Sassoli <danielesassoli@gmail.com>
---
    Document count-objects -v - packs output
    
    https://github.com/DanieleSassoli/git/commit/0bdaa12169bca5d69f2c58f96cc92d51280e9e26
    (git-count-objects.txt: describe each line in -v output, 2013-02-08)
    forgot to include packs.

Published-As: https://github.com/gitgitgadget/git/releases/tag/pr-git-2031%2FDanieleSassoli%2Fmaster-v2
Fetch-It-Via: git fetch https://github.com/gitgitgadget/git pr-git-2031/DanieleSassoli/master-v2
Pull-Request: https://github.com/git/git/pull/2031

Range-diff vs v1:

 1:  85bcb142b55 ! 1:  6f0394651c9 Document count-objects pack
     @@ Metadata
       ## Commit message ##
          Document count-objects pack
      
     -    Juno added the printing of "packs" with ae72f685418b.
     -    When 0bdaa1216 refactored the docs for the -v option, this was missed.
     +    0bdaa12169b (git-count-objects.txt: describe each line in -v output,
     +    2013-02-08) forgot to include `packs`.
      
          Signed-off-by: Daniele Sassoli <danielesassoli@gmail.com>

 Documentation/git-count-objects.adoc | 2 ++
 1 file changed, 2 insertions(+)

Show changes to Documentation/git-count-objects.adoc +2 −0

diff --git a/Documentation/git-count-objects.adoc b/Documentation/git-count-objects.adoc
index 97f9f126101..eeee6b9f7f4 100644
--- a/Documentation/git-count-objects.adoc
+++ b/Documentation/git-count-objects.adoc
@@ -28,6 +28,8 @@ size: disk space consumed by loose objects, in KiB (unless -H is specified)
 +
 in-pack: the number of in-pack objects
 +
+packs: the number of pack files
++
 size-pack: disk space consumed by the packs, in KiB (unless -H is specified)
 +
 prune-packable: the number of loose objects that are also present in

base-commit: 2c2ba49d55ff26c1082b8137b1ec5eeccb4337d1

-- 
gitgitgadget

Kristoffer Haugsbakk· Aug 14, 2025, 13:46 UTC · re: Daniele Sassoli via GitGitGadget · lore

Re: [PATCH v2] Document count-objects pack

On Thu, Aug 14, 2025, at 15:16, Daniele Sassoli via GitGitGadget wrote:

Show 8 quoted lines

> From: Daniele Sassoli <danielesassoli@gmail.com>
>
> 0bdaa12169b (git-count-objects.txt: describe each line in -v output,
> 2013-02-08) forgot to include `packs`.
>
> Signed-off-by: Daniele Sassoli <danielesassoli@gmail.com>
> ---
>     Document count-objects -v - packs output

I’m very sorry that I missed this the first time around before you sent out this new version... but also the subject line

    Document count-objects -v - packs output

Should start with a lowercase “area” like e.g.

    doc: count-objects: ...

Or:

    count-objects: ...

Or some other variation (see `git log --oneline --follow Documentation/git-count-objects.adoc`).

-- 
Kristoffer Haugsbakk

Daniele Sassoli via GitGitGadget· Aug 14, 2025, 14:33 UTC · re: Daniele Sassoli via GitGitGadget · lore

[PATCH v3] count-objects: document count-objects pack

From: Daniele Sassoli <danielesassoli@gmail.com>

0bdaa12169b (git-count-objects.txt: describe each line in -v output, 2013-02-08) forgot to include `packs`.

Signed-off-by: Daniele Sassoli <danielesassoli@gmail.com>
---
    Document count-objects -v - packs output
    
    https://github.com/DanieleSassoli/git/commit/0bdaa12169bca5d69f2c58f96cc92d51280e9e26
    (git-count-objects.txt: describe each line in -v output, 2013-02-08)
    forgot to include packs.

Published-As: https://github.com/gitgitgadget/git/releases/tag/pr-git-2031%2FDanieleSassoli%2Fmaster-v3
Fetch-It-Via: git fetch https://github.com/gitgitgadget/git pr-git-2031/DanieleSassoli/master-v3
Pull-Request: https://github.com/git/git/pull/2031

Range-diff vs v2:

 1:  6f0394651c9 ! 1:  ab90af2b6a0 Document count-objects pack
     @@ Metadata
      Author: Daniele Sassoli <danielesassoli@gmail.com>
      
       ## Commit message ##
     -    Document count-objects pack
     +    count-objects: document count-objects pack
      
          0bdaa12169b (git-count-objects.txt: describe each line in -v output,
          2013-02-08) forgot to include `packs`.

 Documentation/git-count-objects.adoc | 2 ++
 1 file changed, 2 insertions(+)

Show changes to Documentation/git-count-objects.adoc +2 −0

diff --git a/Documentation/git-count-objects.adoc b/Documentation/git-count-objects.adoc
index 97f9f126101..eeee6b9f7f4 100644
--- a/Documentation/git-count-objects.adoc
+++ b/Documentation/git-count-objects.adoc
@@ -28,6 +28,8 @@ size: disk space consumed by loose objects, in KiB (unless -H is specified)
 +
 in-pack: the number of in-pack objects
 +
+packs: the number of pack files
++
 size-pack: disk space consumed by the packs, in KiB (unless -H is specified)
 +
 prune-packable: the number of loose objects that are also present in

base-commit: 2c2ba49d55ff26c1082b8137b1ec5eeccb4337d1

-- 
gitgitgadget

Junio C Hamano· Aug 14, 2025, 21:40 UTC · re: Daniele Sassoli via GitGitGadget · lore

Re: [PATCH v3] count-objects: document count-objects pack

"Daniele Sassoli via GitGitGadget" <gitgitgadget@gmail.com> writes:

Show 22 quoted lines

> From: Daniele Sassoli <danielesassoli@gmail.com>
>
> 0bdaa12169b (git-count-objects.txt: describe each line in -v output,
> 2013-02-08) forgot to include `packs`.
>
> Signed-off-by: Daniele Sassoli <danielesassoli@gmail.com>
> ---
> diff --git a/Documentation/git-count-objects.adoc b/Documentation/git-count-objects.adoc
> index 97f9f126101..eeee6b9f7f4 100644
> --- a/Documentation/git-count-objects.adoc
> +++ b/Documentation/git-count-objects.adoc
> @@ -28,6 +28,8 @@ size: disk space consumed by loose objects, in KiB (unless -H is specified)
>  +
>  in-pack: the number of in-pack objects
>  +
> +packs: the number of pack files
> ++
>  size-pack: disk space consumed by the packs, in KiB (unless -H is specified)
>  +
>  prune-packable: the number of loose objects that are also present in
>
> base-commit: 2c2ba49d55ff26c1082b8137b1ec5eeccb4337d1

Looks good.  Thanks.  Will queue.