threads / patch / 63935

patchmerge: don't document non-existing --compact-summary argument

Subject: [PATCH] merge: don't document non-existing --compact-summary argument

## tl;dr

2 messages between Aug 9, 2025 and Aug 10, 2025. Diffs are folded; open one to read it.

replies: 1people: 2as markdown or json

René Scharfe· Aug 9, 2025, 10:00 UTC · lore

3a54f5bd5d (merge/pull: add the "--compact-summary" option, 2025-06-12) added the option --compact-summary to both merge and pull. It takes no no argument, but for merge it got an argument help string. Remove it, since it is unnecessary.

Signed-off-by: René Scharfe <l.s.r@web.de>
---
 builtin/merge.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Show changes to builtin/merge.c +1 −1

diff --git a/builtin/merge.c b/builtin/merge.c
index dc4cb8fb14..ce880e6ccb 100644
--- a/builtin/merge.c
+++ b/builtin/merge.c
@@ -264,7 +264,7 @@ static struct option builtin_merge_options[] = {
 	OPT_BOOL(0, "stat", &show_diffstat,
 		N_("show a diffstat at the end of the merge")),
 	OPT_BOOL(0, "summary", &show_diffstat, N_("(synonym to --stat)")),
-	OPT_CALLBACK_F(0, "compact-summary", &show_diffstat, N_("compact-summary"),
+	OPT_CALLBACK_F(0, "compact-summary", &show_diffstat, NULL,
 		       N_("show a compact-summary at the end of the merge"),
 		       PARSE_OPT_NOARG,
 		       option_parse_compact_summary),

-- 
2.50.1

Junio C Hamano· Aug 10, 2025, 00:07 UTC · re: René Scharfe · lore

Re: [PATCH] merge: don't document non-existing --compact-summary argument

René Scharfe <l.s.r@web.de> writes:

> 3a54f5bd5d (merge/pull: add the "--compact-summary" option, 2025-06-12)
> added the option --compact-summary to both merge and pull.  It takes no
> no argument, but for merge it got an argument help string.  Remove it,
> since it is unnecessary.

Thanks.

Show 19 quoted lines

>
> Signed-off-by: René Scharfe <l.s.r@web.de>
> ---
>  builtin/merge.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/builtin/merge.c b/builtin/merge.c
> index dc4cb8fb14..ce880e6ccb 100644
> --- a/builtin/merge.c
> +++ b/builtin/merge.c
> @@ -264,7 +264,7 @@ static struct option builtin_merge_options[] = {
>  	OPT_BOOL(0, "stat", &show_diffstat,
>  		N_("show a diffstat at the end of the merge")),
>  	OPT_BOOL(0, "summary", &show_diffstat, N_("(synonym to --stat)")),
> -	OPT_CALLBACK_F(0, "compact-summary", &show_diffstat, N_("compact-summary"),
> +	OPT_CALLBACK_F(0, "compact-summary", &show_diffstat, NULL,
>  		       N_("show a compact-summary at the end of the merge"),
>  		       PARSE_OPT_NOARG,
>  		       option_parse_compact_summary),