# [PATCH] CodingGuidelines: let BSS do its job 2 messages from 2025-06-11 to 2025-06-12. Participants: Junio C Hamano, Christian Couder. Thread: https://gitlist.dev/t/63627 ## Junio C Hamano, 2025-06-11 21:16 Subject: [PATCH] CodingGuidelines: let BSS do its job Message-ID: URL: https://gitlist.dev/e/xmqqh60mger9.fsf%40gitster.g ``` We have mentioned this in various reviews, but I didn't see it mentioned in the CodingGuildelines document. Let's add it. Signed-off-by: Junio C Hamano --- Documentation/CodingGuidelines | 3 +++ 1 file changed, 3 insertions(+) diff --git a/Documentation/CodingGuidelines b/Documentation/CodingGuidelines index a0e7041c54..4d1d52aa37 100644 --- a/Documentation/CodingGuidelines +++ b/Documentation/CodingGuidelines @@ -315,6 +315,9 @@ For C programs: encouraged to have a blank line between the end of the declarations and the first statement in the block. + - Do not explicitly initialize global variables to 0 or NULL; + instead, let BSS take care of the zero initialization. + - NULL pointers shall be written as NULL, not as 0. - When declaring pointers, the star sides with the variable -- 2.50.0-rc2-207-gc448ca4963 ``` ## Christian Couder, 2025-06-12 07:40 Subject: Re: [PATCH] CodingGuidelines: let BSS do its job Message-ID: URL: https://gitlist.dev/e/CAP8UFD34VpH7qQb2HwVR-YqcBbM6-Mo6ivdhcgN_DbLi0LT3zg%40mail.gmail.com In-Reply-To: ``` On Wed, Jun 11, 2025 at 11:18 PM Junio C Hamano wrote: > > We have mentioned this in various reviews, but I didn't see it > mentioned in the CodingGuildelines document. Let's add it. Yeah, thanks for maintaining this document! > Signed-off-by: Junio C Hamano > --- > Documentation/CodingGuidelines | 3 +++ > 1 file changed, 3 insertions(+) > > diff --git a/Documentation/CodingGuidelines b/Documentation/CodingGuidelines > index a0e7041c54..4d1d52aa37 100644 > --- a/Documentation/CodingGuidelines > +++ b/Documentation/CodingGuidelines > @@ -315,6 +315,9 @@ For C programs: > encouraged to have a blank line between the end of the declarations > and the first statement in the block. > > + - Do not explicitly initialize global variables to 0 or NULL; > + instead, let BSS take care of the zero initialization. Looks good. ```