# [PATCH] config.mak.uname: update settings for Solaris 10 and 11 2 messages from 2025-06-08 to 2025-06-08. Participants: Brad Smith, Collin Funk. Thread: https://gitlist.dev/t/63601 ## Brad Smith, 2025-06-08 01:26 Subject: [PATCH] config.mak.uname: update settings for Solaris 10 and 11 Message-ID: URL: https://gitlist.dev/e/aETm3O-FE7EpyoE5%40humpty.home.comstyle.com ``` Solaris 10 and newer has strtoumax(). Solaris 11 and newer has mkdtemp(), memmem(), and strcasestr(). Signed-off-by: Brad Smith --- config.mak.uname | 28 +++++++++++++++++++++++++--- 1 file changed, 25 insertions(+), 3 deletions(-) diff --git a/config.mak.uname b/config.mak.uname index 3e26bb074a..b1c5c4d5e8 100644 --- a/config.mak.uname +++ b/config.mak.uname @@ -190,9 +190,6 @@ ifeq ($(uname_S),SunOS) SHELL_PATH = /bin/bash SANE_TOOL_PATH = /usr/xpg6/bin:/usr/xpg4/bin HAVE_ALLOCA_H = YesPlease - NO_STRCASESTR = YesPlease - NO_MEMMEM = YesPlease - NO_MKDTEMP = YesPlease NO_REGEX = YesPlease NO_MSGFMT_EXTENDED_OPTIONS = YesPlease HAVE_DEV_TTY = YesPlease @@ -202,7 +199,10 @@ ifeq ($(uname_S),SunOS) NO_IPV6 = YesPlease NO_SOCKADDR_STORAGE = YesPlease NO_UNSETENV = YesPlease + NO_MKDTEMP = YesPlease + NO_MEMMEM = YesPlease NO_SETENV = YesPlease + NO_STRCASESTR = YesPlease NO_STRLCPY = YesPlease NO_STRTOUMAX = YesPlease GIT_TEST_CMP = cmp @@ -212,23 +212,45 @@ ifeq ($(uname_S),SunOS) NO_IPV6 = YesPlease NO_SOCKADDR_STORAGE = YesPlease NO_UNSETENV = YesPlease + NO_MKDTEMP = YesPlease + NO_MEMMEM = YesPlease NO_SETENV = YesPlease + NO_STRCASESTR = YesPlease NO_STRLCPY = YesPlease NO_STRTOUMAX = YesPlease GIT_TEST_CMP = cmp endif ifeq ($(uname_R),5.8) NO_UNSETENV = YesPlease + NO_MKDTEMP = YesPlease + NO_MEMMEM = YesPlease NO_SETENV = YesPlease + NO_STRCASESTR = YesPlease NO_STRTOUMAX = YesPlease GIT_TEST_CMP = cmp endif ifeq ($(uname_R),5.9) NO_UNSETENV = YesPlease + NO_MKDTEMP = YesPlease + NO_MEMMEM = YesPlease NO_SETENV = YesPlease + NO_STRCASESTR = YesPlease NO_STRTOUMAX = YesPlease GIT_TEST_CMP = cmp endif + ifeq ($(uname_R),5.10) + NO_UNSETENV = YesPlease + NO_MKDTEMP = YesPlease + NO_MEMMEM = YesPlease + NO_SETENV = YesPlease + NO_STRCASESTR = YesPlease + GIT_TEST_CMP = cmp + endif + ifeq ($(uname_R),5.11) + NO_UNSETENV = YesPlease + NO_SETENV = YesPlease + GIT_TEST_CMP = cmp + endif INSTALL = /usr/ucb/install TAR = gtar BASIC_CFLAGS += -D__EXTENSIONS__ -D__sun__ -- 2.49.0 ``` ## Collin Funk, 2025-06-08 01:46 Subject: Re: [PATCH] config.mak.uname: update settings for Solaris 10 and 11 Message-ID: <87cybfhuow.fsf@gmail.com> URL: https://gitlist.dev/e/87cybfhuow.fsf%40gmail.com In-Reply-To: ``` Brad Smith writes: > Solaris 10 and newer has strtoumax(). > > Solaris 11 and newer has mkdtemp(), memmem(), and strcasestr(). > > Signed-off-by: Brad Smith > --- > config.mak.uname | 28 +++++++++++++++++++++++++--- > 1 file changed, 25 insertions(+), 3 deletions(-) These versions look correct based on what we have documented in Gnulib. Just to be safe I built git with this patch applied on Solaris 10 and Solaris 11.3 and ran into no issues. Reviewed-by: Collin Funk Tested-by: Collin Funk Thanks, Collin ```