# [PATCH] doc: column: fix blank lines before block delimiters 4 messages from 2025-05-31 to 2025-06-01. Participants: kristofferhaugsbakk@fastmail.com, Jean-Noël AVILA, Kristoffer Haugsbakk. Thread: https://gitlist.dev/t/63554 ## kristofferhaugsbakk@fastmail.com, 2025-05-31 21:08 Subject: [PATCH] doc: column: fix blank lines before block delimiters Message-ID: URL: https://gitlist.dev/e/b493b07f88bc5562e03c249006f01091afd7b5fd.1748725662.git.code%40khaugsbakk.name ``` From: Kristoffer Haugsbakk 227c4f33a03 (doc: add a blank line around block delimiters, 2025-03-09) added blank lines around block delimiters as a defensive measure. For each block you had to mind the con- text (like the commit says): • Top-level: just add blank lines • Block: use list continuation (+) But list continuation was used here at the top level, which results in literal `+` in the output formats. Signed-off-by: Kristoffer Haugsbakk --- Documentation/git-column.adoc | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/Documentation/git-column.adoc b/Documentation/git-column.adoc index 5a4f2b6fde9..8e0047214dc 100644 --- a/Documentation/git-column.adoc +++ b/Documentation/git-column.adoc @@ -50,7 +50,7 @@ EXAMPLES -------- Format data by columns: -+ + ------------ $ seq 1 24 | git column --mode=column --padding=5 1 4 7 10 13 16 19 22 @@ -59,7 +59,7 @@ $ seq 1 24 | git column --mode=column --padding=5 ------------ Format data by rows: -+ + ------------ $ seq 1 21 | git column --mode=row --padding=5 1 2 3 4 5 6 7 @@ -68,7 +68,7 @@ $ seq 1 21 | git column --mode=row --padding=5 ------------ List some tags in a table with unequal column widths: -+ + ------------ $ git tag --list 'v2.4.*' --column=row,dense v2.4.0 v2.4.0-rc0 v2.4.0-rc1 v2.4.0-rc2 v2.4.0-rc3 base-commit: 7014b55638da979331baf8dc31c4e1d697cf2d67 -- 2.50.0.rc0.46.g7014b55638d ``` ## Jean-Noël AVILA, 2025-05-31 21:46 Subject: Re: [PATCH] doc: column: fix blank lines before block delimiters Message-ID: <5891508.DvuYhMxLoT@cayenne> URL: https://gitlist.dev/e/5891508.DvuYhMxLoT%40cayenne In-Reply-To: ``` On Saturday, 31 May 2025 23:08:09 CEST kristofferhaugsbakk@fastmail.com wrote: > From: Kristoffer Haugsbakk > > 227c4f33a03 (doc: add a blank line around block delimiters, > 2025-03-09) added blank lines around block delimiters as a > defensive measure. For each block you had to mind the con- > text (like the commit says): > > • Top-level: just add blank lines > • Block: use list continuation (+) > > But list continuation was used here at the top level, which > results in literal `+` in the output formats. > > Signed-off-by: Kristoffer Haugsbakk > --- > Documentation/git-column.adoc | 6 +++--- > 1 file changed, 3 insertions(+), 3 deletions(-) > > diff --git a/Documentation/git-column.adoc b/Documentation/git-column.adoc > index 5a4f2b6fde9..8e0047214dc 100644 > --- a/Documentation/git-column.adoc > +++ b/Documentation/git-column.adoc > @@ -50,7 +50,7 @@ EXAMPLES > -------- > > Format data by columns: > -+ > + > ------------ > $ seq 1 24 | git column --mode=column --padding=5 > 1 4 7 10 13 16 19 22 > @@ -59,7 +59,7 @@ $ seq 1 24 | git column --mode=column --padding=5 > ------------ > > Format data by rows: > -+ > + > ------------ > $ seq 1 21 | git column --mode=row --padding=5 > 1 2 3 4 5 6 7 > @@ -68,7 +68,7 @@ $ seq 1 21 | git column --mode=row --padding=5 > ------------ > > List some tags in a table with unequal column widths: > -+ > + > ------------ > $ git tag --list 'v2.4.*' --column=row,dense > v2.4.0 v2.4.0-rc0 v2.4.0-rc1 v2.4.0-rc2 v2.4.0-rc3 > > base-commit: 7014b55638da979331baf8dc31c4e1d697cf2d67 Acked-by: Jean-Noël Avila ``` ## Kristoffer Haugsbakk, 2025-05-31 22:49 Subject: Re: [PATCH] doc: column: fix blank lines before block delimiters Message-ID: <212bce25-e8dc-42dd-a70a-573f09b1f74a@app.fastmail.com> URL: https://gitlist.dev/e/212bce25-e8dc-42dd-a70a-573f09b1f74a%40app.fastmail.com In-Reply-To: ``` > doc: column: fix blank lines before block delimiters “before” is technically correct since these changes happen to only be before the blocks. But maybe it should be “around” in order to be stay consistent with the commit message. I’ll go for that. ``` ## kristofferhaugsbakk@fastmail.com, 2025-06-01 11:36 Subject: [PATCH v2] doc: column: fix blank lines around block delimiters Message-ID: <3c6d7b154048ef0053d15b4f86cc241211ef30dc.1748777208.git.code@khaugsbakk.name> URL: https://gitlist.dev/e/3c6d7b154048ef0053d15b4f86cc241211ef30dc.1748777208.git.code%40khaugsbakk.name In-Reply-To: ``` From: Kristoffer Haugsbakk 227c4f33a03 (doc: add a blank line around block delimiters, 2025-03-09) added blank lines around block delimiters as a defensive measure. For each block you had to mind the con- text (like the commit says): • Top-level: just add blank lines • Block: use list continuation (+) But list continuation was used here at the top level, which results in literal `+` in the output formats. Acked-by: Jean-Noël Avila Signed-off-by: Kristoffer Haugsbakk --- Notes (series): v2: • Finally trying the “After the list reached a consensus” step of SubmittingPatches • Add Ack • Use “around” consistently in subject and message Documentation/git-column.adoc | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/Documentation/git-column.adoc b/Documentation/git-column.adoc index 5a4f2b6fde9..8e0047214dc 100644 --- a/Documentation/git-column.adoc +++ b/Documentation/git-column.adoc @@ -50,7 +50,7 @@ EXAMPLES -------- Format data by columns: -+ + ------------ $ seq 1 24 | git column --mode=column --padding=5 1 4 7 10 13 16 19 22 @@ -59,7 +59,7 @@ $ seq 1 24 | git column --mode=column --padding=5 ------------ Format data by rows: -+ + ------------ $ seq 1 21 | git column --mode=row --padding=5 1 2 3 4 5 6 7 @@ -68,7 +68,7 @@ $ seq 1 21 | git column --mode=row --padding=5 ------------ List some tags in a table with unequal column widths: -+ + ------------ $ git tag --list 'v2.4.*' --column=row,dense v2.4.0 v2.4.0-rc0 v2.4.0-rc1 v2.4.0-rc2 v2.4.0-rc3 Range-diff against v1: 1: b493b07f88b ! 1: 3c6d7b15404 doc: column: fix blank lines before block delimiters @@ Metadata Author: Kristoffer Haugsbakk ## Commit message ## - doc: column: fix blank lines before block delimiters + doc: column: fix blank lines around block delimiters 227c4f33a03 (doc: add a blank line around block delimiters, 2025-03-09) added blank lines around block delimiters as a @@ Commit message But list continuation was used here at the top level, which results in literal `+` in the output formats. + Acked-by: Jean-Noël Avila Signed-off-by: Kristoffer Haugsbakk ## Documentation/git-column.adoc ## base-commit: 7014b55638da979331baf8dc31c4e1d697cf2d67 -- 2.50.0.rc0.47.g3c6d7b15404.dirty ```