# [PATCH] t/meson.build: remove deleted performance test script 4 messages from 2025-04-18 to 2025-04-18. Participants: Ramsay Jones, Junio C Hamano. Thread: https://gitlist.dev/t/63310 ## Ramsay Jones, 2025-04-18 16:59 Subject: [PATCH] t/meson.build: remove deleted performance test script Message-ID: <67c50fde-d29c-404b-a296-9f0e482acaf3@ramsayjones.plus.com> URL: https://gitlist.dev/e/67c50fde-d29c-404b-a296-9f0e482acaf3%40ramsayjones.plus.com ``` Commit 8b0b5c7046 (p5312: removed duplicate performance test script, 2025-04-17) removed the 't/perf/p5312-pack-bitmaps-revs.sh' script, but forgot to remove it from 't/meson.build', resulting in a broken build. In order to fix the build, remove the script from 't/meson.build'. Signed-off-by: Ramsay Jones --- Hi Taylor, Junio, If you need to re-roll the 'tb/pack-bitmap-lookup-tables' branch, could you please squash this into commit 8b0b5c7046. (the meson build on the current 'seen' branch is broken otherwise). Thanks! ATB, Ramsay Jones t/meson.build | 1 - 1 file changed, 1 deletion(-) diff --git a/t/meson.build b/t/meson.build index 6eeb10d616..97e6d62228 100644 --- a/t/meson.build +++ b/t/meson.build @@ -1132,7 +1132,6 @@ benchmarks = [ 'perf/p5304-prune.sh', 'perf/p5310-pack-bitmaps.sh', 'perf/p5311-pack-bitmaps-fetch.sh', - 'perf/p5312-pack-bitmaps-revs.sh', 'perf/p5313-pack-objects.sh', 'perf/p5314-name-hash.sh', 'perf/p5326-multi-pack-bitmaps.sh', -- 2.49.0 ``` ## Junio C Hamano, 2025-04-18 17:40 Subject: Re: [PATCH] t/meson.build: remove deleted performance test script Message-ID: URL: https://gitlist.dev/e/xmqqmscdbc6g.fsf%40gitster.g In-Reply-To: <67c50fde-d29c-404b-a296-9f0e482acaf3@ramsayjones.plus.com> ``` Ramsay Jones writes: > Commit 8b0b5c7046 (p5312: removed duplicate performance test script, > 2025-04-17) removed the 't/perf/p5312-pack-bitmaps-revs.sh' script, but > forgot to remove it from 't/meson.build', resulting in a broken build. > > In order to fix the build, remove the script from 't/meson.build'. Thanks. > Signed-off-by: Ramsay Jones > --- > > Hi Taylor, Junio, > > If you need to re-roll the 'tb/pack-bitmap-lookup-tables' branch, could > you please squash this into commit 8b0b5c7046. (the meson build on the > current 'seen' branch is broken otherwise). Unless the topic by Tayor gets rebased on top of what contains ps/meson-build-perf-bench, which is not even in 'next' (hence I wouldn't recommend doing such a rebase), this needs to be dealt with as an evil-merge semantic conflict fix-up, which I did this morning and pushed the result out. ``` ## Ramsay Jones, 2025-04-18 18:52 Subject: Re: [PATCH] t/meson.build: remove deleted performance test script Message-ID: <4b2fdfd0-72da-4c36-8b8a-4ef514873d39@ramsayjones.plus.com> URL: https://gitlist.dev/e/4b2fdfd0-72da-4c36-8b8a-4ef514873d39%40ramsayjones.plus.com In-Reply-To: ``` On 18/04/2025 18:40, Junio C Hamano wrote: > Ramsay Jones writes: > >> Commit 8b0b5c7046 (p5312: removed duplicate performance test script, >> 2025-04-17) removed the 't/perf/p5312-pack-bitmaps-revs.sh' script, but >> forgot to remove it from 't/meson.build', resulting in a broken build. >> >> In order to fix the build, remove the script from 't/meson.build'. > > Thanks. > > >> Signed-off-by: Ramsay Jones >> --- >> >> Hi Taylor, Junio, >> >> If you need to re-roll the 'tb/pack-bitmap-lookup-tables' branch, could >> you please squash this into commit 8b0b5c7046. (the meson build on the >> current 'seen' branch is broken otherwise). > > Unless the topic by Tayor gets rebased on top of what contains > ps/meson-build-perf-bench, which is not even in 'next' (hence I > wouldn't recommend doing such a rebase), this needs to be dealt with > as an evil-merge semantic conflict fix-up, which I did this morning > and pushed the result out. Ah, yes, I just fetched and found your fixup (which you did hours ago!). Sorry for the noise. Thanks. ATB, Ramsay Jones ``` ## Junio C Hamano, 2025-04-18 19:51 Subject: Re: [PATCH] t/meson.build: remove deleted performance test script Message-ID: URL: https://gitlist.dev/e/xmqqbjstb64q.fsf%40gitster.g In-Reply-To: <4b2fdfd0-72da-4c36-8b8a-4ef514873d39@ramsayjones.plus.com> ``` Ramsay Jones writes: >>> If you need to re-roll the 'tb/pack-bitmap-lookup-tables' branch, could >>> you please squash this into commit 8b0b5c7046. (the meson build on the >>> current 'seen' branch is broken otherwise). >> >> Unless the topic by Tayor gets rebased on top of what contains >> ps/meson-build-perf-bench, which is not even in 'next' (hence I >> wouldn't recommend doing such a rebase), this needs to be dealt with >> as an evil-merge semantic conflict fix-up, which I did this morning >> and pushed the result out. > > Ah, yes, I just fetched and found your fixup (which you did hours ago!). > Sorry for the noise. I very much appreciate your being on the lookout for any breakages. Thanks. ```