# Request reverting some from git-pb 1 messages from 2005-05-15 to 2005-05-15. Participants: Junio C Hamano. Thread: https://gitlist.dev/t/630 ## Junio C Hamano, 2005-05-15 18:25 Subject: Request reverting some from git-pb Message-ID: <7vy8agtkht.fsf@assigned-by-dhcp.cox.net> URL: https://gitlist.dev/e/7vy8agtkht.fsf%40assigned-by-dhcp.cox.net ``` Petr, please do not do these name clean-ups yet, _especially_ without having GIT mailing list discussion about renaming. This kind of change inevitably introduces merge conflicts. I suspect this is something you lifted from the larger libification patch. While I think name cleanups are good in the long run, I do not see value in lifting only some name cleanups from a larger libification patch and having people to adjust for the merge conflicts twice. I would not mind if these renames happen as a part of libification as a whole. Pending patches need to be inspected and adjusted when that happens anyway. But not until then, at least please have a courtecy to give people a bit of warning and an opportunity to speak out. ------------------------------------------------ Rename some more cache-related functions same_name -> ce_same_name() remove_entry_at() -> remove_cache_entry_at() Signed-off-by: Brad Roberts Signed-off-by: Petr Baudis ------------------------------------------------ Rename cache_match_stat() to ce_match_stat() Signed-off-by: Brad Roberts Signed-off-by: Petr Baudis ------------------------------------------------ Rename cache_match_stat() to ce_match_stat() Signed-off-by: Brad Roberts Signed-off-by: Petr Baudis ------------------------------------------------ ```