threads / patch / 62995

patcht/aggregate-results: fix paste(1) invocation

Subject: [PATCH] t/aggregate-results: fix paste(1) invocation

## tl;dr

One message between Feb 24, 2025 and Feb 24, 2025. Diffs are folded; open one to read it.

replies: 0people: 1as markdown or json

D. Ben Knoble· Feb 24, 2025, 19:26 UTC · lore
When running `make test`, when missing prereqs the following is emitted:
    make aggregate-results
    usage: paste [-s] [-d delimiters] file ...
    fixed   1
    success 30066
    failed  0
    broken  218
    total   31274

POSIX says that `paste` requires a file operand; stdin was clearly intended by 49da404070 (test-lib: show missing prereq summary, 2021-11-20). Use it.

Signed-off-by: D. Ben Knoble <ben.knoble+github@gmail.com>
---

The test results are from a real run but on an as-yet-unpublished commit. Not sure if worth keeping that part of the message, so feel free to only keep the "make" and "usage" lines when applying?

 t/aggregate-results.sh | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
Show changes to t/aggregate-results.sh +1 −1
diff --git a/t/aggregate-results.sh b/t/aggregate-results.sh
index 6e3bcc4aec..6cb0ff11de 100755
--- a/t/aggregate-results.sh
+++ b/t/aggregate-results.sh
@@ -44,7 +44,7 @@
 		tr -s "," "\n" |
 		grep -v '^$' |
 		sort -u |
-		paste -s -d ' ')
+		paste -s -d ' ' -)
 	if test -n "$unique_missing_prereq"
 	then
 		printf "\nmissing prereq: $unique_missing_prereq\n\n"
-- 
2.48.1

← back to recent threads