# [GSoC][Newbie] Test Script Enhancements

2 messages from 2025-01-05 to 2025-01-05. Participants: Rhythm Narula, Eric Sunshine.
Thread: https://gitlist.dev/t/62739

## Rhythm Narula, 2025-01-05 09:39

Subject: [GSoC][Newbie] Test Script Enhancements
Message-ID: <CAKz1=ZOY7GziF9DNTLXv=G+OX8_vAbvOYS4L2s-D2C3kpr-zOg@mail.gmail.com>
URL: https://gitlist.dev/e/CAKz1%3DZOY7GziF9DNTLXv%3DG%2BOX8_vAbvOYS4L2s-D2C3kpr-zOg%40mail.gmail.com

```
Hi Everyone,
My name is Rhythm Narula and I am currently working as a Software
Engineer. I had the privilege of participating in GSoC 2023 with
Pitivi, GNOME, where I completed a project on generating closing
credit clips. LinkedIn -
https://www.linkedin.com/in/rhythm-narula-34b652191/

As someone who uses Git daily for version control and collaboration, I
have developed a strong interest in understanding its internals and
contributing to its improvement, allowing me to impact millions of
developers worldwide.

I understand that GSoC 2025 mini project ideas have not yet been
released, however, I have been exploring 2024 mini project ideas and
noticed a few areas where improvements might still be possible. I have
outlined these below and world appreciate your feedback on whether
these are accurate and worth pursuing:

1. Avoid suppressing git’s exit code in test scripts
a.  diff --git a/t/t5801-remote-helpers.sh b/t/t5801-remote-helpers.sh
index d21877150e..3433fcfc44 100755
--- a/t/t5801-remote-helpers.sh
+++ b/t/t5801-remote-helpers.sh
@@ -271,7 +271,7 @@ test_expect_success 'push update refs failure' '

 clean_mark () {
        cut -f 2 -d ' ' "$1" |
-       git cat-file --batch-check |
+       git cat-file --batch-check >actual &&
        grep commit |
        sort >$(basename "$1")
 }

2. Modernize a test script
Is there anyone working on t/t5801-remote-helpers.sh? Can I take this up?

Regards,
Rhythm

```

## Eric Sunshine, 2025-01-05 09:51

Subject: Re: [GSoC][Newbie] Test Script Enhancements
Message-ID: <CAPig+cTjK3_jme88H8D5AiXAoGc+Donu0tgBGYcS2F-KQ0Kfaw@mail.gmail.com>
URL: https://gitlist.dev/e/CAPig%2BcTjK3_jme88H8D5AiXAoGc%2BDonu0tgBGYcS2F-KQ0Kfaw%40mail.gmail.com
In-Reply-To: <CAKz1=ZOY7GziF9DNTLXv=G+OX8_vAbvOYS4L2s-D2C3kpr-zOg@mail.gmail.com>

```
On Sun, Jan 5, 2025 at 4:39 AM Rhythm Narula <rhythm.narula26@gmail.com> wrote:
> 1. Avoid suppressing git’s exit code in test scripts
> a.  diff --git a/t/t5801-remote-helpers.sh b/t/t5801-remote-helpers.sh
> @@ -271,7 +271,7 @@ test_expect_success 'push update refs failure' '
>  clean_mark () {
>         cut -f 2 -d ' ' "$1" |
> -       git cat-file --batch-check |
> +       git cat-file --batch-check >actual &&
>         grep commit |
>         sort >$(basename "$1")
>  }

At a quick glance, I'd say that this change is incomplete and won't
work as you expect.

> 2. Modernize a test script
> Is there anyone working on t/t5801-remote-helpers.sh? Can I take this up?

No need to ask before working on something in Git. You're free to pick
any modernization. A good way to check if anyone is touching this
particular script is to search the mail archive[*] for recent mentions
of "t5801".

[*]: https://lore.kernel.org/git/

```