# git-log --format missing trailing newline character 7 messages from 2024-12-23 to 2024-12-26. Participants: Alejandro Colomar, Kristoffer Haugsbakk, Andreas Schwab, Junio C Hamano. Thread: https://gitlist.dev/t/62689 ## Alejandro Colomar, 2024-12-23 20:28 Subject: git-log --format missing trailing newline character Message-ID: URL: https://gitlist.dev/e/cw7vyas4yw2q4lqiskbvil7mpkx5l5qilj25vnqzkrp5nuezrx%40d6tsavm3ajzw ``` Hi! I'm having trouble scripting around git-log(1), due to a missing newline character at the end of the file. $ git -v git version 2.45.2 $ git log --format=format:'%H' HEAD^^^..HEAD | wc -l 2 $ git log --format=format:'%H' HEAD^^^..HEAD 2ff431ab1b46a25088fe40baf1faf35ea9fac722 e75e6c4504022ae52d877926e63c908d9572088a 178442837d39560a789a8044a8eb90fde3ad7cd7 Would you mind fixing this bug? POSIX requires that text files end in a newline character, precisely for being able to use UNIX tools to process output from arbitrary commands. Have a lovely night! Alex -- ``` ## Kristoffer Haugsbakk, 2024-12-23 20:36 Subject: Re: git-log --format missing trailing newline character Message-ID: URL: https://gitlist.dev/e/d813a3dd-68c2-4cbe-92a0-cfd1ece77e9b%40app.fastmail.com In-Reply-To: ``` On Mon, Dec 23, 2024, at 21:28, Alejandro Colomar wrote: > Hi! > > I'm having trouble scripting around git-log(1), due to a missing newline > character at the end of the file. > > $ git -v > git version 2.45.2 > $ git log --format=format:'%H' HEAD^^^..HEAD | wc -l > 2 > $ git log --format=format:'%H' HEAD^^^..HEAD > 2ff431ab1b46a25088fe40baf1faf35ea9fac722 > e75e6c4504022ae52d877926e63c908d9572088a > 178442837d39560a789a8044a8eb90fde3ad7cd7 > > Would you mind fixing this bug? POSIX requires that text files end in a > newline character, precisely for being able to use UNIX tools to process > output from arbitrary commands. Is the format here simplified relative to your use case? Or do you just want to process commits as one-hash-per-line? I would use git-rev-list(1) instead in that case. -- Kristoffer Haugsbakk ``` ## Alejandro Colomar, 2024-12-23 20:49 Subject: Re: git-log --format missing trailing newline character Message-ID: <5aib7c6x5m6e4muutjuoqp3f4lvpeh3hz5qkwpayi2usm7b6yi@af2oucx5j4w5> URL: https://gitlist.dev/e/5aib7c6x5m6e4muutjuoqp3f4lvpeh3hz5qkwpayi2usm7b6yi%40af2oucx5j4w5 In-Reply-To: ``` Hi Kristoffer, On Mon, Dec 23, 2024 at 09:36:48PM GMT, Kristoffer Haugsbakk wrote: > On Mon, Dec 23, 2024, at 21:28, Alejandro Colomar wrote: > > Hi! > > > > I'm having trouble scripting around git-log(1), due to a missing newline > > character at the end of the file. > > > > $ git -v > > git version 2.45.2 > > $ git log --format=format:'%H' HEAD^^^..HEAD | wc -l > > 2 > > $ git log --format=format:'%H' HEAD^^^..HEAD > > 2ff431ab1b46a25088fe40baf1faf35ea9fac722 > > e75e6c4504022ae52d877926e63c908d9572088a > > 178442837d39560a789a8044a8eb90fde3ad7cd7 > > > > Would you mind fixing this bug? POSIX requires that text files end in a > > newline character, precisely for being able to use UNIX tools to process > > output from arbitrary commands. > > Is the format here simplified relative to your use case? Or do you just > want to process commits as one-hash-per-line? I want to process commits as one-hash-per-line, yes. The entire pipeline I have is this: git rev-list "$old..HEAD" \ | sed 's,.*,https://www.alejandro-colomar.es/src/alx/linux/man-pages/man-pages.git/commit/?h=contrib\&id=&,'; which I run in in my server for printing URIs to all of the newly pushed commits. I use that for easily pasting them to the confirmation email I write to contributors when I apply and push one of their patches. > I would use > git-rev-list(1) instead in that case. Hmmm, thanks! I knew there had to be some git-rev-something for this, but couldn't find it! :) I had workarounded it by doing git log --oneline --abbrev=40 | cut -f1 -d' ' However, git-rev-list(1) is better, of course, so I'll use it. Anyway, it feels awkward that git-log(1) skips the last newline whith --format=format. Should that be fixed? Have a lovely night! Alex > > -- > Kristoffer Haugsbakk > -- ``` ## Andreas Schwab, 2024-12-23 21:09 Subject: Re: git-log --format missing trailing newline character Message-ID: <8734ieyumd.fsf@igel.home> URL: https://gitlist.dev/e/8734ieyumd.fsf%40igel.home In-Reply-To: <5aib7c6x5m6e4muutjuoqp3f4lvpeh3hz5qkwpayi2usm7b6yi@af2oucx5j4w5> ``` On Dez 23 2024, Alejandro Colomar wrote: > Anyway, it feels awkward that git-log(1) skips the last newline whith > --format=format. Should that be fixed? If you want terminator semantics, use tformat: instead of format:. -- Andreas Schwab, schwab@linux-m68k.org GPG Key fingerprint = 7578 EB47 D4E5 4D69 2510 2552 DF73 E780 A9DA AEC1 "And now for something completely different." ``` ## Alejandro Colomar, 2024-12-23 21:23 Subject: Re: git-log --format missing trailing newline character Message-ID: URL: https://gitlist.dev/e/elrdfos3fkzjdmhvyxbshsbt6nw723mr3m7blw7ghghnresxi6%40vvj7u6jwlgur In-Reply-To: <8734ieyumd.fsf@igel.home> ``` Hi Andreas, On Mon, Dec 23, 2024 at 10:09:14PM GMT, Andreas Schwab wrote: > On Dez 23 2024, Alejandro Colomar wrote: > > > Anyway, it feels awkward that git-log(1) skips the last newline whith > > --format=format. Should that be fixed? > > If you want terminator semantics, use tformat: instead of format:. Thanks! Have a lovely night! Alex -- ``` ## Junio C Hamano, 2024-12-26 16:00 Subject: Re: git-log --format missing trailing newline character Message-ID: URL: https://gitlist.dev/e/xmqq4j2qzb6d.fsf%40gitster.g In-Reply-To: ``` Alejandro Colomar writes: > Hi Andreas, > > On Mon, Dec 23, 2024 at 10:09:14PM GMT, Andreas Schwab wrote: >> On Dez 23 2024, Alejandro Colomar wrote: >> >> > Anyway, it feels awkward that git-log(1) skips the last newline whith >> > --format=format. Should that be fixed? >> >> If you want terminator semantics, use tformat: instead of format:. Or, "--format=%H" should do the right thing, as that is a mere short-hand for "--pretty=tformat:%H". ``` ## Alejandro Colomar, 2024-12-26 17:06 Subject: Re: git-log --format missing trailing newline character Message-ID: URL: https://gitlist.dev/e/jwatyfdnn65ot2s3i4uhrseh5kbkudsqv2a6bzmz2xncdzly6v%407gi4gmajls3g In-Reply-To: ``` Hi Junio, On Thu, Dec 26, 2024 at 08:00:42AM -0800, Junio C Hamano wrote: > Alejandro Colomar writes: > > > Hi Andreas, > > > > On Mon, Dec 23, 2024 at 10:09:14PM GMT, Andreas Schwab wrote: > >> On Dez 23 2024, Alejandro Colomar wrote: > >> > >> > Anyway, it feels awkward that git-log(1) skips the last newline whith > >> > --format=format. Should that be fixed? > >> > >> If you want terminator semantics, use tformat: instead of format:. > > Or, "--format=%H" should do the right thing, as that is a mere > short-hand for "--pretty=tformat:%H". Hmmm. So many times having read that part of the manual, and I had never noticed that. I had never seen that tformat existed, and even less that the default was it (when there's %placeholder string). I had always read 'format' instead of 'tformat'. :) Thanks! -- ```