# Build failure on RHEL7 with 2.47.0 4 messages from 2024-10-22 to 2024-10-22. Participants: Mike Lothian, Patrick Steinhardt, Torsten Bögershausen, brian m. carlson. Thread: https://gitlist.dev/t/62389 ## Mike Lothian, 2024-10-22 13:04 Subject: Build failure on RHEL7 with 2.47.0 Message-ID: URL: https://gitlist.dev/e/CAHbf0-GMV9VS7BAjvZiNENNOdZqV3jQ4%2B0k1kTZLkQhFT%3D6D-Q%40mail.gmail.com ``` Hi I'm seeing build failures on RHEL7 when trying to build 2.47.0 - RHEL8 seems to be fine CC t/unit-tests/clar/clar.o CC t/unit-tests/unit-test.o t/unit-tests/clar/clar.c: In function ‘clar_time_now’: t/unit-tests/clar/clar.c:274:18: error: storage size of ‘tz’ isn’t known 274 | struct timezone tz; | ^~ t/unit-tests/clar/clar.c: In function ‘clar_parse_args’: t/unit-tests/clar/clar.c:543:47: warning: implicit declaration of function ‘strdup’; did you mean ‘strcmp’? [-Wimplicit-function-declaration] 543 | _clar.summary_filename = *(argument + 2) ? strdup(argument + 2) : NULL; | ^~~~~~ | strcmp t/unit-tests/clar/clar.c:543:68: warning: pointer/integer type mismatch in conditional expression 543 | _clar.summary_filename = *(argument + 2) ? strdup(argument + 2) : NULL; | ^ t/unit-tests/clar/clar.c: In function ‘clar_test_init’: t/unit-tests/clar/clar.c:569:26: warning: assignment to ‘char *’ from ‘int’ makes pointer from integer without a cast [-Wint-conversion] 569 | _clar.summary_filename = strdup(summary_env); | ^ t/unit-tests/clar/clar.c:573:26: warning: assignment to ‘char *’ from ‘int’ makes pointer from integer without a cast [-Wint-conversion] 573 | _clar.summary_filename = strdup("summary.xml"); | ^ t/unit-tests/clar/clar.c: In function ‘clar__fail’: t/unit-tests/clar/clar.c:692:22: warning: assignment to ‘char *’ from ‘int’ makes pointer from integer without a cast [-Wint-conversion] 692 | error->description = strdup(description); | ^ In file included from t/unit-tests/clar/clar.c:838: t/unit-tests/clar/clar/sandbox.h: In function ‘build_sandbox_path’: t/unit-tests/clar/clar/sandbox.h:138:6: warning: implicit declaration of function ‘mkdtemp’ [-Wimplicit-function-declaration] 138 | if (mkdtemp(_clar_path) == NULL) | ^~~~~~~ t/unit-tests/clar/clar/sandbox.h:138:26: warning: comparison between pointer and integer 138 | if (mkdtemp(_clar_path) == NULL) | ^~ In file included from t/unit-tests/clar/clar.c:92: t/unit-tests/clar/clar/fs.h: In function ‘fs_copy’: t/unit-tests/clar/clar/fs.h:446:16: warning: implicit declaration of function ‘lstat’; did you mean ‘fstat’? [-Wimplicit-function-declaration] 446 | cl_must_pass_(lstat(source, &source_st), "Failed to stat copy source"); | ^~~~~ t/unit-tests/clar/clar.h:89:49: note: in definition of macro ‘cl_must_pass_’ 89 | #define cl_must_pass_(expr, desc) clar__assert((expr) >= 0, __FILE__, __func__, __LINE__, "Function call failed: " #expr, desc, 1) | ^~~~ make: *** [t/unit-tests/clar/clar.o] Error 1 make: *** Waiting for unfinished jobs.... Have I done something silly or is it just too old? Thanks Mike ``` ## Patrick Steinhardt, 2024-10-22 13:55 Subject: Re: Build failure on RHEL7 with 2.47.0 Message-ID: URL: https://gitlist.dev/e/Zxeu7GbcXa-kOzLf%40pks.im In-Reply-To: ``` On Tue, Oct 22, 2024 at 02:04:52PM +0100, Mike Lothian wrote: > Have I done something silly or is it just too old? No, you haven't done anything silly. These are all getting fixed by the patch series posted at [1]. I'd be happy to hear whether those patches fix the issue for you. Patrick [1]: https://lore.kernel.org/git/cover.1729506329.git.ps@pks.im/ ``` ## Torsten Bögershausen, 2024-10-22 14:03 Subject: Re: Build failure on RHEL7 with 2.47.0 Message-ID: <20241022140340.GA31399@tb-raspi4> URL: https://gitlist.dev/e/20241022140340.GA31399%40tb-raspi4 In-Reply-To: ``` On Tue, Oct 22, 2024 at 02:04:52PM +0100, Mike Lothian wrote: > Hi > > I'm seeing build failures on RHEL7 when trying to build 2.47.0 - RHEL8 > seems to be fine > > [] > > Have I done something silly or is it just too old? 2 questions, 2 answers: No, yes. There hasn't been much focus on supporting these/this old platform(s) the last weeks or months. Thanks for reporting, I myself can no longer compile Git under centos 7 any more, but I am happy to work on patches. > > Thanks > > Mike > ``` ## brian m. carlson, 2024-10-22 21:30 Subject: Re: Build failure on RHEL7 with 2.47.0 Message-ID: URL: https://gitlist.dev/e/ZxgZa74fplSUUL5W%40tapette.crustytoothpaste.net In-Reply-To: <20241022140340.GA31399@tb-raspi4> ``` On 2024-10-22 at 14:03:40, Torsten Bögershausen wrote: > On Tue, Oct 22, 2024 at 02:04:52PM +0100, Mike Lothian wrote: > > Hi > > > > I'm seeing build failures on RHEL7 when trying to build 2.47.0 - RHEL8 > > seems to be fine > > > > > [] > > > > Have I done something silly or is it just too old? > > 2 questions, 2 answers: No, yes. > There hasn't been much focus on supporting these/this old platform(s) > the last weeks or months. > Thanks for reporting, I myself can no longer compile Git under centos 7 > any more, but I am happy to work on patches. I think RHEL/CentOS 7 is too old to support according to our platform support policy. It's no longer receiving regular LTS support. The clar patches I do believe will be coming in soon, but I think users will need to upgrade on CentOS 7 nonetheless. -- brian m. carlson (they/them or he/him) Toronto, Ontario, CA ```