Hi All,
I and sasikumar have designed and built a spell checker into
the pre-commit hook, could someone please test it and give us your
comments.Just add the file with same name pre-commit hook to .git/hooks directory in your git project and make it executable.
Regards Deepak
-- Code Code Code Away
Johannes SchindelinRe: Adding spell checker to GIT
Hi,
On Fri, 5 Jan 2007, Deepak Barua wrote:
> I and sasikumar have designed and built a spell checker into > the pre-commit hook, could someone please test it and give us your > comments.
It's a rather big chunk of code, and it is in perl, so I'd rather put it in another file, but oh well.
There are a few remaining problems, and I don't even know if the second can be solved:
- you miss "//" comments,
- if the diff is only about a small part of a comment, you do not spell
check that
- you do not spell check literal messages (i.e. printf("No such fiel!"))Ciao, Dscho
Re: Adding spell checker to GIT
Hi Johannes,
I spell check "//" comments in
in find_ext()if($_[0] =~ /\.cc|\.java/) { $start_pattern = qr!\s/\*\s|\s//\s!;
}and
$chosen_pattern eq qq!\s//\s! ? $end_pattern=qq!\s\014\s! : "End Pattern Not Found" ;
Also yes i didnt include to use spell checking in string literals , i thought that would be irregular and cumbersome.
Could you please test the code then i can include it in a seperate file ..?
Regards Deepak
On 1/6/07, Johannes Schindelin <Johannes.Schindelin@gmx.de> wrote:
> Hi,
>
> On Fri, 5 Jan 2007, Deepak Barua wrote:
>
> > I and sasikumar have designed and built a spell checker into
> > the pre-commit hook, could someone please test it and give us your
> > comments.
>
> It's a rather big chunk of code, and it is in perl, so I'd rather put it
> in another file, but oh well.
>
> There are a few remaining problems, and I don't even know if the second
> can be solved:
>
> - you miss "//" comments,
> - if the diff is only about a small part of a comment, you do not spell
> check that
> - you do not spell check literal messages (i.e. printf("No such fiel!"))
>
> Ciao,
> Dscho
>
>-- Code Code Code Away
Johannes SchindelinRe: Adding spell checker to GIT
Hi,
On Sat, 6 Jan 2007, Deepak Barua wrote:
> Hi Johannes,
> I spell check "//" comments in
> in find_ext()
>
> if($_[0] =~ /\.cc|\.java/) {
>
> $start_pattern = qr!\s/\*\s|\s//\s!;
> }
>
> and
>
> $chosen_pattern eq qq!\s//\s! ? $end_pattern=qq!\s\014\s! : "End
> Pattern Not Found" ;
>
> Also yes i didnt include to use spell checking in string literals , i
> thought that would be irregular and cumbersome.
>
> Could you please test the code then i can include it in a seperate file ..?Sorry, I am a little bit stressed at the moment... And I don't have the required dependencies installed.
Ciao, Dscho
Re: Adding spell checker to GIT
Hi Johannes,
It's okay take your time and suggest any changes and
teach me how to make this code into a proper patch.Regards Deepak
On 1/16/07, Johannes Schindelin <Johannes.Schindelin@gmx.de> wrote:
> Hi,
>
> On Sat, 6 Jan 2007, Deepak Barua wrote:
>
> > Hi Johannes,
> > I spell check "//" comments in
> > in find_ext()
> >
> > if($_[0] =~ /\.cc|\.java/) {
> >
> > $start_pattern = qr!\s/\*\s|\s//\s!;
> > }
> >
> > and
> >
> > $chosen_pattern eq qq!\s//\s! ? $end_pattern=qq!\s\014\s! : "End
> > Pattern Not Found" ;
> >
> > Also yes i didnt include to use spell checking in string literals , i
> > thought that would be irregular and cumbersome.
> >
> > Could you please test the code then i can include it in a seperate file ..?
>
> Sorry, I am a little bit stressed at the moment... And I don't have the
> required dependencies installed.
>
> Ciao,
> Dscho
>
>-- Code Code Code Away
Re: Adding spell checker to GIT
Hi Johannes,
What about the spell checker...?Regards Deepak
On 1/16/07, Deepak Barua <dbbarua@gmail.com> wrote:
> Hi Johannes,
> It's okay take your time and suggest any changes and
> teach me how to make this code into a proper patch.
>
> Regards
> Deepak
>
> On 1/16/07, Johannes Schindelin <Johannes.Schindelin@gmx.de> wrote:
> > Hi,
> >
> > On Sat, 6 Jan 2007, Deepak Barua wrote:
> >
> > > Hi Johannes,
> > > I spell check "//" comments in
> > > in find_ext()
> > >
> > > if($_[0] =~ /\.cc|\.java/) {
> > >
> > > $start_pattern = qr!\s/\*\s|\s//\s!;
> > > }
> > >
> > > and
> > >
> > > $chosen_pattern eq qq!\s//\s! ? $end_pattern=qq!\s\014\s! : "End
> > > Pattern Not Found" ;
> > >
> > > Also yes i didnt include to use spell checking in string literals , i
> > > thought that would be irregular and cumbersome.
> > >
> > > Could you please test the code then i can include it in a seperate file ..?
> >
> > Sorry, I am a little bit stressed at the moment... And I don't have the
> > required dependencies installed.
> >
> > Ciao,
> > Dscho
> >
> >
>
>
> --
> Code Code Code Away
>-- Code Code Code Away
Johannes SchindelinRe: Adding spell checker to GIT
Hi,
On Thu, 25 Jan 2007, Deepak Barua wrote:
> What about the spell checker...?
Sorry, time is scarce these days. (And I can't do it on the machines I am right now working on, since I may not install perl packages.)
Ciao, Dscho
Re: Adding spell checker to GIT
Hi Johannes,
cold you atleast tell me how to make it a patch so
i can officially submit it and others can test it ...?Regards Deepak
On 1/25/07, Johannes Schindelin <Johannes.Schindelin@gmx.de> wrote:
> Hi, > > On Thu, 25 Jan 2007, Deepak Barua wrote: > > > What about the spell checker...? > > Sorry, time is scarce these days. (And I can't do it on the machines I am > right now working on, since I may not install perl packages.) > > Ciao, > Dscho > >
-- Code Code Code Away