# [PATCH] Remove shadowing variable from traverse_trees()

1 messages from 2007-01-04 to 2007-01-04. Participants: René Scharfe.
Thread: https://gitlist.dev/t/6222

## René Scharfe, 2007-01-04 18:33

Subject: [PATCH] Remove shadowing variable from traverse_trees()
Message-ID: <459D4880.9070804@lsrfire.ath.cx>
URL: https://gitlist.dev/e/459D4880.9070804%40lsrfire.ath.cx

```
The variable named entry is allocated using malloc() and then
forgotten, it being shadowed by an automatic variable of the
same name.  Fixing the array size at 3 worked so far because
the only caller of traverse_trees() needed only as much
entries.  Simply remove the shadowing varaible and we're able
to traverse more than three trees and save stack space at the
same time!

Signed-off-by: Rene Scharfe <rene.scharfe@lsrfire.ath.cx>
---
 tree-walk.c |    1 -
 1 files changed, 0 insertions(+), 1 deletions(-)

diff --git a/tree-walk.c b/tree-walk.c
index 14cc5ae..22f4550 100644
--- a/tree-walk.c
+++ b/tree-walk.c
@@ -113,7 +113,6 @@ void traverse_trees(int n, struct tree_desc *t, const char *base, traverse_callb
 	struct name_entry *entry = xmalloc(n*sizeof(*entry));
 
 	for (;;) {
-		struct name_entry entry[3];
 		unsigned long mask = 0;
 		int i, last;
 

```