# [PATCH] commit-graph: remove unnecessary UNLEAK 1 messages from 2024-09-22 to 2024-09-22. Participants: René Scharfe. Thread: https://gitlist.dev/t/62169 ## René Scharfe, 2024-09-22 13:40 Subject: [PATCH] commit-graph: remove unnecessary UNLEAK Message-ID: URL: https://gitlist.dev/e/c3a712d5-8e50-453d-be90-f5bf34de744c%40web.de ``` When f4dbdfc4d5 (commit-graph: clean up leaked memory during write, 2018-10-03) added the UNLEAK, it was right before a call to die_errno(). e103f7276f (commit-graph: return with errors during write, 2019-06-12) made it unnecessary, as it was then followed by a free() call for the allocated string. The code moved to write_commit_graph_file() in the meantime and the string pointer is now part of a struct, but the function's only caller still cleans up the allocation. Drop the superfluous UNLEAK. Signed-off-by: René Scharfe --- commit-graph.c | 1 - 1 file changed, 1 deletion(-) diff --git a/commit-graph.c b/commit-graph.c index aa6e08eb39..5bd89c0acd 100644 --- a/commit-graph.c +++ b/commit-graph.c @@ -2055,7 +2055,6 @@ static int write_commit_graph_file(struct write_commit_graph_context *ctx) } if (safe_create_leading_directories(ctx->graph_name)) { - UNLEAK(ctx->graph_name); error(_("unable to create leading directories of %s"), ctx->graph_name); return -1; -- 2.46.0 ```