# [PATCH] cbtree: fix a typo 4 messages from 2024-09-15 to 2024-09-16. Participants: Andrew Kreimer, Patrick Steinhardt, Junio C Hamano. Thread: https://gitlist.dev/t/62118 ## Andrew Kreimer, 2024-09-15 23:05 Subject: [PATCH] cbtree: fix a typo Message-ID: <20240915230522.129253-1-algonell@gmail.com> URL: https://gitlist.dev/e/20240915230522.129253-1-algonell%40gmail.com ``` Fix a typo in comments. Signed-off-by: Andrew Kreimer --- cbtree.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/cbtree.c b/cbtree.c index c1cc30a5dc..cf8cf75b89 100644 --- a/cbtree.c +++ b/cbtree.c @@ -12,7 +12,7 @@ static struct cb_node *cb_node_of(const void *p) return (struct cb_node *)((uintptr_t)p - 1); } -/* locate the best match, does not do a final comparision */ +/* locate the best match, does not do a final comparison */ static struct cb_node *cb_internal_best_match(struct cb_node *p, const uint8_t *k, size_t klen) { -- 2.39.5 ``` ## Patrick Steinhardt, 2024-09-16 07:30 Subject: Re: [PATCH] cbtree: fix a typo Message-ID: URL: https://gitlist.dev/e/Zufef70mfdUwSwnY%40pks.im In-Reply-To: <20240915230522.129253-1-algonell@gmail.com> ``` On Mon, Sep 16, 2024 at 02:05:22AM +0300, Andrew Kreimer wrote: > Fix a typo in comments. > > Signed-off-by: Andrew Kreimer Thanks for these fixes, all three of them look good to me. For future such patch series I'd recommend to send a single series that combines such related fixes. It makes it a bit easier to keep track of these similar patches and review them in one go. > --- > cbtree.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/cbtree.c b/cbtree.c > index c1cc30a5dc..cf8cf75b89 100644 > --- a/cbtree.c > +++ b/cbtree.c > @@ -12,7 +12,7 @@ static struct cb_node *cb_node_of(const void *p) > return (struct cb_node *)((uintptr_t)p - 1); > } > > -/* locate the best match, does not do a final comparision */ > +/* locate the best match, does not do a final comparison */ > static struct cb_node *cb_internal_best_match(struct cb_node *p, > const uint8_t *k, size_t klen) > { We might convert this to be a proper sentence while at it, namely s/locate/Locate/ and s/comparison/&./. But no need to reroll this patch for that, as your change is a strict improvement by itself already. Thanks! Patrick ``` ## Andrew Kreimer, 2024-09-16 09:52 Subject: Re: [PATCH] cbtree: fix a typo Message-ID: URL: https://gitlist.dev/e/Zuf_3mNRm3KuQxlV%40void.void In-Reply-To: ``` On Mon, Sep 16, 2024 at 09:30:07AM +0200, Patrick Steinhardt wrote: > On Mon, Sep 16, 2024 at 02:05:22AM +0300, Andrew Kreimer wrote: > > Fix a typo in comments. > > > > Signed-off-by: Andrew Kreimer > > Thanks for these fixes, all three of them look good to me. For future > such patch series I'd recommend to send a single series that combines > such related fixes. It makes it a bit easier to keep track of these > similar patches and review them in one go. > Understood. > > --- > > cbtree.c | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > diff --git a/cbtree.c b/cbtree.c > > index c1cc30a5dc..cf8cf75b89 100644 > > --- a/cbtree.c > > +++ b/cbtree.c > > @@ -12,7 +12,7 @@ static struct cb_node *cb_node_of(const void *p) > > return (struct cb_node *)((uintptr_t)p - 1); > > } > > > > -/* locate the best match, does not do a final comparision */ > > +/* locate the best match, does not do a final comparison */ > > static struct cb_node *cb_internal_best_match(struct cb_node *p, > > const uint8_t *k, size_t klen) > > { > > We might convert this to be a proper sentence while at it, namely > s/locate/Locate/ and s/comparison/&./. But no need to reroll this patch > for that, as your change is a strict improvement by itself already. > > Thanks! > > Patrick Thank you! ``` ## Junio C Hamano, 2024-09-16 17:50 Subject: Re: [PATCH] cbtree: fix a typo Message-ID: URL: https://gitlist.dev/e/xmqq34lzqyi8.fsf%40gitster.g In-Reply-To: ``` Andrew Kreimer writes: >> Thanks! >> >> Patrick > > Thank you! Will queue. Thanks. ```