threads / patch / 6199

patchgit-tag: add flag to verify a tag

Subject: [PATCH] git-tag: add flag to verify a tag

## tl;dr

4 messages between Jan 3, 2007 and Jan 3, 2007. Diffs are folded; open one to read it.

replies: 3people: 2as markdown or json

Santi Béjar· Jan 3, 2007, 12:59 UTC · lore

This way "git tag -v $tag" is the UI for git-verify-tag.
---
 Documentation/git-tag.txt |    7 ++++++-
 generate-cmdlist.sh       |    1 -
 git-tag.sh                |   10 +++++++++-
 3 files changed, 15 insertions(+), 3 deletions(-)

Show changes to 3 files +15 −3

Documentation/git-tag.txt, generate-cmdlist.sh, git-tag.sh

diff --git a/Documentation/git-tag.txt b/Documentation/git-tag.txt
index 48b82b8..80bece0 100644
--- a/Documentation/git-tag.txt
+++ b/Documentation/git-tag.txt
@@ -9,7 +9,7 @@ git-tag - Create a tag object signed with GPG
 SYNOPSIS
 --------
 [verse]
-'git-tag' [-a | -s | -u <key-id>] [-f | -d] [-m <msg> | -F <file>]
+'git-tag' [-a | -s | -u <key-id>] [-f | -d | -v] [-m <msg> | -F <file>]
 	 <name> [<head>]
 'git-tag' -l [<pattern>]
 
@@ -35,6 +35,8 @@ GnuPG key for signing.
 
 `-d <tag>` deletes the tag.
 
+`-v <tag>` verifies the gpg signature of the tag.
+
 `-l <pattern>` lists tags that match the given pattern (or all
 if no pattern is given).
 
@@ -55,6 +57,9 @@ OPTIONS
 -d::
 	Delete an existing tag with the given name
 
+-v::
+	Verify the gpg signature of given the tag
+
 -l <pattern>::
 	List tags that match the given pattern (or all if no pattern is given).
 
diff --git a/generate-cmdlist.sh b/generate-cmdlist.sh
index 06c42b0..1de14ea 100755
--- a/generate-cmdlist.sh
+++ b/generate-cmdlist.sh
@@ -37,7 +37,6 @@ show
 show-branch
 status
 tag
-verify-tag
 EOF
 while read cmd
 do
diff --git a/git-tag.sh b/git-tag.sh
index e1bfa82..c9e1180 100755
--- a/git-tag.sh
+++ b/git-tag.sh
@@ -1,7 +1,7 @@
 #!/bin/sh
 # Copyright (c) 2005 Linus Torvalds
 
-USAGE='-l [<pattern>] | [-a | -s | -u <key-id>] [-f | -d] [-m <msg>] <tagname> [<head>]'
+USAGE='-l [<pattern>] | [-a | -s | -u <key-id>] [-f | -d | -v] [-m <msg>] <tagname> [<head>]'
 SUBDIRECTORY_OK='Yes'
 . git-sh-setup
 
@@ -12,6 +12,7 @@ force=
 message=
 username=
 list=
+verify=
 while case "$#" in 0) break ;; esac
 do
     case "$1" in
@@ -69,6 +70,13 @@ do
 		echo "Deleted tag $tag_name."
 	exit $?
 	;;
+    -v)
+	shift
+	tag_name="$1"
+	tag=$(git-show-ref --verify --hash -- "refs/tags/$tag_name") ||
+		die "Seriously, what tag are you talking about?"
+	git-verify-tag -v "$tag"
+	exit $?
     -*)
         usage
 	;;

-- 
1.5.0.rc0.g91ea

Junio C Hamano· Jan 3, 2007, 16:25 UTC · re: Santi Béjar · lore

Re: [PATCH] git-tag: add flag to verify a tag

Santi Béjar <sbejar@gmail.com> writes:

> This way "git tag -v $tag" is the UI for git-verify-tag.
> ---
>  Documentation/git-tag.txt |    7 ++++++-
> ...

Signoffs?

Santi Béjar· Jan 3, 2007, 16:36 UTC · re: Junio C Hamano · lore

Re: [PATCH] git-tag: add flag to verify a tag

On 1/3/07, Junio C Hamano <junkio@cox.net> wrote:

Show 9 quoted lines

> Santi Béjar <sbejar@gmail.com> writes:
>
> > This way "git tag -v $tag" is the UI for git-verify-tag.
> > ---
> >  Documentation/git-tag.txt |    7 ++++++-
> > ...
>
>
> Signoffs?

Forgotten, long time since the last patch :-|

Signed-off-by: Santi Béjar <sbejar@gmail.com>

Santi

Santi Béjar· Jan 3, 2007, 23:17 UTC · re: Santi Béjar · lore

[PATCH take 2] git-tag: add flag to verify a tag

This way "git tag -v $tag" is the UI for git-verify-tag.

Signed-off-by: Santi Béjar <sbejar@gmail.com>
---
 Hi *,

 But maybe the -v flag should give a similar output as:

 $ git branch -v

 Then this flag could be -c for check?

 This version has a syntax fix (sorry) and a typo fix.

 Documentation/git-tag.txt |    7 ++++++-
 generate-cmdlist.sh       |    1 -
 git-tag.sh                |   11 ++++++++++-
 3 files changed, 16 insertions(+), 3 deletions(-)

Show changes to 3 files +15 −3

Documentation/git-tag.txt, generate-cmdlist.sh, git-tag.sh

diff --git a/Documentation/git-tag.txt b/Documentation/git-tag.txt
index 48b82b8..5cf114d 100644
--- a/Documentation/git-tag.txt
+++ b/Documentation/git-tag.txt
@@ -9,7 +9,7 @@ git-tag - Create a tag object signed with GPG
 SYNOPSIS
 --------
 [verse]
-'git-tag' [-a | -s | -u <key-id>] [-f | -d] [-m <msg> | -F <file>]
+'git-tag' [-a | -s | -u <key-id>] [-f | -d | -v] [-m <msg> | -F <file>]
 	 <name> [<head>]
 'git-tag' -l [<pattern>]
 
@@ -35,6 +35,8 @@ GnuPG key for signing.
 
 `-d <tag>` deletes the tag.
 
+`-v <tag>` verifies the gpg signature of the tag.
+
 `-l <pattern>` lists tags that match the given pattern (or all
 if no pattern is given).
 
@@ -55,6 +57,9 @@ OPTIONS
 -d::
 	Delete an existing tag with the given name
 
+-v::
+	Verify the gpg signature of the given tag
+
 -l <pattern>::
 	List tags that match the given pattern (or all if no pattern is given).
 
diff --git a/generate-cmdlist.sh b/generate-cmdlist.sh
index 06c42b0..1de14ea 100755
--- a/generate-cmdlist.sh
+++ b/generate-cmdlist.sh
@@ -37,7 +37,6 @@ show
 show-branch
 status
 tag
-verify-tag
 EOF
 while read cmd
 do
diff --git a/git-tag.sh b/git-tag.sh
index e1bfa82..c3e4e15 100755
--- a/git-tag.sh
+++ b/git-tag.sh
@@ -1,7 +1,7 @@
 #!/bin/sh
 # Copyright (c) 2005 Linus Torvalds
 
-USAGE='-l [<pattern>] | [-a | -s | -u <key-id>] [-f | -d] [-m <msg>] <tagname> [<head>]'
+USAGE='-l [<pattern>] | [-a | -s | -u <key-id>] [-f | -d | -v] [-m <msg>] <tagname> [<head>]'
 SUBDIRECTORY_OK='Yes'
 . git-sh-setup
 
@@ -69,6 +69,14 @@ do
 		echo "Deleted tag $tag_name."
 	exit $?
 	;;
+    -v)
+	shift
+	tag_name="$1"
+	tag=$(git-show-ref --verify --hash -- "refs/tags/$tag_name") ||
+		die "Seriously, what tag are you talking about?"
+	git-verify-tag -v "$tag"
+	exit $?
+	;;
     -*)
         usage
 	;;

-- 
1.5.0.rc0.g1eb3