threads / patch / 6168

patch, 4 partsUse PATH_MAX constant for --bare.

Subject: [PATCH 1/4] Use PATH_MAX constant for --bare.

## tl;dr

One message between Dec 31, 2006 and Dec 31, 2006. Diffs are folded; open one to read it.

replies: 0people: 1as markdown or json

Shawn O. Pearce· Dec 31, 2006, 04:28 UTC · lore

For easier portability we prefer PATH_MAX over seemingly random constants like 1024. Make it so.

Signed-off-by: Shawn O. Pearce <spearce@spearce.org>
---
 git.c |    4 ++--
 1 files changed, 2 insertions(+), 2 deletions(-)
Show changes to git.c +2 −2
diff --git a/git.c b/git.c
index 50ebd86..ec897dc 100644
--- a/git.c
+++ b/git.c
@@ -69,8 +69,8 @@ static int handle_options(const char*** argv, int* argc)
 		} else if (!strncmp(cmd, "--git-dir=", 10)) {
 			setenv("GIT_DIR", cmd + 10, 1);
 		} else if (!strcmp(cmd, "--bare")) {
-			static char git_dir[1024];
-			setenv("GIT_DIR", getcwd(git_dir, 1024), 1);
+			static char git_dir[PATH_MAX+1];
+			setenv("GIT_DIR", getcwd(git_dir, sizeof(git_dir)), 1);
 		} else {
 			fprintf(stderr, "Unknown option: %s\n", cmd);
 			usage(git_usage_string);
-- 
1.5.0.rc0.g6bb1

← back to recent threads